* [MPTCP] Re: [PATCH v2] mptcp: reset 'first' and ack_hint on subflow close
@ 2021-02-23 9:24 Matthieu Baerts
0 siblings, 0 replies; only message in thread
From: Matthieu Baerts @ 2021-02-23 9:24 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 959 bytes --]
Hi Florian, Paolo,
On 22/02/2021 17:18, Florian Westphal wrote:
> Just like with last_snd, we have to NULL 'first' on subflow close.
>
> ack_hint isn't strictly required (its never dereferenced), but better to
> clear this explicitly as well instead of making it an exception.
>
> msk->first is dereferenced unconditionally at accept time, but
> at that point the ssk is not on the conn_list yet -- this means
> worker can't see it when iterating the conn_list.
>
> Reported-by: Paolo Abeni <pabeni(a)redhat.com>
> Signed-off-by: Florian Westphal <fw(a)strlen.de>
Thank you for this patch!
Just applied in our tree, after "mptcp: dispose initial struct socket
when its subflow is closed" with my RvB tag.
- 15d29d726a6e: mptcp: reset 'first' and ack_hint on subflow close
- Results: b5622a37311b..45795e8f868e
Tests + export are in progress!
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-02-23 9:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23 9:24 [MPTCP] Re: [PATCH v2] mptcp: reset 'first' and ack_hint on subflow close Matthieu Baerts
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.