* [PATCH] qla2xxx: fix error status checking in qla24xx_modify_vp_config()
@ 2022-01-05 13:03 Dirk Müller
2022-01-06 15:35 ` Martin Wilck
0 siblings, 1 reply; 2+ messages in thread
From: Dirk Müller @ 2022-01-05 13:03 UTC (permalink / raw)
To: linux-scsi; +Cc: Dirk Müller
The function was checking vpmod->comp_status and reported it as error
status, which is however already checked a few lines below.
Guessing from other occurrences it was supposed to check entry_status
instead.
Fixes: 2c3dfe3f6ad8 ("[SCSI] qla2xxx: add support for NPIV")
Signed-off-by: Dirk Müller <dmueller@suse.de>
---
drivers/scsi/qla2xxx/qla_mbx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
index 10d2655ef676..e0dce38b65cf 100644
--- a/drivers/scsi/qla2xxx/qla_mbx.c
+++ b/drivers/scsi/qla2xxx/qla_mbx.c
@@ -4253,7 +4253,7 @@ qla24xx_modify_vp_config(scsi_qla_host_t *vha)
if (rval != QLA_SUCCESS) {
ql_dbg(ql_dbg_mbx, vha, 0x10bd,
"Failed to issue VP config IOCB (%x).\n", rval);
- } else if (vpmod->comp_status != 0) {
+ } else if (vpmod->entry_status != 0) {
ql_dbg(ql_dbg_mbx, vha, 0x10be,
"Failed to complete IOCB -- error status (%x).\n",
vpmod->comp_status);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] qla2xxx: fix error status checking in qla24xx_modify_vp_config()
2022-01-05 13:03 [PATCH] qla2xxx: fix error status checking in qla24xx_modify_vp_config() Dirk Müller
@ 2022-01-06 15:35 ` Martin Wilck
0 siblings, 0 replies; 2+ messages in thread
From: Martin Wilck @ 2022-01-06 15:35 UTC (permalink / raw)
To: Dirk Müller, linux-scsi; +Cc: Nilesh Javali, GR-QLogic-Storage-Upstream
On Wed, 2022-01-05 at 14:03 +0100, Dirk Müller wrote:
> The function was checking vpmod->comp_status and reported it as error
> status, which is however already checked a few lines below.
>
> Guessing from other occurrences it was supposed to check entry_status
> instead.
>
> Fixes: 2c3dfe3f6ad8 ("[SCSI] qla2xxx: add support for NPIV")
> Signed-off-by: Dirk Müller <dmueller@suse.de>
> ---
> drivers/scsi/qla2xxx/qla_mbx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_mbx.c
> b/drivers/scsi/qla2xxx/qla_mbx.c
> index 10d2655ef676..e0dce38b65cf 100644
> --- a/drivers/scsi/qla2xxx/qla_mbx.c
> +++ b/drivers/scsi/qla2xxx/qla_mbx.c
> @@ -4253,7 +4253,7 @@ qla24xx_modify_vp_config(scsi_qla_host_t *vha)
> if (rval != QLA_SUCCESS) {
> ql_dbg(ql_dbg_mbx, vha, 0x10bd,
> "Failed to issue VP config IOCB (%x).\n", rval);
> - } else if (vpmod->comp_status != 0) {
> + } else if (vpmod->entry_status != 0) {
> ql_dbg(ql_dbg_mbx, vha, 0x10be,
> "Failed to complete IOCB -- error status
> (%x).\n",
> vpmod->comp_status);
Your suggestion makes sense, but you should also change the value
passed to ql_dbg(), and cc the driver maintainers.
Thanks,
Martin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-06 15:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-05 13:03 [PATCH] qla2xxx: fix error status checking in qla24xx_modify_vp_config() Dirk Müller
2022-01-06 15:35 ` Martin Wilck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.