[linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1750 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   e71e3a48a7e89fa71fb70bf4602367528864d2ff
commit: 56ebc9b0d77e0406aba2d900c82e79204cc7dc32 [5946/11253] memory: tegra: Enable compile testing for all drivers
config: x86_64-randconfig-a001-20210618 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=56ebc9b0d77e0406aba2d900c82e79204cc7dc32
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 56ebc9b0d77e0406aba2d900c82e79204cc7dc32
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

Note: the linux-next/master HEAD e71e3a48a7e89fa71fb70bf4602367528864d2ff builds fine.
      It may have been fixed somewhere.

All errors (new ones prefixed by >>):

>> ld.lld: error: undefined symbol: reset_controller_register
   >>> referenced by mc.c
   >>>               memory/tegra/mc.o:(tegra_mc_probe) in archive drivers/built-in.a

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 44444 bytes --]

[linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1784 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   e71e3a48a7e89fa71fb70bf4602367528864d2ff
commit: 56ebc9b0d77e0406aba2d900c82e79204cc7dc32 [5946/11253] memory: tegra: Enable compile testing for all drivers
config: x86_64-randconfig-a001-20210618 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=56ebc9b0d77e0406aba2d900c82e79204cc7dc32
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 56ebc9b0d77e0406aba2d900c82e79204cc7dc32
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

Note: the linux-next/master HEAD e71e3a48a7e89fa71fb70bf4602367528864d2ff builds fine.
      It may have been fixed somewhere.

All errors (new ones prefixed by >>):

>> ld.lld: error: undefined symbol: reset_controller_register
   >>> referenced by mc.c
   >>>               memory/tegra/mc.o:(tegra_mc_probe) in archive drivers/built-in.a

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 44444 bytes --]

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 2192 bytes --]

On Fri, Jun 18, 2021 at 04:21:45PM +0200, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   e71e3a48a7e89fa71fb70bf4602367528864d2ff
> commit: 56ebc9b0d77e0406aba2d900c82e79204cc7dc32 [5946/11253] memory: tegra: Enable compile testing for all drivers
> config: x86_64-randconfig-a001-20210618 (attached as .config)
> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install x86_64 cross compiling tool for clang build
>         # apt-get install binutils-x86-64-linux-gnu
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=56ebc9b0d77e0406aba2d900c82e79204cc7dc32
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout 56ebc9b0d77e0406aba2d900c82e79204cc7dc32
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> Note: the linux-next/master HEAD e71e3a48a7e89fa71fb70bf4602367528864d2ff builds fine.
>       It may have been fixed somewhere.
> 
> All errors (new ones prefixed by >>):
> 
> >> ld.lld: error: undefined symbol: reset_controller_register
>    >>> referenced by mc.c
>    >>>               memory/tegra/mc.o:(tegra_mc_probe) in archive drivers/built-in.a

Ugh... more fallout from that compile-test enablement. It looks like
that compile-test stubs addition patch for reset hasn't found its way
into linux-next yet.

Philipp, I wonder if it would make sense for Krzysztof to pick up that
patch or, if you prefer, for Krzysztof to pull a stable branch from you
that includes this so that the memory controller tree becomes buildable
again?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 2192 bytes --]

On Fri, Jun 18, 2021 at 04:21:45PM +0200, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   e71e3a48a7e89fa71fb70bf4602367528864d2ff
> commit: 56ebc9b0d77e0406aba2d900c82e79204cc7dc32 [5946/11253] memory: tegra: Enable compile testing for all drivers
> config: x86_64-randconfig-a001-20210618 (attached as .config)
> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install x86_64 cross compiling tool for clang build
>         # apt-get install binutils-x86-64-linux-gnu
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=56ebc9b0d77e0406aba2d900c82e79204cc7dc32
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout 56ebc9b0d77e0406aba2d900c82e79204cc7dc32
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> Note: the linux-next/master HEAD e71e3a48a7e89fa71fb70bf4602367528864d2ff builds fine.
>       It may have been fixed somewhere.
> 
> All errors (new ones prefixed by >>):
> 
> >> ld.lld: error: undefined symbol: reset_controller_register
>    >>> referenced by mc.c
>    >>>               memory/tegra/mc.o:(tegra_mc_probe) in archive drivers/built-in.a

Ugh... more fallout from that compile-test enablement. It looks like
that compile-test stubs addition patch for reset hasn't found its way
into linux-next yet.

Philipp, I wonder if it would make sense for Krzysztof to pick up that
patch or, if you prefer, for Krzysztof to pull a stable branch from you
that includes this so that the memory controller tree becomes buildable
again?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Krzysztof Kozlowski]

On 18/06/2021 16:52, Thierry Reding wrote:
> On Fri, Jun 18, 2021 at 04:21:45PM +0200, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> head:   e71e3a48a7e89fa71fb70bf4602367528864d2ff
>> commit: 56ebc9b0d77e0406aba2d900c82e79204cc7dc32 [5946/11253] memory: tegra: Enable compile testing for all drivers
>> config: x86_64-randconfig-a001-20210618 (attached as .config)
>> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
>> reproduce (this is a W=1 build):
>>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         # install x86_64 cross compiling tool for clang build
>>         # apt-get install binutils-x86-64-linux-gnu
>>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=56ebc9b0d77e0406aba2d900c82e79204cc7dc32
>>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>>         git fetch --no-tags linux-next master
>>         git checkout 56ebc9b0d77e0406aba2d900c82e79204cc7dc32
>>         # save the attached .config to linux build tree
>>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> Note: the linux-next/master HEAD e71e3a48a7e89fa71fb70bf4602367528864d2ff builds fine.
>>       It may have been fixed somewhere.
>>
>> All errors (new ones prefixed by >>):
>>
>>>> ld.lld: error: undefined symbol: reset_controller_register
>>    >>> referenced by mc.c
>>    >>>               memory/tegra/mc.o:(tegra_mc_probe) in archive drivers/built-in.a
> 
> Ugh... more fallout from that compile-test enablement. It looks like
> that compile-test stubs addition patch for reset hasn't found its way
> into linux-next yet.

Does it mean reset tree is not in linux-next?

> Philipp, I wonder if it would make sense for Krzysztof to pick up that
> patch or, if you prefer, for Krzysztof to pull a stable branch from you
> that includes this so that the memory controller tree becomes buildable
> again?

These are randconfigs, so I don't think Linus will hit them when
merging. Therefore assuming the reset-stubs are applied (and tree is in
next), we should be fine, shouldn't we?

Best regards,
Krzysztof

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Krzysztof Kozlowski]

[-- Attachment #1: Type: text/plain, Size: 2523 bytes --]

On 18/06/2021 16:52, Thierry Reding wrote:
> On Fri, Jun 18, 2021 at 04:21:45PM +0200, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> head:   e71e3a48a7e89fa71fb70bf4602367528864d2ff
>> commit: 56ebc9b0d77e0406aba2d900c82e79204cc7dc32 [5946/11253] memory: tegra: Enable compile testing for all drivers
>> config: x86_64-randconfig-a001-20210618 (attached as .config)
>> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
>> reproduce (this is a W=1 build):
>>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         # install x86_64 cross compiling tool for clang build
>>         # apt-get install binutils-x86-64-linux-gnu
>>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=56ebc9b0d77e0406aba2d900c82e79204cc7dc32
>>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>>         git fetch --no-tags linux-next master
>>         git checkout 56ebc9b0d77e0406aba2d900c82e79204cc7dc32
>>         # save the attached .config to linux build tree
>>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> Note: the linux-next/master HEAD e71e3a48a7e89fa71fb70bf4602367528864d2ff builds fine.
>>       It may have been fixed somewhere.
>>
>> All errors (new ones prefixed by >>):
>>
>>>> ld.lld: error: undefined symbol: reset_controller_register
>>    >>> referenced by mc.c
>>    >>>               memory/tegra/mc.o:(tegra_mc_probe) in archive drivers/built-in.a
> 
> Ugh... more fallout from that compile-test enablement. It looks like
> that compile-test stubs addition patch for reset hasn't found its way
> into linux-next yet.

Does it mean reset tree is not in linux-next?

> Philipp, I wonder if it would make sense for Krzysztof to pick up that
> patch or, if you prefer, for Krzysztof to pull a stable branch from you
> that includes this so that the memory controller tree becomes buildable
> again?

These are randconfigs, so I don't think Linus will hit them when
merging. Therefore assuming the reset-stubs are applied (and tree is in
next), we should be fine, shouldn't we?

Best regards,
Krzysztof

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Matthew Wilcox]

On Fri, Jun 18, 2021 at 04:55:23PM +0200, Krzysztof Kozlowski wrote:
> These are randconfigs, so I don't think Linus will hit them when
> merging. Therefore assuming the reset-stubs are applied (and tree is in
> next), we should be fine, shouldn't we?

It's a bisection hazard.  Please fix it before the merge.  This is
exactly the kind of thing that linux-next is designed to detect.

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Matthew Wilcox]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

On Fri, Jun 18, 2021 at 04:55:23PM +0200, Krzysztof Kozlowski wrote:
> These are randconfigs, so I don't think Linus will hit them when
> merging. Therefore assuming the reset-stubs are applied (and tree is in
> next), we should be fine, shouldn't we?

It's a bisection hazard.  Please fix it before the merge.  This is
exactly the kind of thing that linux-next is designed to detect.

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Krzysztof Kozlowski]

On 18/06/2021 17:00, Matthew Wilcox wrote:
> On Fri, Jun 18, 2021 at 04:55:23PM +0200, Krzysztof Kozlowski wrote:
>> These are randconfigs, so I don't think Linus will hit them when
>> merging. Therefore assuming the reset-stubs are applied (and tree is in
>> next), we should be fine, shouldn't we?
> 
> It's a bisection hazard.  Please fix it before the merge.  This is
> exactly the kind of thing that linux-next is designed to detect.

Still hazard for a compile testing configuration, not a real bisection
for troubleshooting bugs. You cannot hit the bug in any real case (so
!COMPILE_TEST).

The only way to reduce the bisection hazard is me to take reset stubs.

Best regards,
Krzysztof

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Krzysztof Kozlowski]

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]

On 18/06/2021 17:00, Matthew Wilcox wrote:
> On Fri, Jun 18, 2021 at 04:55:23PM +0200, Krzysztof Kozlowski wrote:
>> These are randconfigs, so I don't think Linus will hit them when
>> merging. Therefore assuming the reset-stubs are applied (and tree is in
>> next), we should be fine, shouldn't we?
> 
> It's a bisection hazard.  Please fix it before the merge.  This is
> exactly the kind of thing that linux-next is designed to detect.

Still hazard for a compile testing configuration, not a real bisection
for troubleshooting bugs. You cannot hit the bug in any real case (so
!COMPILE_TEST).

The only way to reduce the bisection hazard is me to take reset stubs.

Best regards,
Krzysztof

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]

On Fri, Jun 18, 2021 at 05:05:30PM +0200, Krzysztof Kozlowski wrote:
> On 18/06/2021 17:00, Matthew Wilcox wrote:
> > On Fri, Jun 18, 2021 at 04:55:23PM +0200, Krzysztof Kozlowski wrote:
> >> These are randconfigs, so I don't think Linus will hit them when
> >> merging. Therefore assuming the reset-stubs are applied (and tree is in
> >> next), we should be fine, shouldn't we?
> > 
> > It's a bisection hazard.  Please fix it before the merge.  This is
> > exactly the kind of thing that linux-next is designed to detect.
> 
> Still hazard for a compile testing configuration, not a real bisection
> for troubleshooting bugs. You cannot hit the bug in any real case (so
> !COMPILE_TEST).

I think you could hit this in legit configurations where people want to
build ARM_SMMU but not TEGRA_MC. So it's either a dependency that we
need or the stubs. But I think you could squash the stub patch that I
sent into your tree if you can rebase that. The patch that the stub
should go into is this:

	393d66fd2cac ("memory: tegra: Implement SID override programming")

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]

On Fri, Jun 18, 2021 at 05:05:30PM +0200, Krzysztof Kozlowski wrote:
> On 18/06/2021 17:00, Matthew Wilcox wrote:
> > On Fri, Jun 18, 2021 at 04:55:23PM +0200, Krzysztof Kozlowski wrote:
> >> These are randconfigs, so I don't think Linus will hit them when
> >> merging. Therefore assuming the reset-stubs are applied (and tree is in
> >> next), we should be fine, shouldn't we?
> > 
> > It's a bisection hazard.  Please fix it before the merge.  This is
> > exactly the kind of thing that linux-next is designed to detect.
> 
> Still hazard for a compile testing configuration, not a real bisection
> for troubleshooting bugs. You cannot hit the bug in any real case (so
> !COMPILE_TEST).

I think you could hit this in legit configurations where people want to
build ARM_SMMU but not TEGRA_MC. So it's either a dependency that we
need or the stubs. But I think you could squash the stub patch that I
sent into your tree if you can rebase that. The patch that the stub
should go into is this:

	393d66fd2cac ("memory: tegra: Implement SID override programming")

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Krzysztof Kozlowski]

On 18/06/2021 17:11, Thierry Reding wrote:
> On Fri, Jun 18, 2021 at 05:05:30PM +0200, Krzysztof Kozlowski wrote:
>> On 18/06/2021 17:00, Matthew Wilcox wrote:
>>> On Fri, Jun 18, 2021 at 04:55:23PM +0200, Krzysztof Kozlowski wrote:
>>>> These are randconfigs, so I don't think Linus will hit them when
>>>> merging. Therefore assuming the reset-stubs are applied (and tree is in
>>>> next), we should be fine, shouldn't we?
>>>
>>> It's a bisection hazard.  Please fix it before the merge.  This is
>>> exactly the kind of thing that linux-next is designed to detect.
>>
>> Still hazard for a compile testing configuration, not a real bisection
>> for troubleshooting bugs. You cannot hit the bug in any real case (so
>> !COMPILE_TEST).
> 
> I think you could hit this in legit configurations where people want to
> build ARM_SMMU but not TEGRA_MC. So it's either a dependency that we
> need or the stubs. But I think you could squash the stub patch that I
> sent into your tree if you can rebase that. The patch that the stub
> should go into is this:
> 
> 	393d66fd2cac ("memory: tegra: Implement SID override programming")
> 

I think you refer here to the probe() stub, but I meant reset controller
stubs. These can happen only on COMPILE_TEST && !ARCH_TEGRA &&
!RESET_CONTROLLER.


Best regards,
Krzysztof

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Krzysztof Kozlowski]

[-- Attachment #1: Type: text/plain, Size: 1341 bytes --]

On 18/06/2021 17:11, Thierry Reding wrote:
> On Fri, Jun 18, 2021 at 05:05:30PM +0200, Krzysztof Kozlowski wrote:
>> On 18/06/2021 17:00, Matthew Wilcox wrote:
>>> On Fri, Jun 18, 2021 at 04:55:23PM +0200, Krzysztof Kozlowski wrote:
>>>> These are randconfigs, so I don't think Linus will hit them when
>>>> merging. Therefore assuming the reset-stubs are applied (and tree is in
>>>> next), we should be fine, shouldn't we?
>>>
>>> It's a bisection hazard.  Please fix it before the merge.  This is
>>> exactly the kind of thing that linux-next is designed to detect.
>>
>> Still hazard for a compile testing configuration, not a real bisection
>> for troubleshooting bugs. You cannot hit the bug in any real case (so
>> !COMPILE_TEST).
> 
> I think you could hit this in legit configurations where people want to
> build ARM_SMMU but not TEGRA_MC. So it's either a dependency that we
> need or the stubs. But I think you could squash the stub patch that I
> sent into your tree if you can rebase that. The patch that the stub
> should go into is this:
> 
> 	393d66fd2cac ("memory: tegra: Implement SID override programming")
> 

I think you refer here to the probe() stub, but I meant reset controller
stubs. These can happen only on COMPILE_TEST && !ARCH_TEGRA &&
!RESET_CONTROLLER.


Best regards,
Krzysztof

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Philipp Zabel]

Hi Thierry, Krzysztof,

On Fri, 2021-06-18 at 16:52 +0200, Thierry Reding wrote:
> On Fri, Jun 18, 2021 at 04:21:45PM +0200, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   e71e3a48a7e89fa71fb70bf4602367528864d2ff
> > commit: 56ebc9b0d77e0406aba2d900c82e79204cc7dc32 [5946/11253] memory: tegra: Enable compile testing for all drivers
> > config: x86_64-randconfig-a001-20210618 (attached as .config)
> > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # install x86_64 cross compiling tool for clang build
> >         # apt-get install binutils-x86-64-linux-gnu
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=56ebc9b0d77e0406aba2d900c82e79204cc7dc32
> >         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> >         git fetch --no-tags linux-next master
> >         git checkout 56ebc9b0d77e0406aba2d900c82e79204cc7dc32
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > Note: the linux-next/master HEAD e71e3a48a7e89fa71fb70bf4602367528864d2ff builds fine.
> >       It may have been fixed somewhere.
> > 
> > All errors (new ones prefixed by >>):
> > 
> > > > ld.lld: error: undefined symbol: reset_controller_register
> >    >>> referenced by mc.c
> >    >>>               memory/tegra/mc.o:(tegra_mc_probe) in archive drivers/built-in.a
> 
> Ugh... more fallout from that compile-test enablement. It looks like
> that compile-test stubs addition patch for reset hasn't found its way
> into linux-next yet.

It has [1], it's just merged later [2].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=48a74b1147f7db4623eaed591cc01eb740b871c0
[2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=25da503ecce8f523c1c1c678659cb484d3bcd73f

> Philipp, I wonder if it would make sense for Krzysztof to pick up that
> patch or, if you prefer, for Krzysztof to pull a stable branch from you
> that includes this so that the memory controller tree becomes buildable
> again?

That commit is stable. Feel free to pull it in below 56ebc9b0d77e:

https://lore.kernel.org/linux-arm-kernel/14d33ac19b2a107e97ce1ab264987b707baa9ba7.camel@pengutronix.de/

regards
Philipp

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Philipp Zabel]

[-- Attachment #1: Type: text/plain, Size: 2832 bytes --]

Hi Thierry, Krzysztof,

On Fri, 2021-06-18 at 16:52 +0200, Thierry Reding wrote:
> On Fri, Jun 18, 2021 at 04:21:45PM +0200, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   e71e3a48a7e89fa71fb70bf4602367528864d2ff
> > commit: 56ebc9b0d77e0406aba2d900c82e79204cc7dc32 [5946/11253] memory: tegra: Enable compile testing for all drivers
> > config: x86_64-randconfig-a001-20210618 (attached as .config)
> > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # install x86_64 cross compiling tool for clang build
> >         # apt-get install binutils-x86-64-linux-gnu
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=56ebc9b0d77e0406aba2d900c82e79204cc7dc32
> >         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> >         git fetch --no-tags linux-next master
> >         git checkout 56ebc9b0d77e0406aba2d900c82e79204cc7dc32
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > Note: the linux-next/master HEAD e71e3a48a7e89fa71fb70bf4602367528864d2ff builds fine.
> >       It may have been fixed somewhere.
> > 
> > All errors (new ones prefixed by >>):
> > 
> > > > ld.lld: error: undefined symbol: reset_controller_register
> >    >>> referenced by mc.c
> >    >>>               memory/tegra/mc.o:(tegra_mc_probe) in archive drivers/built-in.a
> 
> Ugh... more fallout from that compile-test enablement. It looks like
> that compile-test stubs addition patch for reset hasn't found its way
> into linux-next yet.

It has [1], it's just merged later [2].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=48a74b1147f7db4623eaed591cc01eb740b871c0
[2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=25da503ecce8f523c1c1c678659cb484d3bcd73f

> Philipp, I wonder if it would make sense for Krzysztof to pick up that
> patch or, if you prefer, for Krzysztof to pull a stable branch from you
> that includes this so that the memory controller tree becomes buildable
> again?

That commit is stable. Feel free to pull it in below 56ebc9b0d77e:

https://lore.kernel.org/linux-arm-kernel/14d33ac19b2a107e97ce1ab264987b707baa9ba7.camel(a)pengutronix.de/

regards
Philipp

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Philipp Zabel]

Hi Krzysztof, Olof,

On Fri, 2021-06-18 at 16:55 +0200, Krzysztof Kozlowski wrote:
> On 18/06/2021 16:52, Thierry Reding wrote:
> > On Fri, Jun 18, 2021 at 04:21:45PM +0200, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > > head:   e71e3a48a7e89fa71fb70bf4602367528864d2ff
> > > commit: 56ebc9b0d77e0406aba2d900c82e79204cc7dc32 [5946/11253] memory: tegra: Enable compile testing for all drivers
> > > config: x86_64-randconfig-a001-20210618 (attached as .config)
> > > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
> > > reproduce (this is a W=1 build):
> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # install x86_64 cross compiling tool for clang build
> > >         # apt-get install binutils-x86-64-linux-gnu
> > >         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=56ebc9b0d77e0406aba2d900c82e79204cc7dc32
> > >         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > >         git fetch --no-tags linux-next master
> > >         git checkout 56ebc9b0d77e0406aba2d900c82e79204cc7dc32
> > >         # save the attached .config to linux build tree
> > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
> > > 
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > 
> > > Note: the linux-next/master HEAD e71e3a48a7e89fa71fb70bf4602367528864d2ff builds fine.
> > >       It may have been fixed somewhere.
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > > > > ld.lld: error: undefined symbol: reset_controller_register
> > >    >>> referenced by mc.c
> > >    >>>               memory/tegra/mc.o:(tegra_mc_probe) in archive drivers/built-in.a
> > 
> > Ugh... more fallout from that compile-test enablement. It looks like
> > that compile-test stubs addition patch for reset hasn't found its way
> > into linux-next yet.
> 
> Does it mean reset tree is not in linux-next?

No, it is. It just has been merged into arm-soc/arm/drivers a day too
late:

  $ git log --pretty=oneline arm-soc/arm/drivers | head -n2
  25da503ecce8f523c1c1c678659cb484d3bcd73f Merge tag 'reset-for-v5.14-2' of git://git.pengutronix.de/pza/linux into arm/drivers
  1eb5f83ee936de6a69b2bcee95088a6e0ab7c202 Merge tag 'memory-controller-drv-tegra-5.14-2' of https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-mem-ctrl into arm/drivers

memory-controller-drv-tegra-5.14-2 contains the offending commit
56ebc9b0d77e, which depends on commit 48a74b1147f7 in reset-for-v5.14-2.

Is the arm-soc/arm/drivers branch still mutable? IIUC this could be
fixed by reordering the two merges.

regards
Philipp

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Philipp Zabel]

[-- Attachment #1: Type: text/plain, Size: 2990 bytes --]

Hi Krzysztof, Olof,

On Fri, 2021-06-18 at 16:55 +0200, Krzysztof Kozlowski wrote:
> On 18/06/2021 16:52, Thierry Reding wrote:
> > On Fri, Jun 18, 2021 at 04:21:45PM +0200, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > > head:   e71e3a48a7e89fa71fb70bf4602367528864d2ff
> > > commit: 56ebc9b0d77e0406aba2d900c82e79204cc7dc32 [5946/11253] memory: tegra: Enable compile testing for all drivers
> > > config: x86_64-randconfig-a001-20210618 (attached as .config)
> > > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
> > > reproduce (this is a W=1 build):
> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # install x86_64 cross compiling tool for clang build
> > >         # apt-get install binutils-x86-64-linux-gnu
> > >         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=56ebc9b0d77e0406aba2d900c82e79204cc7dc32
> > >         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > >         git fetch --no-tags linux-next master
> > >         git checkout 56ebc9b0d77e0406aba2d900c82e79204cc7dc32
> > >         # save the attached .config to linux build tree
> > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
> > > 
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > 
> > > Note: the linux-next/master HEAD e71e3a48a7e89fa71fb70bf4602367528864d2ff builds fine.
> > >       It may have been fixed somewhere.
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > > > > ld.lld: error: undefined symbol: reset_controller_register
> > >    >>> referenced by mc.c
> > >    >>>               memory/tegra/mc.o:(tegra_mc_probe) in archive drivers/built-in.a
> > 
> > Ugh... more fallout from that compile-test enablement. It looks like
> > that compile-test stubs addition patch for reset hasn't found its way
> > into linux-next yet.
> 
> Does it mean reset tree is not in linux-next?

No, it is. It just has been merged into arm-soc/arm/drivers a day too
late:

  $ git log --pretty=oneline arm-soc/arm/drivers | head -n2
  25da503ecce8f523c1c1c678659cb484d3bcd73f Merge tag 'reset-for-v5.14-2' of git://git.pengutronix.de/pza/linux into arm/drivers
  1eb5f83ee936de6a69b2bcee95088a6e0ab7c202 Merge tag 'memory-controller-drv-tegra-5.14-2' of https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-mem-ctrl into arm/drivers

memory-controller-drv-tegra-5.14-2 contains the offending commit
56ebc9b0d77e, which depends on commit 48a74b1147f7 in reset-for-v5.14-2.

Is the arm-soc/arm/drivers branch still mutable? IIUC this could be
fixed by reordering the two merges.

regards
Philipp

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Krzysztof Kozlowski]

On 18/06/2021 17:53, Philipp Zabel wrote:
> Hi Krzysztof, Olof,
> 
> On Fri, 2021-06-18 at 16:55 +0200, Krzysztof Kozlowski wrote:
>> On 18/06/2021 16:52, Thierry Reding wrote:
>>> On Fri, Jun 18, 2021 at 04:21:45PM +0200, kernel test robot wrote:
>>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>>>> head:   e71e3a48a7e89fa71fb70bf4602367528864d2ff
>>>> commit: 56ebc9b0d77e0406aba2d900c82e79204cc7dc32 [5946/11253] memory: tegra: Enable compile testing for all drivers
>>>> config: x86_64-randconfig-a001-20210618 (attached as .config)
>>>> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
>>>> reproduce (this is a W=1 build):
>>>>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>>>         chmod +x ~/bin/make.cross
>>>>         # install x86_64 cross compiling tool for clang build
>>>>         # apt-get install binutils-x86-64-linux-gnu
>>>>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=56ebc9b0d77e0406aba2d900c82e79204cc7dc32
>>>>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>>>>         git fetch --no-tags linux-next master
>>>>         git checkout 56ebc9b0d77e0406aba2d900c82e79204cc7dc32
>>>>         # save the attached .config to linux build tree
>>>>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
>>>>
>>>> If you fix the issue, kindly add following tag as appropriate
>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>>
>>>> Note: the linux-next/master HEAD e71e3a48a7e89fa71fb70bf4602367528864d2ff builds fine.
>>>>       It may have been fixed somewhere.
>>>>
>>>> All errors (new ones prefixed by >>):
>>>>
>>>>>> ld.lld: error: undefined symbol: reset_controller_register
>>>>    >>> referenced by mc.c
>>>>    >>>               memory/tegra/mc.o:(tegra_mc_probe) in archive drivers/built-in.a
>>>
>>> Ugh... more fallout from that compile-test enablement. It looks like
>>> that compile-test stubs addition patch for reset hasn't found its way
>>> into linux-next yet.
>>
>> Does it mean reset tree is not in linux-next?
> 
> No, it is. It just has been merged into arm-soc/arm/drivers a day too
> late:
> 
>   $ git log --pretty=oneline arm-soc/arm/drivers | head -n2
>   25da503ecce8f523c1c1c678659cb484d3bcd73f Merge tag 'reset-for-v5.14-2' of git://git.pengutronix.de/pza/linux into arm/drivers
>   1eb5f83ee936de6a69b2bcee95088a6e0ab7c202 Merge tag 'memory-controller-drv-tegra-5.14-2' of https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-mem-ctrl into arm/drivers
> 
> memory-controller-drv-tegra-5.14-2 contains the offending commit
> 56ebc9b0d77e, which depends on commit 48a74b1147f7 in reset-for-v5.14-2.
> 
> Is the arm-soc/arm/drivers branch still mutable? IIUC this could be
> fixed by reordering the two merges.

It won't change the bisectability, just the scope will be few commits
narrower.  The damage is unfortunately done.

Best regards,
Krzysztof

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Krzysztof Kozlowski]

[-- Attachment #1: Type: text/plain, Size: 3159 bytes --]

On 18/06/2021 17:53, Philipp Zabel wrote:
> Hi Krzysztof, Olof,
> 
> On Fri, 2021-06-18 at 16:55 +0200, Krzysztof Kozlowski wrote:
>> On 18/06/2021 16:52, Thierry Reding wrote:
>>> On Fri, Jun 18, 2021 at 04:21:45PM +0200, kernel test robot wrote:
>>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>>>> head:   e71e3a48a7e89fa71fb70bf4602367528864d2ff
>>>> commit: 56ebc9b0d77e0406aba2d900c82e79204cc7dc32 [5946/11253] memory: tegra: Enable compile testing for all drivers
>>>> config: x86_64-randconfig-a001-20210618 (attached as .config)
>>>> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
>>>> reproduce (this is a W=1 build):
>>>>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>>>         chmod +x ~/bin/make.cross
>>>>         # install x86_64 cross compiling tool for clang build
>>>>         # apt-get install binutils-x86-64-linux-gnu
>>>>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=56ebc9b0d77e0406aba2d900c82e79204cc7dc32
>>>>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>>>>         git fetch --no-tags linux-next master
>>>>         git checkout 56ebc9b0d77e0406aba2d900c82e79204cc7dc32
>>>>         # save the attached .config to linux build tree
>>>>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
>>>>
>>>> If you fix the issue, kindly add following tag as appropriate
>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>>
>>>> Note: the linux-next/master HEAD e71e3a48a7e89fa71fb70bf4602367528864d2ff builds fine.
>>>>       It may have been fixed somewhere.
>>>>
>>>> All errors (new ones prefixed by >>):
>>>>
>>>>>> ld.lld: error: undefined symbol: reset_controller_register
>>>>    >>> referenced by mc.c
>>>>    >>>               memory/tegra/mc.o:(tegra_mc_probe) in archive drivers/built-in.a
>>>
>>> Ugh... more fallout from that compile-test enablement. It looks like
>>> that compile-test stubs addition patch for reset hasn't found its way
>>> into linux-next yet.
>>
>> Does it mean reset tree is not in linux-next?
> 
> No, it is. It just has been merged into arm-soc/arm/drivers a day too
> late:
> 
>   $ git log --pretty=oneline arm-soc/arm/drivers | head -n2
>   25da503ecce8f523c1c1c678659cb484d3bcd73f Merge tag 'reset-for-v5.14-2' of git://git.pengutronix.de/pza/linux into arm/drivers
>   1eb5f83ee936de6a69b2bcee95088a6e0ab7c202 Merge tag 'memory-controller-drv-tegra-5.14-2' of https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-mem-ctrl into arm/drivers
> 
> memory-controller-drv-tegra-5.14-2 contains the offending commit
> 56ebc9b0d77e, which depends on commit 48a74b1147f7 in reset-for-v5.14-2.
> 
> Is the arm-soc/arm/drivers branch still mutable? IIUC this could be
> fixed by reordering the two merges.

It won't change the bisectability, just the scope will be few commits
narrower.  The damage is unfortunately done.

Best regards,
Krzysztof

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Philipp Zabel]

On Mon, 2021-06-21 at 11:27 +0200, Krzysztof Kozlowski wrote:
[...]
> It won't change the bisectability, just the scope will be few commits
> narrower.  The damage is unfortunately done.

Oh right, so the only way to fix this would have been to rebase your
branch on top of mine before the pull request.

I'll try to be more careful about spotting and pointing out such
dependencies when picking patches out of series. If I still miss them
and pick up a patch that you think should be merged together with the
rest of the series, don't hesitate to ask me to drop it from my tree.
More often than not, I have no conflicting patches pending.

regards
Philipp

Re: [linux-next:master 5946/11253] ld.lld: error: undefined symbol: reset_controller_register

[Philipp Zabel]

[-- Attachment #1: Type: text/plain, Size: 673 bytes --]

On Mon, 2021-06-21 at 11:27 +0200, Krzysztof Kozlowski wrote:
[...]
> It won't change the bisectability, just the scope will be few commits
> narrower.  The damage is unfortunately done.

Oh right, so the only way to fix this would have been to rebase your
branch on top of mine before the pull request.

I'll try to be more careful about spotting and pointing out such
dependencies when picking patches out of series. If I still miss them
and pick up a patch that you think should be merged together with the
rest of the series, don't hesitate to ask me to drop it from my tree.
More often than not, I have no conflicting patches pending.

regards
Philipp