From: Suman Anna <s-anna@ti.com>
To: Sarangdhar Joshi <spjoshi@codeaurora.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Tony Lindgren <tony@atomide.com>Santosh Shilimkar
<ssantosh@kernel.org>
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
Stephen Boyd <sboyd@codeaurora.org>,
Trilok Soni <tsoni@codeaurora.org>,
Dave Gerlach <d-gerlach@ti.com>
Subject: Re: [PATCH v2] soc: ti: Drop wait from wkup_m3_rproc_boot_thread
Date: Thu, 5 Jan 2017 15:08:28 -0600 [thread overview]
Message-ID: <482666d0-7915-ead2-c514-2651a4967a43@ti.com> (raw)
In-Reply-To: <1483486889-3662-1-git-send-email-spjoshi@codeaurora.org>
On 01/03/2017 05:41 PM, Sarangdhar Joshi wrote:
> The function wkup_m3_rproc_boot_thread waits for
> asynchronous firmware loading to parse the resource table
> before calling rproc_boot(). However, as the resource table
> parsing has been moved to rproc_boot(), there's no need to
> wait for the asynchronous firmware loading completion.
> So, drop this.
>
> CC: Dave Gerlach <d-gerlach@ti.com>
> CC: Suman Anna <s-anna@ti.com>
> CC: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
+ Tony and Santosh, not sure who is picking up the wkup_m3 related patches.
Only one minor nit, I would prefer the patch subject to start with
soc: ti: wkup_m3_ipc: ....
Tested-by: Suman Anna <s-anna@ti.com>
regards
Suman
> ---
>
> This patch seems to be doing an independent clean up now. Hence
> removing it from the series.
>
> drivers/soc/ti/wkup_m3_ipc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 8823cc8..8bfa44b 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -370,8 +370,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
> struct device *dev = m3_ipc->dev;
> int ret;
>
> - wait_for_completion(&m3_ipc->rproc->firmware_loading_complete);
> -
> init_completion(&m3_ipc->sync_complete);
>
> ret = rproc_boot(m3_ipc->rproc);
>
WARNING: multiple messages have this Message-ID (diff)
From: Suman Anna <s-anna@ti.com>
To: Sarangdhar Joshi <spjoshi@codeaurora.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Tony Lindgren <tony@atomide.com>Santosh Shilimkar
<ssantosh@kernel.org>
Cc: Trilok Soni <tsoni@codeaurora.org>,
Dave Gerlach <d-gerlach@ti.com>,
linux-arm-msm@vger.kernel.org,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] soc: ti: Drop wait from wkup_m3_rproc_boot_thread
Date: Thu, 5 Jan 2017 15:08:28 -0600 [thread overview]
Message-ID: <482666d0-7915-ead2-c514-2651a4967a43@ti.com> (raw)
In-Reply-To: <1483486889-3662-1-git-send-email-spjoshi@codeaurora.org>
On 01/03/2017 05:41 PM, Sarangdhar Joshi wrote:
> The function wkup_m3_rproc_boot_thread waits for
> asynchronous firmware loading to parse the resource table
> before calling rproc_boot(). However, as the resource table
> parsing has been moved to rproc_boot(), there's no need to
> wait for the asynchronous firmware loading completion.
> So, drop this.
>
> CC: Dave Gerlach <d-gerlach@ti.com>
> CC: Suman Anna <s-anna@ti.com>
> CC: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
+ Tony and Santosh, not sure who is picking up the wkup_m3 related patches.
Only one minor nit, I would prefer the patch subject to start with
soc: ti: wkup_m3_ipc: ....
Tested-by: Suman Anna <s-anna@ti.com>
regards
Suman
> ---
>
> This patch seems to be doing an independent clean up now. Hence
> removing it from the series.
>
> drivers/soc/ti/wkup_m3_ipc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 8823cc8..8bfa44b 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -370,8 +370,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
> struct device *dev = m3_ipc->dev;
> int ret;
>
> - wait_for_completion(&m3_ipc->rproc->firmware_loading_complete);
> -
> init_completion(&m3_ipc->sync_complete);
>
> ret = rproc_boot(m3_ipc->rproc);
>
WARNING: multiple messages have this Message-ID (diff)
From: Suman Anna <s-anna@ti.com>
To: Sarangdhar Joshi <spjoshi@codeaurora.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Santosh Shilimkar <ssantosh@kernel.org>
Cc: <linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Trilok Soni <tsoni@codeaurora.org>,
Dave Gerlach <d-gerlach@ti.com>
Subject: Re: [PATCH v2] soc: ti: Drop wait from wkup_m3_rproc_boot_thread
Date: Thu, 5 Jan 2017 15:08:28 -0600 [thread overview]
Message-ID: <482666d0-7915-ead2-c514-2651a4967a43@ti.com> (raw)
In-Reply-To: <1483486889-3662-1-git-send-email-spjoshi@codeaurora.org>
On 01/03/2017 05:41 PM, Sarangdhar Joshi wrote:
> The function wkup_m3_rproc_boot_thread waits for
> asynchronous firmware loading to parse the resource table
> before calling rproc_boot(). However, as the resource table
> parsing has been moved to rproc_boot(), there's no need to
> wait for the asynchronous firmware loading completion.
> So, drop this.
>
> CC: Dave Gerlach <d-gerlach@ti.com>
> CC: Suman Anna <s-anna@ti.com>
> CC: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
+ Tony and Santosh, not sure who is picking up the wkup_m3 related patches.
Only one minor nit, I would prefer the patch subject to start with
soc: ti: wkup_m3_ipc: ....
Tested-by: Suman Anna <s-anna@ti.com>
regards
Suman
> ---
>
> This patch seems to be doing an independent clean up now. Hence
> removing it from the series.
>
> drivers/soc/ti/wkup_m3_ipc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 8823cc8..8bfa44b 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -370,8 +370,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
> struct device *dev = m3_ipc->dev;
> int ret;
>
> - wait_for_completion(&m3_ipc->rproc->firmware_loading_complete);
> -
> init_completion(&m3_ipc->sync_complete);
>
> ret = rproc_boot(m3_ipc->rproc);
>
WARNING: multiple messages have this Message-ID (diff)
From: s-anna@ti.com (Suman Anna)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] soc: ti: Drop wait from wkup_m3_rproc_boot_thread
Date: Thu, 5 Jan 2017 15:08:28 -0600 [thread overview]
Message-ID: <482666d0-7915-ead2-c514-2651a4967a43@ti.com> (raw)
In-Reply-To: <1483486889-3662-1-git-send-email-spjoshi@codeaurora.org>
On 01/03/2017 05:41 PM, Sarangdhar Joshi wrote:
> The function wkup_m3_rproc_boot_thread waits for
> asynchronous firmware loading to parse the resource table
> before calling rproc_boot(). However, as the resource table
> parsing has been moved to rproc_boot(), there's no need to
> wait for the asynchronous firmware loading completion.
> So, drop this.
>
> CC: Dave Gerlach <d-gerlach@ti.com>
> CC: Suman Anna <s-anna@ti.com>
> CC: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
+ Tony and Santosh, not sure who is picking up the wkup_m3 related patches.
Only one minor nit, I would prefer the patch subject to start with
soc: ti: wkup_m3_ipc: ....
Tested-by: Suman Anna <s-anna@ti.com>
regards
Suman
> ---
>
> This patch seems to be doing an independent clean up now. Hence
> removing it from the series.
>
> drivers/soc/ti/wkup_m3_ipc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 8823cc8..8bfa44b 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -370,8 +370,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
> struct device *dev = m3_ipc->dev;
> int ret;
>
> - wait_for_completion(&m3_ipc->rproc->firmware_loading_complete);
> -
> init_completion(&m3_ipc->sync_complete);
>
> ret = rproc_boot(m3_ipc->rproc);
>
next prev parent reply other threads:[~2017-01-05 21:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 23:41 [PATCH v2] soc: ti: Drop wait from wkup_m3_rproc_boot_thread Sarangdhar Joshi
2017-01-03 23:41 ` Sarangdhar Joshi
2017-01-03 23:41 ` Sarangdhar Joshi
2017-01-05 21:08 ` Suman Anna [this message]
2017-01-05 21:08 ` Suman Anna
2017-01-05 21:08 ` Suman Anna
2017-01-05 21:08 ` Suman Anna
2017-01-05 21:17 ` Santosh Shilimkar
2017-01-05 21:17 ` Santosh Shilimkar
2017-01-05 21:17 ` Santosh Shilimkar
2017-01-05 22:03 ` Tony Lindgren
2017-01-05 22:03 ` Tony Lindgren
2017-01-05 22:03 ` Tony Lindgren
2017-01-05 21:58 ` Sarangdhar Joshi
2017-01-05 21:58 ` Sarangdhar Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482666d0-7915-ead2-c514-2651a4967a43@ti.com \
--to=s-anna@ti.com \
--cc=bjorn.andersson@linaro.org \
--cc=d-gerlach@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=sboyd@codeaurora.org \
--cc=spjoshi@codeaurora.org \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.