* [PATCH] virtio_balloon: Fix build error seen with CONFIG_BALLOON_COMPACTION=n
@ 2020-02-20 2:31 Guenter Roeck
2020-02-20 9:09 ` David Hildenbrand
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2020-02-20 2:31 UTC (permalink / raw)
To: Michael S . Tsirkin
Cc: Jason Wang, virtualization, linux-kernel, Guenter Roeck,
David Hildenbrand
0day reports:
drivers//virtio/virtio_balloon.c: In function 'virtballoon_probe':
drivers//virtio/virtio_balloon.c:960:1: error:
label 'out_del_vqs' defined but not used [-Werror=unused-label]
This is seen with CONFIG_BALLOON_COMPACTION=n.
Reported-by: kbuild test robot <lkp@intel.com>
Fixes: 1ad6f58ea936 ("virtio_balloon: Fix memory leaks on errors in virtballoon_probe()")
Cc: David Hildenbrand <david@redhat.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/virtio/virtio_balloon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index 7bfe365d9372..341458fd95ca 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -959,8 +959,8 @@ static int virtballoon_probe(struct virtio_device *vdev)
iput(vb->vb_dev_info.inode);
out_kern_unmount:
kern_unmount(balloon_mnt);
-#endif
out_del_vqs:
+#endif
vdev->config->del_vqs(vdev);
out_free_vb:
kfree(vb);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] virtio_balloon: Fix build error seen with CONFIG_BALLOON_COMPACTION=n
2020-02-20 2:31 [PATCH] virtio_balloon: Fix build error seen with CONFIG_BALLOON_COMPACTION=n Guenter Roeck
@ 2020-02-20 9:09 ` David Hildenbrand
0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2020-02-20 9:09 UTC (permalink / raw)
To: Guenter Roeck
Cc: Michael S . Tsirkin, Jason Wang, virtualization, linux-kernel,
David Hildenbrand
> Am 20.02.2020 um 03:32 schrieb Guenter Roeck <linux@roeck-us.net>:
>
> 0day reports:
>
> drivers//virtio/virtio_balloon.c: In function 'virtballoon_probe':
> drivers//virtio/virtio_balloon.c:960:1: error:
> label 'out_del_vqs' defined but not used [-Werror=unused-label]
>
> This is seen with CONFIG_BALLOON_COMPACTION=n.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Fixes: 1ad6f58ea936 ("virtio_balloon: Fix memory leaks on errors in virtballoon_probe()")
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
There is already a patch on the list to fix that (and it looks exactly like this one :) ). Unfortunately, not picked up yet.
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-20 9:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-20 2:31 [PATCH] virtio_balloon: Fix build error seen with CONFIG_BALLOON_COMPACTION=n Guenter Roeck
2020-02-20 9:09 ` David Hildenbrand
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.