* [PATCH] nfsdcltrack: silence some expected errors
@ 2017-04-24 16:41 Jeff Layton
2017-04-26 16:15 ` Steve Dickson
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Layton @ 2017-04-24 16:41 UTC (permalink / raw)
To: steved; +Cc: linux-nfs, bfields, chunwang
On a new install, we're unable to select from the parameters table, as
it doesn't exist yet. The code is set up to log that fact at L_ERROR
now, but it's an expected situation. Change it to log that at D_GENERAL
instead.
Reported-and-Tested-by: ChunYu Wang <chunwang@redhat.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
utils/nfsdcltrack/sqlite.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/utils/nfsdcltrack/sqlite.c b/utils/nfsdcltrack/sqlite.c
index 54cd7487920b..1552eba4e35c 100644
--- a/utils/nfsdcltrack/sqlite.c
+++ b/utils/nfsdcltrack/sqlite.c
@@ -101,7 +101,7 @@ sqlite_query_schema_version(void)
"SELECT value FROM parameters WHERE key == \"version\";",
-1, &stmt, NULL);
if (ret != SQLITE_OK) {
- xlog(L_ERROR, "Unable to prepare select statement: %s",
+ xlog(D_GENERAL, "Unable to prepare select statement: %s",
sqlite3_errmsg(dbh));
ret = 0;
goto out;
@@ -110,7 +110,7 @@ sqlite_query_schema_version(void)
/* query schema version */
ret = sqlite3_step(stmt);
if (ret != SQLITE_ROW) {
- xlog(L_ERROR, "Select statement execution failed: %s",
+ xlog(D_GENERAL, "Select statement execution failed: %s",
sqlite3_errmsg(dbh));
ret = 0;
goto out;
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nfsdcltrack: silence some expected errors
2017-04-24 16:41 [PATCH] nfsdcltrack: silence some expected errors Jeff Layton
@ 2017-04-26 16:15 ` Steve Dickson
0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2017-04-26 16:15 UTC (permalink / raw)
To: Jeff Layton; +Cc: linux-nfs, bfields, chunwang
On 04/24/2017 12:41 PM, Jeff Layton wrote:
> On a new install, we're unable to select from the parameters table, as
> it doesn't exist yet. The code is set up to log that fact at L_ERROR
> now, but it's an expected situation. Change it to log that at D_GENERAL
> instead.
>
> Reported-and-Tested-by: ChunYu Wang <chunwang@redhat.com>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
Committed...
steved.
> ---
> utils/nfsdcltrack/sqlite.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/utils/nfsdcltrack/sqlite.c b/utils/nfsdcltrack/sqlite.c
> index 54cd7487920b..1552eba4e35c 100644
> --- a/utils/nfsdcltrack/sqlite.c
> +++ b/utils/nfsdcltrack/sqlite.c
> @@ -101,7 +101,7 @@ sqlite_query_schema_version(void)
> "SELECT value FROM parameters WHERE key == \"version\";",
> -1, &stmt, NULL);
> if (ret != SQLITE_OK) {
> - xlog(L_ERROR, "Unable to prepare select statement: %s",
> + xlog(D_GENERAL, "Unable to prepare select statement: %s",
> sqlite3_errmsg(dbh));
> ret = 0;
> goto out;
> @@ -110,7 +110,7 @@ sqlite_query_schema_version(void)
> /* query schema version */
> ret = sqlite3_step(stmt);
> if (ret != SQLITE_ROW) {
> - xlog(L_ERROR, "Select statement execution failed: %s",
> + xlog(D_GENERAL, "Select statement execution failed: %s",
> sqlite3_errmsg(dbh));
> ret = 0;
> goto out;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-26 16:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-24 16:41 [PATCH] nfsdcltrack: silence some expected errors Jeff Layton
2017-04-26 16:15 ` Steve Dickson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.