From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Greg Kurz <groug@kaod.org>
Subject: Re: [PATCH 4/6] 9pfs: refactor 'name_idx' -> 'nvalid' in v9fs_walk()
Date: Thu, 10 Mar 2022 10:07:04 +0100 [thread overview]
Message-ID: <4831323.ZipVpMZSPQ@silver> (raw)
In-Reply-To: <00bee0f7a89147c90c672f07b9a1ebcd9180215b.1646850707.git.qemu_oss@crudebyte.com>
On Mittwoch, 9. März 2022 18:12:17 CET Christian Schoenebeck wrote:
> The local variable 'name_idx' is used in two loops in function v9fs_walk().
> Let the first loop use its own variable 'nvalid' instead, which we will use
> in subsequent patches as the number of (requested) path components
> successfully retrieved/walked by background I/O thread.
>
> Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> ---
> hw/9pfs/9p.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> index a6d6b3f835..6cdc566866 100644
> --- a/hw/9pfs/9p.c
> +++ b/hw/9pfs/9p.c
> @@ -1764,7 +1764,7 @@ static bool same_stat_id(const struct stat *a, const
> struct stat *b)
>
> static void coroutine_fn v9fs_walk(void *opaque)
> {
> - int name_idx;
> + int name_idx, nvalid;
Or rather renaming this nvalid -> nfetched?
> g_autofree V9fsQID *qids = NULL;
> int i, err = 0;
> V9fsPath dpath, path;
> @@ -1842,17 +1842,17 @@ static void coroutine_fn v9fs_walk(void *opaque)
> break;
> }
> stbuf = fidst;
> - for (name_idx = 0; name_idx < nwnames; name_idx++) {
> + for (nvalid = 0; nvalid < nwnames; nvalid++) {
> if (v9fs_request_cancelled(pdu)) {
> err = -EINTR;
> break;
> }
> if (!same_stat_id(&pdu->s->root_st, &stbuf) ||
> - strcmp("..", wnames[name_idx].data))
> + strcmp("..", wnames[nvalid].data))
> {
> err = s->ops->name_to_path(&s->ctx, &dpath,
> - wnames[name_idx].data,
> - &pathes[name_idx]);
> + wnames[nvalid].data,
> + &pathes[nvalid]);
> if (err < 0) {
> err = -errno;
> break;
> @@ -1861,13 +1861,13 @@ static void coroutine_fn v9fs_walk(void *opaque)
> err = -EINTR;
> break;
> }
> - err = s->ops->lstat(&s->ctx, &pathes[name_idx], &stbuf);
> + err = s->ops->lstat(&s->ctx, &pathes[nvalid], &stbuf);
> if (err < 0) {
> err = -errno;
> break;
> }
> - stbufs[name_idx] = stbuf;
> - v9fs_path_copy(&dpath, &pathes[name_idx]);
> + stbufs[nvalid] = stbuf;
> + v9fs_path_copy(&dpath, &pathes[nvalid]);
> }
> }
> });
next prev parent reply other threads:[~2022-03-10 9:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 18:31 [PATCH 0/6] 9pfs: fix 'Twalk' protocol violation Christian Schoenebeck
2022-03-09 12:18 ` [PATCH 1/6] tests/9pfs: walk to non-existent dir Christian Schoenebeck
2022-03-11 11:25 ` Greg Kurz
2022-03-09 13:24 ` [PATCH 2/6] tests/9pfs: Twalk with nwname=0 Christian Schoenebeck
2022-03-10 8:57 ` Christian Schoenebeck
2022-03-11 11:41 ` Greg Kurz
2022-03-11 13:33 ` Christian Schoenebeck
2022-03-09 14:49 ` [PATCH 3/6] tests/9pfs: compare QIDs in fs_walk_none() test Christian Schoenebeck
2022-03-10 9:04 ` Christian Schoenebeck
2022-03-11 16:11 ` Greg Kurz
2022-03-11 16:39 ` Christian Schoenebeck
2022-03-11 17:02 ` Greg Kurz
2022-03-11 17:23 ` Christian Schoenebeck
2022-03-09 17:12 ` [PATCH 4/6] 9pfs: refactor 'name_idx' -> 'nvalid' in v9fs_walk() Christian Schoenebeck
2022-03-10 9:07 ` Christian Schoenebeck [this message]
2022-03-11 16:16 ` Greg Kurz
2022-03-09 17:57 ` [PATCH 5/6] 9pfs: fix 'Twalk' to only send error if no component walked Christian Schoenebeck
2022-03-10 9:13 ` Christian Schoenebeck
2022-03-11 16:35 ` Greg Kurz
2022-03-11 16:44 ` Christian Schoenebeck
2022-03-11 17:08 ` Greg Kurz
2022-03-11 17:36 ` Christian Schoenebeck
2022-03-09 18:21 ` [PATCH 6/6] tests/9pfs: guard recent 'Twalk' behaviour fix Christian Schoenebeck
2022-03-11 10:32 ` Christian Schoenebeck
2022-03-11 16:40 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4831323.ZipVpMZSPQ@silver \
--to=qemu_oss@crudebyte.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.