All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Greg Kurz <groug@kaod.org>
Subject: [PATCH 1/6] tests/9pfs: walk to non-existent dir
Date: Wed, 9 Mar 2022 13:18:50 +0100	[thread overview]
Message-ID: <62e8103d249fcdb03ad6c706840579a075333398.1646850707.git.qemu_oss@crudebyte.com> (raw)
In-Reply-To: <cover.1646850707.git.qemu_oss@crudebyte.com>

Expect ENOENT Rlerror response when trying to walk to a
non-existent directory.

Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
---
 tests/qtest/virtio-9p-test.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c
index 01ca076afe..22bdd74bc1 100644
--- a/tests/qtest/virtio-9p-test.c
+++ b/tests/qtest/virtio-9p-test.c
@@ -606,6 +606,25 @@ static uint32_t do_walk(QVirtio9P *v9p, const char *path)
     return fid;
 }
 
+/* utility function: walk to requested dir and expect passed error response */
+static void do_walk_expect_error(QVirtio9P *v9p, const char *path, uint32_t err)
+{
+    char **wnames;
+    P9Req *req;
+    uint32_t _err;
+    const uint32_t fid = genfid();
+
+    int nwnames = split(path, "/", &wnames);
+
+    req = v9fs_twalk(v9p, 0, fid, nwnames, wnames, 0);
+    v9fs_req_wait_for_reply(req, NULL);
+    v9fs_rlerror(req, &_err);
+
+    g_assert_cmpint(_err, ==, err);
+
+    split_free(&wnames);
+}
+
 static void fs_version(void *obj, void *data, QGuestAllocator *t_alloc)
 {
     alloc = t_alloc;
@@ -974,6 +993,15 @@ static void fs_walk_no_slash(void *obj, void *data, QGuestAllocator *t_alloc)
     g_free(wnames[0]);
 }
 
+static void fs_walk_nonexistent(void *obj, void *data, QGuestAllocator *t_alloc)
+{
+    QVirtio9P *v9p = obj;
+    alloc = t_alloc;
+
+    do_attach(v9p);
+    do_walk_expect_error(v9p, "non-existent", ENOENT);
+}
+
 static void fs_walk_dotdot(void *obj, void *data, QGuestAllocator *t_alloc)
 {
     QVirtio9P *v9p = obj;
@@ -1409,6 +1437,8 @@ static void register_virtio_9p_test(void)
                   &opts);
     qos_add_test("synth/walk/dotdot_from_root", "virtio-9p",
                  fs_walk_dotdot,  &opts);
+    qos_add_test("synth/walk/non_existent", "virtio-9p", fs_walk_nonexistent,
+                  &opts);
     qos_add_test("synth/lopen/basic", "virtio-9p", fs_lopen,  &opts);
     qos_add_test("synth/write/basic", "virtio-9p", fs_write,  &opts);
     qos_add_test("synth/flush/success", "virtio-9p", fs_flush_success,
-- 
2.30.2



  reply	other threads:[~2022-03-09 19:13 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-09 18:31 [PATCH 0/6] 9pfs: fix 'Twalk' protocol violation Christian Schoenebeck
2022-03-09 12:18 ` Christian Schoenebeck [this message]
2022-03-11 11:25   ` [PATCH 1/6] tests/9pfs: walk to non-existent dir Greg Kurz
2022-03-09 13:24 ` [PATCH 2/6] tests/9pfs: Twalk with nwname=0 Christian Schoenebeck
2022-03-10  8:57   ` Christian Schoenebeck
2022-03-11 11:41     ` Greg Kurz
2022-03-11 13:33       ` Christian Schoenebeck
2022-03-09 14:49 ` [PATCH 3/6] tests/9pfs: compare QIDs in fs_walk_none() test Christian Schoenebeck
2022-03-10  9:04   ` Christian Schoenebeck
2022-03-11 16:11     ` Greg Kurz
2022-03-11 16:39       ` Christian Schoenebeck
2022-03-11 17:02         ` Greg Kurz
2022-03-11 17:23           ` Christian Schoenebeck
2022-03-09 17:12 ` [PATCH 4/6] 9pfs: refactor 'name_idx' -> 'nvalid' in v9fs_walk() Christian Schoenebeck
2022-03-10  9:07   ` Christian Schoenebeck
2022-03-11 16:16     ` Greg Kurz
2022-03-09 17:57 ` [PATCH 5/6] 9pfs: fix 'Twalk' to only send error if no component walked Christian Schoenebeck
2022-03-10  9:13   ` Christian Schoenebeck
2022-03-11 16:35     ` Greg Kurz
2022-03-11 16:44       ` Christian Schoenebeck
2022-03-11 17:08         ` Greg Kurz
2022-03-11 17:36           ` Christian Schoenebeck
2022-03-09 18:21 ` [PATCH 6/6] tests/9pfs: guard recent 'Twalk' behaviour fix Christian Schoenebeck
2022-03-11 10:32   ` Christian Schoenebeck
2022-03-11 16:40   ` Greg Kurz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62e8103d249fcdb03ad6c706840579a075333398.1646850707.git.qemu_oss@crudebyte.com \
    --to=qemu_oss@crudebyte.com \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.