All of lore.kernel.org
 help / color / mirror / Atom feed
* vsock fix for 5.4 stable
@ 2020-09-29 20:53 Vishnu Rangayyan
  2020-09-30  6:26 ` gregkh
  0 siblings, 1 reply; 2+ messages in thread
From: Vishnu Rangayyan @ 2020-09-29 20:53 UTC (permalink / raw)
  To: stable; +Cc: gregkh, Andrew Forgue

Hi,

Can we have this backport applied to 5.4 stable, its more of a required 
fix than an enhancement.

commit df12eb6d6cd920ab2f0e0a43cd6e1c23a05cea91 upstream

The call has a minor api change in 5.4 vs higher, only the pkt arg is 
required.

diff --git a/net/vmw_vsock/virtio_transport_common.c 
b/net/vmw_vsock/virtio_transport_common.c
index d9f0c9c5425a..2f696124bab6 100644
--- a/net/vmw_vsock/virtio_transport_common.c
+++ b/net/vmw_vsock/virtio_transport_common.c
@@ -1153,6 +1153,7 @@ void virtio_transport_recv_pkt(struct 
virtio_transport *t,
  		virtio_transport_free_pkt(pkt);
  		break;
  	default:
+		(void)virtio_transport_reset_no_sock(pkt);
  		virtio_transport_free_pkt(pkt);
  		break;
  	}
-- 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: vsock fix for 5.4 stable
  2020-09-29 20:53 vsock fix for 5.4 stable Vishnu Rangayyan
@ 2020-09-30  6:26 ` gregkh
  0 siblings, 0 replies; 2+ messages in thread
From: gregkh @ 2020-09-30  6:26 UTC (permalink / raw)
  To: Vishnu Rangayyan; +Cc: stable, Andrew Forgue

On Tue, Sep 29, 2020 at 01:53:58PM -0700, Vishnu Rangayyan wrote:
> Hi,
> 
> Can we have this backport applied to 5.4 stable, its more of a required fix
> than an enhancement.
> 
> commit df12eb6d6cd920ab2f0e0a43cd6e1c23a05cea91 upstream
> 
> The call has a minor api change in 5.4 vs higher, only the pkt arg is
> required.
> 
> diff --git a/net/vmw_vsock/virtio_transport_common.c
> b/net/vmw_vsock/virtio_transport_common.c
> index d9f0c9c5425a..2f696124bab6 100644
> --- a/net/vmw_vsock/virtio_transport_common.c
> +++ b/net/vmw_vsock/virtio_transport_common.c
> @@ -1153,6 +1153,7 @@ void virtio_transport_recv_pkt(struct virtio_transport
> *t,
>  		virtio_transport_free_pkt(pkt);
>  		break;
>  	default:
> +		(void)virtio_transport_reset_no_sock(pkt);
>  		virtio_transport_free_pkt(pkt);
>  		break;
>  	}
> -- 

Please cc: netdev and the developers who wrote/reviewed a patch when
asking for it to be submitted to stable, so that they can comment on it.

Can you resend it and do that?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-30  6:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-29 20:53 vsock fix for 5.4 stable Vishnu Rangayyan
2020-09-30  6:26 ` gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.