* [PATCH] omapfb: panel-tpo-td043mtea1: constify attribute_group structures.
@ 2017-07-19 5:35 ` Arvind Yadav
0 siblings, 0 replies; 4+ messages in thread
From: Arvind Yadav @ 2017-07-19 5:23 UTC (permalink / raw)
To: tomi.valkeinen, b.zolnierkie; +Cc: linux-omap, linux-fbdev, linux-kernel
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
2673 368 0 3041 be1 panel-tpo-td043mtea1.o
File size After adding 'const':
text data bss dec hex filename
2737 304 0 3041 be1 panel-tpo-td043mtea1.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
index 51e628b..ea8c79a 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
@@ -282,7 +282,7 @@ static DEVICE_ATTR(gamma, S_IRUGO | S_IWUSR,
NULL,
};
-static struct attribute_group tpo_td043_attr_group = {
+static const struct attribute_group tpo_td043_attr_group = {
.attrs = tpo_td043_attrs,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] omapfb: panel-tpo-td043mtea1: constify attribute_group structures.
@ 2017-07-19 5:35 ` Arvind Yadav
0 siblings, 0 replies; 4+ messages in thread
From: Arvind Yadav @ 2017-07-19 5:35 UTC (permalink / raw)
To: tomi.valkeinen, b.zolnierkie; +Cc: linux-omap, linux-fbdev, linux-kernel
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
2673 368 0 3041 be1 panel-tpo-td043mtea1.o
File size After adding 'const':
text data bss dec hex filename
2737 304 0 3041 be1 panel-tpo-td043mtea1.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
index 51e628b..ea8c79a 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
@@ -282,7 +282,7 @@ static DEVICE_ATTR(gamma, S_IRUGO | S_IWUSR,
NULL,
};
-static struct attribute_group tpo_td043_attr_group = {
+static const struct attribute_group tpo_td043_attr_group = {
.attrs = tpo_td043_attrs,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] omapfb: panel-tpo-td043mtea1: constify attribute_group structures.
2017-07-19 5:35 ` Arvind Yadav
@ 2017-08-01 14:06 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-08-01 14:06 UTC (permalink / raw)
To: Arvind Yadav; +Cc: tomi.valkeinen, linux-omap, linux-fbdev, linux-kernel
On Wednesday, July 19, 2017 10:53:11 AM Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 2673 368 0 3041 be1 panel-tpo-td043mtea1.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 2737 304 0 3041 be1 panel-tpo-td043mtea1.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Patch queued for 4.14, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] omapfb: panel-tpo-td043mtea1: constify attribute_group structures.
@ 2017-08-01 14:06 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-08-01 14:06 UTC (permalink / raw)
To: Arvind Yadav; +Cc: tomi.valkeinen, linux-omap, linux-fbdev, linux-kernel
On Wednesday, July 19, 2017 10:53:11 AM Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 2673 368 0 3041 be1 panel-tpo-td043mtea1.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 2737 304 0 3041 be1 panel-tpo-td043mtea1.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Patch queued for 4.14, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-01 14:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170719052351epcas4p20dce52e9c9754e094195d57458529ecb@epcas4p2.samsung.com>
2017-07-19 5:23 ` [PATCH] omapfb: panel-tpo-td043mtea1: constify attribute_group structures Arvind Yadav
2017-07-19 5:35 ` Arvind Yadav
2017-08-01 14:06 ` Bartlomiej Zolnierkiewicz
2017-08-01 14:06 ` Bartlomiej Zolnierkiewicz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.