* [PATCH v2 net-next] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define
@ 2023-12-06 16:01 Sean Nyekjaer
2023-12-06 16:07 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sean Nyekjaer @ 2023-12-06 16:01 UTC (permalink / raw)
To: Woojung Huh, UNGLinuxDriver, Andrew Lunn, Florian Fainelli,
Vladimir Oltean, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: Sean Nyekjaer, netdev, linux-kernel
Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
DSA_TAG_PROTO_LAN937X to improve readability.
Signed-off-by: Sean Nyekjaer <sean@geanix.com>
---
Changes since v1:
- removed Fixes tag
drivers/net/dsa/microchip/ksz_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
index 286e20f340e5..5c2214784ed0 100644
--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -2614,7 +2614,7 @@ static enum dsa_tag_protocol ksz_get_tag_protocol(struct dsa_switch *ds,
proto = DSA_TAG_PROTO_KSZ9477;
if (is_lan937x(dev))
- proto = DSA_TAG_PROTO_LAN937X_VALUE;
+ proto = DSA_TAG_PROTO_LAN937X;
return proto;
}
--
2.42.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 net-next] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define
2023-12-06 16:01 [PATCH v2 net-next] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define Sean Nyekjaer
@ 2023-12-06 16:07 ` Andrew Lunn
2023-12-07 4:11 ` Arun.Ramadoss
2023-12-08 19:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2023-12-06 16:07 UTC (permalink / raw)
To: Sean Nyekjaer
Cc: Woojung Huh, UNGLinuxDriver, Florian Fainelli, Vladimir Oltean,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev, linux-kernel
On Wed, Dec 06, 2023 at 05:01:23PM +0100, Sean Nyekjaer wrote:
> Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
> DSA_TAG_PROTO_LAN937X to improve readability.
>
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 net-next] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define
2023-12-06 16:01 [PATCH v2 net-next] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define Sean Nyekjaer
2023-12-06 16:07 ` Andrew Lunn
@ 2023-12-07 4:11 ` Arun.Ramadoss
2023-12-08 19:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Arun.Ramadoss @ 2023-12-07 4:11 UTC (permalink / raw)
To: andrew, olteanv, davem, Woojung.Huh, pabeni, sean, f.fainelli,
edumazet, UNGLinuxDriver, kuba
Cc: netdev, linux-kernel
On Wed, 2023-12-06 at 17:01 +0100, Sean Nyekjaer wrote:
> Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
> DSA_TAG_PROTO_LAN937X to improve readability.
>
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 net-next] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define
2023-12-06 16:01 [PATCH v2 net-next] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define Sean Nyekjaer
2023-12-06 16:07 ` Andrew Lunn
2023-12-07 4:11 ` Arun.Ramadoss
@ 2023-12-08 19:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-12-08 19:10 UTC (permalink / raw)
To: Sean Nyekjaer
Cc: woojung.huh, UNGLinuxDriver, andrew, f.fainelli, olteanv, davem,
edumazet, kuba, pabeni, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 6 Dec 2023 17:01:23 +0100 you wrote:
> Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
> DSA_TAG_PROTO_LAN937X to improve readability.
>
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> ---
> Changes since v1:
> - removed Fixes tag
>
> [...]
Here is the summary with links:
- [v2,net-next] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define
https://git.kernel.org/netdev/net-next/c/cf02bea7c171
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-08 19:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-06 16:01 [PATCH v2 net-next] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define Sean Nyekjaer
2023-12-06 16:07 ` Andrew Lunn
2023-12-07 4:11 ` Arun.Ramadoss
2023-12-08 19:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.