From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
chaozhu@linux.vnet.ibm.com, dev@dpdk.org,
Bruce Richardson <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Jonas Pfefferle <pepperjo@japf.ch>
Subject: Re: [PATCH v6 01/14] eal: introduce atomic exchange operation
Date: Mon, 22 Jan 2018 23:09:11 +0100 [thread overview]
Message-ID: <4894428.B7fjvfO1a3@xps> (raw)
In-Reply-To: <20180122134853.0cf85c70@xeon-e3>
22/01/2018 22:48, Stephen Hemminger:
> On Mon, 22 Jan 2018 22:03:02 +0100
> Thomas Monjalon <thomas@monjalon.net> wrote:
>
> > 22/01/2018 17:56, Stephen Hemminger:
> > > On Mon, 22 Jan 2018 00:50:55 +0100
> > > Thomas Monjalon <thomas@monjalon.net> wrote:
> > >
> > > > 21/01/2018 20:25, Ferruh Yigit:
> > > > > On 1/21/2018 6:59 PM, Ferruh Yigit wrote:
> > > > > > From: Stephen Hemminger <stephen@networkplumber.org>
> > > > > >
> > > > > > To handle atomic update of link status (64 bit), every driver
> > > > > > was doing its own version using cmpset.
> > > > > > Atomic exchange is a useful primitive in its own right;
> > > > > > therefore make it a EAL routine.
> > > > > >
> > > > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > > > > > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > > > > Series applied to dpdk-next-net/master, thanks.
> > > >
> > > > I need to drop this series when pulling in master,
> > > > because PPC is not supported.
> > > >
> > > > Chao, please could you help on this feature?
> > > > Thanks
> > >
> > > The generic code should work for PPC.
> >
> > No, the generic code is inside #ifdef RTE_FORCE_INTRINSICS.
> > PPC does not define RTE_FORCE_INTRINSICS,
> > and ARM could disable it I guess.
>
> I will add a non intrinsic generic version using cmpset.
OK thanks
prev parent reply other threads:[~2018-01-22 22:09 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 18:37 [PATCH v5 00/15] common ethdev linkstatus functions Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 01/15] eal: introduce atomic exchange operation Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 02/15] ethdev: add linkstatus get/set helper functions Stephen Hemminger
2018-01-17 7:49 ` Andrew Rybchenko
2018-01-16 18:37 ` [PATCH v5 03/15] net/virtio: use eth_linkstatus_set Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 04/15] net/vmxnet3: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 05/15] net/dpaa2: " Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 06/15] net/nfp: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 07/15] net/e1000: use rte_eth_linkstatus helpers Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 08/15] net/ixgbe: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 09/15] net/sfc: use new " Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 10/15] net/i40e: use " Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 11/15] net/liquidio: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 12/15] net/thunderx: " Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 13/15] net/szedata: use _rte_eth_linkstatus_set Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 14/15] net/octeontx: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 15/15] net/enic: " Stephen Hemminger
2018-01-17 5:19 ` [PATCH v5 00/15] common ethdev linkstatus functions Shreyansh Jain
2018-01-17 7:56 ` Andrew Rybchenko
2018-01-17 14:32 ` Ferruh Yigit
2018-01-17 16:05 ` Stephen Hemminger
2018-01-17 16:18 ` Ferruh Yigit
2018-01-19 16:35 ` Ferruh Yigit
2018-01-21 18:35 ` Ferruh Yigit
2018-01-21 18:59 ` [PATCH v6 01/14] eal: introduce atomic exchange operation Ferruh Yigit
2018-01-21 18:59 ` [PATCH v6 02/14] ethdev: add linkstatus get/set helper functions Ferruh Yigit
2018-01-21 18:59 ` [PATCH v6 03/14] net/virtio: use ethdev linkstatus " Ferruh Yigit
2018-01-21 18:59 ` [PATCH v6 04/14] net/vmxnet3: " Ferruh Yigit
2018-01-21 18:59 ` [PATCH v6 05/14] net/dpaa2: " Ferruh Yigit
2018-01-22 12:28 ` Shreyansh Jain
2018-01-21 18:59 ` [PATCH v6 06/14] net/nfp: " Ferruh Yigit
2018-01-21 18:59 ` [PATCH v6 07/14] net/e1000: " Ferruh Yigit
2018-01-21 18:59 ` [PATCH v6 08/14] net/ixgbe: " Ferruh Yigit
2018-01-21 18:59 ` [PATCH v6 09/14] net/i40e: " Ferruh Yigit
2018-01-21 18:59 ` [PATCH v6 10/14] net/liquidio: " Ferruh Yigit
2018-01-21 18:59 ` [PATCH v6 11/14] net/thunderx: " Ferruh Yigit
2018-01-21 18:59 ` [PATCH v6 12/14] net/szedata2: " Ferruh Yigit
2018-01-21 18:59 ` [PATCH v6 13/14] net/octeontx: " Ferruh Yigit
2018-01-21 18:59 ` [PATCH v6 14/14] net/enic: " Ferruh Yigit
2018-01-21 19:25 ` [PATCH v6 01/14] eal: introduce atomic exchange operation Ferruh Yigit
2018-01-21 23:50 ` Thomas Monjalon
2018-01-22 16:56 ` Stephen Hemminger
2018-01-22 21:03 ` Thomas Monjalon
2018-01-22 21:48 ` Stephen Hemminger
2018-01-22 22:09 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4894428.B7fjvfO1a3@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=pepperjo@japf.ch \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.