All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
	Ferruh Yigit <ferruh.yigit@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v5 00/15] common ethdev linkstatus functions
Date: Wed, 17 Jan 2018 10:49:03 +0530	[thread overview]
Message-ID: <d1368748-0b22-5f67-c063-5e72bd8fd0a8@nxp.com> (raw)
In-Reply-To: <20180116183755.24542-1-stephen@networkplumber.org>

On Wednesday 17 January 2018 12:07 AM, Stephen Hemminger wrote:
> While reviewing drivers, noticed a lot of unnecessary
> duplication of code in drivers for handling the eth_dev link status
> information. While consolidating this, it also became obvious that
> some drivers behave differently for no good reason.
> 
> It also was a good chance to introduce atomic exchange primitives
> in EAL because there are other places using cmpset where not
> necessary (such as bonding).
> 
> Mostly only compile tested only, don't have all of the hardware
> available (except ixgbe and virtio) to test.
> 
> Note: the eth_dev_link_update function return value is inconsistent
> across drivers. Should be changed to be void.
> 
> v5
>   - checkpatch whitespace cleanup
> 
> v4
>   - incorporate review feedback
>   - rename _rte_linkstatus to rte_linkstatus
>   - change return value of _rte_linkstatus
>   - optimize get on 64bit platforms
>   - change return value of rte_linkstatus_set
> 
> v3
>   - align rte_linkstatus_get with rte_atomic64_read
>   - virtio use ETH_SPEED_NUM_10G
>   - add net/
> 
> v2
>   - function names changed
>   - rebased to current master
> 
[...]

1. "--in-reply-to" is recommended way ([1])

2. Specifically here: there is a v4 already by Ferruh (targeting 
maintainers directly, I think) and then another by you. And with 
separate threads it is difficult to compare them. Maybe you prefer flat 
email threads - it helps people like me who don't.

3. I had put my Ack on v4 by Ferruh, but it seems dpaa2 specific code 
has changed from Ferruh's v4 to your v4/v5. Please ignore that Ack. I 
will send my acceptance on your v5.

[1] http://dpdk.org/dev

  parent reply	other threads:[~2018-01-17  5:04 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16 18:37 [PATCH v5 00/15] common ethdev linkstatus functions Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 01/15] eal: introduce atomic exchange operation Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 02/15] ethdev: add linkstatus get/set helper functions Stephen Hemminger
2018-01-17  7:49   ` Andrew Rybchenko
2018-01-16 18:37 ` [PATCH v5 03/15] net/virtio: use eth_linkstatus_set Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 04/15] net/vmxnet3: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 05/15] net/dpaa2: " Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 06/15] net/nfp: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 07/15] net/e1000: use rte_eth_linkstatus helpers Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 08/15] net/ixgbe: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 09/15] net/sfc: use new " Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 10/15] net/i40e: use " Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 11/15] net/liquidio: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 12/15] net/thunderx: " Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 13/15] net/szedata: use _rte_eth_linkstatus_set Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 14/15] net/octeontx: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-16 18:37 ` [PATCH v5 15/15] net/enic: " Stephen Hemminger
2018-01-17  5:19 ` Shreyansh Jain [this message]
2018-01-17  7:56 ` [PATCH v5 00/15] common ethdev linkstatus functions Andrew Rybchenko
2018-01-17 14:32   ` Ferruh Yigit
2018-01-17 16:05     ` Stephen Hemminger
2018-01-17 16:18       ` Ferruh Yigit
2018-01-19 16:35         ` Ferruh Yigit
2018-01-21 18:35           ` Ferruh Yigit
2018-01-21 18:59 ` [PATCH v6 01/14] eal: introduce atomic exchange operation Ferruh Yigit
2018-01-21 18:59   ` [PATCH v6 02/14] ethdev: add linkstatus get/set helper functions Ferruh Yigit
2018-01-21 18:59   ` [PATCH v6 03/14] net/virtio: use ethdev linkstatus " Ferruh Yigit
2018-01-21 18:59   ` [PATCH v6 04/14] net/vmxnet3: " Ferruh Yigit
2018-01-21 18:59   ` [PATCH v6 05/14] net/dpaa2: " Ferruh Yigit
2018-01-22 12:28     ` Shreyansh Jain
2018-01-21 18:59   ` [PATCH v6 06/14] net/nfp: " Ferruh Yigit
2018-01-21 18:59   ` [PATCH v6 07/14] net/e1000: " Ferruh Yigit
2018-01-21 18:59   ` [PATCH v6 08/14] net/ixgbe: " Ferruh Yigit
2018-01-21 18:59   ` [PATCH v6 09/14] net/i40e: " Ferruh Yigit
2018-01-21 18:59   ` [PATCH v6 10/14] net/liquidio: " Ferruh Yigit
2018-01-21 18:59   ` [PATCH v6 11/14] net/thunderx: " Ferruh Yigit
2018-01-21 18:59   ` [PATCH v6 12/14] net/szedata2: " Ferruh Yigit
2018-01-21 18:59   ` [PATCH v6 13/14] net/octeontx: " Ferruh Yigit
2018-01-21 18:59   ` [PATCH v6 14/14] net/enic: " Ferruh Yigit
2018-01-21 19:25   ` [PATCH v6 01/14] eal: introduce atomic exchange operation Ferruh Yigit
2018-01-21 23:50     ` Thomas Monjalon
2018-01-22 16:56       ` Stephen Hemminger
2018-01-22 21:03         ` Thomas Monjalon
2018-01-22 21:48           ` Stephen Hemminger
2018-01-22 22:09             ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1368748-0b22-5f67-c063-5e72bd8fd0a8@nxp.com \
    --to=shreyansh.jain@nxp.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.