All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 05/14] drm: make drm_file.h self contained
@ 2018-12-30 17:48 ` Sam Ravnborg
  0 siblings, 0 replies; 4+ messages in thread
From: Sam Ravnborg @ 2018-12-30 17:48 UTC (permalink / raw)
  To: Daniel Vetter, David Airlie, Maarten Lankhorst, Maxime Ripard,
	Sean Paul, David Lechner, Laurent Pinchart, linux-kernel,
	dri-devel
  Cc: Sam Ravnborg, Jani Nikula

drm_file.h embed struct idr, so this file need to know
the full type definition.

With this change users of drm_file.h are no longer forced
to include idr.h - a file they usually get from drmP.h

This makes it simpler to remove drmP.h includes

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
---
 include/drm/drm_file.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
index 84ac79219e4c..bbdb74c3d7ff 100644
--- a/include/drm/drm_file.h
+++ b/include/drm/drm_file.h
@@ -30,6 +30,7 @@
 #ifndef _DRM_FILE_H_
 #define _DRM_FILE_H_
 
+#include <linux/idr.h>
 #include <linux/types.h>
 #include <linux/completion.h>
 
-- 
2.12.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 05/14] drm: make drm_file.h self contained
@ 2018-12-30 17:48 ` Sam Ravnborg
  0 siblings, 0 replies; 4+ messages in thread
From: Sam Ravnborg @ 2018-12-30 17:48 UTC (permalink / raw)
  To: Daniel Vetter, David Airlie, Maarten Lankhorst, Maxime Ripard,
	Sean Paul, David Lechner, Laurent Pinchart, linux-kernel,
	dri-devel
  Cc: Jani Nikula, Sam Ravnborg

drm_file.h embed struct idr, so this file need to know
the full type definition.

With this change users of drm_file.h are no longer forced
to include idr.h - a file they usually get from drmP.h

This makes it simpler to remove drmP.h includes

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
---
 include/drm/drm_file.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
index 84ac79219e4c..bbdb74c3d7ff 100644
--- a/include/drm/drm_file.h
+++ b/include/drm/drm_file.h
@@ -30,6 +30,7 @@
 #ifndef _DRM_FILE_H_
 #define _DRM_FILE_H_
 
+#include <linux/idr.h>
 #include <linux/types.h>
 #include <linux/completion.h>
 
-- 
2.12.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 05/14] drm: make drm_file.h self contained
  2018-12-30 17:48 ` Sam Ravnborg
@ 2019-01-07 15:56   ` Noralf Trønnes
  -1 siblings, 0 replies; 4+ messages in thread
From: Noralf Trønnes @ 2019-01-07 15:56 UTC (permalink / raw)
  To: Sam Ravnborg, Daniel Vetter, David Airlie, Maarten Lankhorst,
	Maxime Ripard, Sean Paul, David Lechner, Laurent Pinchart,
	linux-kernel, dri-devel
  Cc: Jani Nikula



Den 30.12.2018 18.48, skrev Sam Ravnborg:
> drm_file.h embed struct idr, so this file need to know
> the full type definition.
> 
> With this change users of drm_file.h are no longer forced
> to include idr.h - a file they usually get from drmP.h
> 
> This makes it simpler to remove drmP.h includes
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> ---

Acked-by: Noralf Trønnes <noralf@tronnes.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 05/14] drm: make drm_file.h self contained
@ 2019-01-07 15:56   ` Noralf Trønnes
  0 siblings, 0 replies; 4+ messages in thread
From: Noralf Trønnes @ 2019-01-07 15:56 UTC (permalink / raw)
  To: Sam Ravnborg, Daniel Vetter, David Airlie, Maarten Lankhorst,
	Maxime Ripard, Sean Paul, David Lechner, Laurent Pinchart,
	linux-kernel, dri-devel
  Cc: Jani Nikula



Den 30.12.2018 18.48, skrev Sam Ravnborg:
> drm_file.h embed struct idr, so this file need to know
> the full type definition.
> 
> With this change users of drm_file.h are no longer forced
> to include idr.h - a file they usually get from drmP.h
> 
> This makes it simpler to remove drmP.h includes
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> ---

Acked-by: Noralf Trønnes <noralf@tronnes.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-01-07 15:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-30 17:48 [PATCH v2 05/14] drm: make drm_file.h self contained Sam Ravnborg
2018-12-30 17:48 ` Sam Ravnborg
2019-01-07 15:56 ` Noralf Trønnes
2019-01-07 15:56   ` Noralf Trønnes

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.