All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Ryder Lee <ryder.lee@mediatek.com>, Felix Fietkau <nbd@nbd.name>,
	Johannes Berg <johannes.berg@intel.com>
Cc: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
	Shayne Chen <shayne.chen@mediatek.com>,
	Evelyn Tsai <evelyn.tsai@mediatek.com>,
	Bo Jiao <bo.jiao@mediatek.com>,
	Sujuan Chen <sujuan.chen@mediatek.com>,
	linux-wireless@vger.kernel.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 3/4] mac80211: add rate control support for encap offload
Date: Fri, 28 May 2021 12:46:38 +0200	[thread overview]
Message-ID: <489e6d51-c3f0-452d-ab63-ba83bba7ec02@broadcom.com> (raw)
In-Reply-To: <d447c18f07fe3dc7092f5502de3e35e6b7ae69e1.1622164961.git.ryder.lee@mediatek.com>

On 5/28/2021 8:05 AM, Ryder Lee wrote:
> The software rate control cannot deal with encap offload, so fix it.
> 
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
> change since v2 - none
> ---
>   net/mac80211/ieee80211_i.h |  9 +++++++++
>   net/mac80211/rate.c        |  9 ++-------
>   net/mac80211/tx.c          | 18 ++++++++++++++----
>   3 files changed, 25 insertions(+), 11 deletions(-)

[...]

> diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
> index d3016c3a3069..0a4bc9e08637 100644
> --- a/net/mac80211/tx.c
> +++ b/net/mac80211/tx.c

[...]

> @@ -729,7 +730,8 @@ ieee80211_tx_h_rate_ctrl(struct ieee80211_tx_data *tx)
>   		 "%s: Dropped data frame as no usable bitrate found while "
>   		 "scanning and associated. Target station: "
>   		 "%pM on %d GHz band\n",
> -		 tx->sdata->name, hdr->addr1,
> +		 tx->sdata->name,
> +		 encap ? ((struct ethhdr *)hdr)->h_dest : hdr->addr1,
>   		 info->band ? 5 : 2))

Not related to this change, but I guess the band can also be 6 these days.

Regards,
Arend

WARNING: multiple messages have this Message-ID (diff)
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Ryder Lee <ryder.lee@mediatek.com>, Felix Fietkau <nbd@nbd.name>,
	Johannes Berg <johannes.berg@intel.com>
Cc: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
	Shayne Chen <shayne.chen@mediatek.com>,
	Evelyn Tsai <evelyn.tsai@mediatek.com>,
	Bo Jiao <bo.jiao@mediatek.com>,
	Sujuan Chen <sujuan.chen@mediatek.com>,
	linux-wireless@vger.kernel.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 3/4] mac80211: add rate control support for encap offload
Date: Fri, 28 May 2021 12:46:38 +0200	[thread overview]
Message-ID: <489e6d51-c3f0-452d-ab63-ba83bba7ec02@broadcom.com> (raw)
In-Reply-To: <d447c18f07fe3dc7092f5502de3e35e6b7ae69e1.1622164961.git.ryder.lee@mediatek.com>

On 5/28/2021 8:05 AM, Ryder Lee wrote:
> The software rate control cannot deal with encap offload, so fix it.
> 
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
> change since v2 - none
> ---
>   net/mac80211/ieee80211_i.h |  9 +++++++++
>   net/mac80211/rate.c        |  9 ++-------
>   net/mac80211/tx.c          | 18 ++++++++++++++----
>   3 files changed, 25 insertions(+), 11 deletions(-)

[...]

> diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
> index d3016c3a3069..0a4bc9e08637 100644
> --- a/net/mac80211/tx.c
> +++ b/net/mac80211/tx.c

[...]

> @@ -729,7 +730,8 @@ ieee80211_tx_h_rate_ctrl(struct ieee80211_tx_data *tx)
>   		 "%s: Dropped data frame as no usable bitrate found while "
>   		 "scanning and associated. Target station: "
>   		 "%pM on %d GHz band\n",
> -		 tx->sdata->name, hdr->addr1,
> +		 tx->sdata->name,
> +		 encap ? ((struct ethhdr *)hdr)->h_dest : hdr->addr1,
>   		 info->band ? 5 : 2))

Not related to this change, but I guess the band can also be 6 these days.

Regards,
Arend

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

  reply	other threads:[~2021-05-28 10:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-28  6:05 [PATCH v2 1/4] mac80211: call ieee80211_tx_h_rate_ctrl() when dequeue Ryder Lee
2021-05-28  6:05 ` Ryder Lee
2021-05-28  6:05 ` [PATCH v2 2/4] mac80211: minstrel_ht: fix minstrel_aggr_check for encap offload Ryder Lee
2021-05-28  6:05   ` Ryder Lee
2021-05-28  6:05 ` [PATCH v2 3/4] mac80211: add rate control support " Ryder Lee
2021-05-28  6:05   ` Ryder Lee
2021-05-28 10:46   ` Arend van Spriel [this message]
2021-05-28 10:46     ` Arend van Spriel
2021-05-28  6:05 ` [PATCH v2 4/4] mt76: mt7615: add 802.11 encap offload support Ryder Lee
2021-05-28  6:05   ` Ryder Lee
2021-06-10 11:10 ` [PATCH v2 1/4] mac80211: call ieee80211_tx_h_rate_ctrl() when dequeue Felix Fietkau
2021-06-10 11:10   ` Felix Fietkau
2021-06-16 22:45   ` Ryder Lee
2021-06-16 22:45     ` Ryder Lee
2021-06-17 10:50 ` Felix Fietkau
2021-06-17 10:50   ` Felix Fietkau
2021-06-17 17:59   ` Felix Fietkau
2021-06-17 17:59     ` Felix Fietkau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=489e6d51-c3f0-452d-ab63-ba83bba7ec02@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=bo.jiao@mediatek.com \
    --cc=evelyn.tsai@mediatek.com \
    --cc=johannes.berg@intel.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=nbd@nbd.name \
    --cc=ryder.lee@mediatek.com \
    --cc=shayne.chen@mediatek.com \
    --cc=sujuan.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.