All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy@arm.com>
To: Mikko Perttunen <mperttunen@nvidia.com>,
	thierry.reding@gmail.com, jonathanh@nvidia.com, joro@8bytes.org,
	will@kernel.org, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/9] dt-bindings: host1x: Add memory-contexts property
Date: Mon, 21 Feb 2022 15:23:29 +0000	[thread overview]
Message-ID: <48ac567b-37e8-1fa2-c389-536e276fdd2c@arm.com> (raw)
In-Reply-To: <20220218113952.3077606-2-mperttunen@nvidia.com>

On 2022-02-18 11:39, Mikko Perttunen via iommu wrote:
> Add schema information for the memory-contexts property used to
> specify context stream IDs. This uses the standard iommu-map property
> inside a child node.

Couldn't you simply make "iommu-map" an allowed property on the host1x 
node itself? From a DT perspective I'm not sure the intermediate node 
really fits meaningfully, and I can't see that it serves much purpose in 
practice either, other than perhaps defeating fw_devlink.

Robin.

> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---
> v3:
> * New patch
> ---
>   .../bindings/display/tegra/nvidia,tegra20-host1x.yaml  | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml
> index 4fd513efb0f7..3ac0fde54a16 100644
> --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml
> +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml
> @@ -144,6 +144,16 @@ allOf:
>           reset-names:
>             maxItems: 1
>   
> +        memory-contexts:
> +          type: object
> +          properties:
> +            iommu-map:
> +              description: Specification of stream IDs available for memory context device
> +                use. Should be a mapping of IDs 0..n to IOMMU entries corresponding to
> +                usable stream IDs.
> +          required:
> +            - iommu-map
> +
>         required:
>           - reg-names
>   

WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Mikko Perttunen <mperttunen@nvidia.com>,
	thierry.reding@gmail.com, jonathanh@nvidia.com, joro@8bytes.org,
	will@kernel.org, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/9] dt-bindings: host1x: Add memory-contexts property
Date: Mon, 21 Feb 2022 15:23:29 +0000	[thread overview]
Message-ID: <48ac567b-37e8-1fa2-c389-536e276fdd2c@arm.com> (raw)
In-Reply-To: <20220218113952.3077606-2-mperttunen@nvidia.com>

On 2022-02-18 11:39, Mikko Perttunen via iommu wrote:
> Add schema information for the memory-contexts property used to
> specify context stream IDs. This uses the standard iommu-map property
> inside a child node.

Couldn't you simply make "iommu-map" an allowed property on the host1x 
node itself? From a DT perspective I'm not sure the intermediate node 
really fits meaningfully, and I can't see that it serves much purpose in 
practice either, other than perhaps defeating fw_devlink.

Robin.

> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---
> v3:
> * New patch
> ---
>   .../bindings/display/tegra/nvidia,tegra20-host1x.yaml  | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml
> index 4fd513efb0f7..3ac0fde54a16 100644
> --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml
> +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml
> @@ -144,6 +144,16 @@ allOf:
>           reset-names:
>             maxItems: 1
>   
> +        memory-contexts:
> +          type: object
> +          properties:
> +            iommu-map:
> +              description: Specification of stream IDs available for memory context device
> +                use. Should be a mapping of IDs 0..n to IOMMU entries corresponding to
> +                usable stream IDs.
> +          required:
> +            - iommu-map
> +
>         required:
>           - reg-names
>   
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Mikko Perttunen <mperttunen@nvidia.com>,
	thierry.reding@gmail.com, jonathanh@nvidia.com, joro@8bytes.org,
	will@kernel.org, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/9] dt-bindings: host1x: Add memory-contexts property
Date: Mon, 21 Feb 2022 15:23:29 +0000	[thread overview]
Message-ID: <48ac567b-37e8-1fa2-c389-536e276fdd2c@arm.com> (raw)
In-Reply-To: <20220218113952.3077606-2-mperttunen@nvidia.com>

On 2022-02-18 11:39, Mikko Perttunen via iommu wrote:
> Add schema information for the memory-contexts property used to
> specify context stream IDs. This uses the standard iommu-map property
> inside a child node.

Couldn't you simply make "iommu-map" an allowed property on the host1x 
node itself? From a DT perspective I'm not sure the intermediate node 
really fits meaningfully, and I can't see that it serves much purpose in 
practice either, other than perhaps defeating fw_devlink.

Robin.

> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---
> v3:
> * New patch
> ---
>   .../bindings/display/tegra/nvidia,tegra20-host1x.yaml  | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml
> index 4fd513efb0f7..3ac0fde54a16 100644
> --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml
> +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml
> @@ -144,6 +144,16 @@ allOf:
>           reset-names:
>             maxItems: 1
>   
> +        memory-contexts:
> +          type: object
> +          properties:
> +            iommu-map:
> +              description: Specification of stream IDs available for memory context device
> +                use. Should be a mapping of IDs 0..n to IOMMU entries corresponding to
> +                usable stream IDs.
> +          required:
> +            - iommu-map
> +
>         required:
>           - reg-names
>   

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-02-21 15:23 UTC|newest]

Thread overview: 147+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18 11:39 [PATCH v3 0/9] Host1x context isolation support Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen via iommu
2022-02-18 11:39 ` Mikko Perttunen
2022-02-18 11:39 ` [PATCH v3 1/9] dt-bindings: host1x: Add memory-contexts property Mikko Perttunen
2022-02-18 11:39   ` Mikko Perttunen
2022-02-18 11:39   ` Mikko Perttunen via iommu
2022-02-18 11:39   ` Mikko Perttunen
2022-02-21 15:23   ` Robin Murphy [this message]
2022-02-21 15:23     ` Robin Murphy
2022-02-21 15:23     ` Robin Murphy
2022-02-21 15:28     ` Mikko Perttunen
2022-02-21 15:28       ` Mikko Perttunen
2022-02-21 15:28       ` Mikko Perttunen
2022-02-21 16:58       ` Robin Murphy
2022-02-21 16:58         ` Robin Murphy
2022-02-21 16:58         ` Robin Murphy
2022-02-21 17:12         ` Mikko Perttunen
2022-02-21 17:12           ` Mikko Perttunen
2022-02-21 17:12           ` Mikko Perttunen
2022-02-18 11:39 ` [PATCH v3 2/9] gpu: host1x: Add context bus Mikko Perttunen
2022-02-18 11:39   ` Mikko Perttunen
2022-02-18 11:39   ` Mikko Perttunen via iommu
2022-02-18 11:39   ` Mikko Perttunen
2022-02-19 17:54   ` Dmitry Osipenko
2022-02-19 17:54     ` Dmitry Osipenko
2022-02-19 17:54     ` Dmitry Osipenko
2022-02-19 17:54     ` Dmitry Osipenko
2022-02-19 18:15     ` Dmitry Osipenko
2022-02-19 18:15       ` Dmitry Osipenko
2022-02-19 18:15       ` Dmitry Osipenko
2022-02-19 18:15       ` Dmitry Osipenko
2022-02-22 16:21   ` Christoph Hellwig
2022-02-22 16:21     ` Christoph Hellwig
2022-02-22 16:21     ` Christoph Hellwig
2022-02-22 21:30     ` Robin Murphy
2022-02-22 21:30       ` Robin Murphy
2022-02-22 21:30       ` Robin Murphy
2022-02-22 21:30       ` Robin Murphy
2022-02-23  6:36       ` Christoph Hellwig
2022-02-23  6:36         ` Christoph Hellwig
2022-02-23  6:36         ` Christoph Hellwig
2022-02-18 11:39 ` [PATCH v3 3/9] gpu: host1x: Add context device management code Mikko Perttunen
2022-02-18 11:39   ` Mikko Perttunen
2022-02-18 11:39   ` Mikko Perttunen via iommu
2022-02-18 11:39   ` Mikko Perttunen
2022-02-19 17:48   ` Dmitry Osipenko
2022-02-19 17:48     ` Dmitry Osipenko
2022-02-19 17:48     ` Dmitry Osipenko
2022-02-19 17:48     ` Dmitry Osipenko
2022-02-21 11:35     ` Mikko Perttunen
2022-02-21 11:35       ` Mikko Perttunen
2022-02-21 11:35       ` Mikko Perttunen
2022-02-21 11:35       ` Mikko Perttunen
2022-02-19 17:52   ` Dmitry Osipenko
2022-02-19 17:52     ` Dmitry Osipenko
2022-02-19 17:52     ` Dmitry Osipenko
2022-02-19 17:52     ` Dmitry Osipenko
2022-02-21 11:37     ` Mikko Perttunen
2022-02-21 11:37       ` Mikko Perttunen
2022-02-21 11:37       ` Mikko Perttunen
2022-02-21 11:37       ` Mikko Perttunen
2022-02-22 16:24   ` Christoph Hellwig
2022-02-22 16:24     ` Christoph Hellwig
2022-02-22 16:24     ` Christoph Hellwig
2022-02-23  9:44     ` Mikko Perttunen
2022-02-23  9:44       ` Mikko Perttunen
2022-02-23  9:44       ` Mikko Perttunen
2022-02-23  9:44       ` Mikko Perttunen
2022-02-18 11:39 ` [PATCH v3 4/9] gpu: host1x: Program context stream ID on submission Mikko Perttunen
2022-02-18 11:39   ` Mikko Perttunen
2022-02-18 11:39   ` Mikko Perttunen via iommu
2022-02-18 11:39   ` Mikko Perttunen
2022-02-18 11:39 ` [PATCH v3 5/9] iommu/arm-smmu: Attach to host1x context device bus Mikko Perttunen
2022-02-18 11:39   ` Mikko Perttunen
2022-02-18 11:39   ` Mikko Perttunen via iommu
2022-02-18 11:39   ` Mikko Perttunen
2022-02-18 11:39 ` [PATCH v3 6/9] arm64: tegra: Add Host1x context stream IDs on Tegra186+ Mikko Perttunen
2022-02-18 11:39   ` Mikko Perttunen
2022-02-18 11:39   ` Mikko Perttunen via iommu
2022-02-18 11:39   ` Mikko Perttunen
2022-02-18 11:39 ` [PATCH v3 7/9] drm/tegra: falcon: Set DMACTX field on DMA transactions Mikko Perttunen
2022-02-18 11:39   ` Mikko Perttunen
2022-02-18 11:39   ` Mikko Perttunen via iommu
2022-02-18 11:39   ` Mikko Perttunen
2022-02-18 11:39 ` [PATCH v3 8/9] drm/tegra: vic: Implement get_streamid_offset Mikko Perttunen
2022-02-18 11:39   ` Mikko Perttunen
2022-02-18 11:39   ` Mikko Perttunen via iommu
2022-02-18 11:39   ` Mikko Perttunen
2022-02-19 18:49   ` Dmitry Osipenko
2022-02-19 18:49     ` Dmitry Osipenko
2022-02-19 18:49     ` Dmitry Osipenko
2022-02-19 18:49     ` Dmitry Osipenko
2022-02-19 18:54     ` Dmitry Osipenko
2022-02-19 18:54       ` Dmitry Osipenko
2022-02-19 18:54       ` Dmitry Osipenko
2022-02-19 18:54       ` Dmitry Osipenko
2022-02-21 11:44       ` Mikko Perttunen
2022-02-21 11:44         ` Mikko Perttunen
2022-02-21 11:44         ` Mikko Perttunen
2022-02-21 11:44         ` Mikko Perttunen
2022-02-21 20:10         ` Dmitry Osipenko
2022-02-21 20:10           ` Dmitry Osipenko
2022-02-21 20:10           ` Dmitry Osipenko
2022-02-21 20:10           ` Dmitry Osipenko
2022-02-22  8:27           ` Mikko Perttunen
2022-02-22  8:27             ` Mikko Perttunen
2022-02-22  8:27             ` Mikko Perttunen
2022-02-22  8:27             ` Mikko Perttunen
2022-02-22 10:46             ` Dmitry Osipenko
2022-02-22 10:46               ` Dmitry Osipenko
2022-02-22 10:46               ` Dmitry Osipenko
2022-02-22 10:46               ` Dmitry Osipenko
2022-02-22 10:54               ` Mikko Perttunen
2022-02-22 10:54                 ` Mikko Perttunen
2022-02-22 10:54                 ` Mikko Perttunen
2022-02-22 10:54                 ` Mikko Perttunen
2022-02-22 11:02                 ` Dmitry Osipenko
2022-02-22 11:02                   ` Dmitry Osipenko
2022-02-22 11:02                   ` Dmitry Osipenko
2022-02-22 11:02                   ` Dmitry Osipenko
2022-02-21 17:27   ` Robin Murphy
2022-02-21 17:27     ` Robin Murphy
2022-02-21 17:27     ` Robin Murphy
2022-02-21 17:36     ` Mikko Perttunen
2022-02-21 17:36       ` Mikko Perttunen
2022-02-21 17:36       ` Mikko Perttunen
2022-02-18 11:39 ` [PATCH v3 9/9] drm/tegra: Support context isolation Mikko Perttunen
2022-02-18 11:39   ` Mikko Perttunen
2022-02-18 11:39   ` Mikko Perttunen via iommu
2022-02-18 11:39   ` Mikko Perttunen
2022-02-19 18:35   ` Dmitry Osipenko
2022-02-19 18:35     ` Dmitry Osipenko
2022-02-19 18:35     ` Dmitry Osipenko
2022-02-19 18:35     ` Dmitry Osipenko
2022-02-21 12:06     ` Mikko Perttunen
2022-02-21 12:06       ` Mikko Perttunen
2022-02-21 12:06       ` Mikko Perttunen
2022-02-21 12:06       ` Mikko Perttunen
2022-02-21 20:02       ` Dmitry Osipenko
2022-02-21 20:02         ` Dmitry Osipenko
2022-02-21 20:02         ` Dmitry Osipenko
2022-02-21 20:02         ` Dmitry Osipenko
2022-02-22  8:37         ` Mikko Perttunen
2022-02-22  8:37           ` Mikko Perttunen
2022-02-22  8:37           ` Mikko Perttunen
2022-02-22  8:37           ` Mikko Perttunen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48ac567b-37e8-1fa2-c389-536e276fdd2c@arm.com \
    --to=robin.murphy@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jonathanh@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mperttunen@nvidia.com \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.