From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Bernhard M. Wiedemann" <bwiedemann@suse.de>, xen-devel@lists.xen.org
Cc: Wei Liu <wei.liu2@citrix.com>, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] x86/efi: Do not insert timestamps in efi files
Date: Wed, 24 Oct 2018 09:16:33 +0100 [thread overview]
Message-ID: <48b3314c-0f6f-f174-6506-3da29d976ef8@citrix.com> (raw)
In-Reply-To: <20181024080350.2449-1-bwiedemann@suse.de>
On 24/10/2018 09:03, Bernhard M. Wiedemann wrote:
> in order to make builds reproducible.
> See https://reproducible-builds.org/ for why this is good.
>
> Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
Please follow the MAINTAINERS file and CC the correct people. I've done
so on this email.
> ---
> xen/arch/x86/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
> index 162b0b94c0..052bdb1e25 100644
> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -158,6 +158,7 @@ note.o: $(TARGET)-syms
>
> EFI_LDFLAGS = $(patsubst -m%,-mi386pep,$(LDFLAGS)) --subsystem=10
> EFI_LDFLAGS += --image-base=$(1) --stack=0,0 --heap=0,0 --strip-debug
> +EFI_LDFLAGS += --no-insert-timestamp
> EFI_LDFLAGS += --section-alignment=0x200000 --file-alignment=0x20
> EFI_LDFLAGS += --major-image-version=$(XEN_VERSION)
> EFI_LDFLAGS += --minor-image-version=$(XEN_SUBVERSION)
This change is fine in principle, but do all i386pep compatible versions
of LD support this parameter?
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-10-24 8:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 8:03 [PATCH] x86/efi: Do not insert timestamps in efi files Bernhard M. Wiedemann
2018-10-24 8:16 ` Andrew Cooper [this message]
2018-10-24 12:49 ` Bernhard M. Wiedemann
2018-10-24 13:04 ` Wei Liu
2018-10-24 13:45 ` Bernhard M. Wiedemann
2018-10-25 8:02 ` Wei Liu
[not found] ` <108D0A7C020000E4CA4B4E14@prv1-mh.provo.novell.com>
[not found] ` <74F2501302000079CA4B4E14@prv1-mh.provo.novell.com>
2018-10-25 12:35 ` Jan Beulich
2018-10-25 14:00 ` Andrew Cooper
2018-10-25 14:08 ` Jan Beulich
2018-10-26 11:11 ` Bernhard M. Wiedemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48b3314c-0f6f-f174-6506-3da29d976ef8@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=bwiedemann@suse.de \
--cc=jbeulich@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.