* [PATCH linux-next] smack: lsm: remove the unneeded result variable
@ 2022-09-12 10:05 cgel.zte
2022-09-12 17:00 ` Casey Schaufler
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-09-12 10:05 UTC (permalink / raw)
To: casey
Cc: paul, jmorris, serge, linux-security-module, linux-kernel,
Xu Panda, Zeal Robot
From: Xu Panda <xu.panda@zte.com.cn>
Return the value smk_ptrace_rule_check() directly instead of storing it
in another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
---
security/smack/smack_lsm.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 16e24a6cdc7c..b6306d71c908 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -497,13 +497,11 @@ static int smack_ptrace_access_check(struct task_struct *ctp, unsigned int mode)
*/
static int smack_ptrace_traceme(struct task_struct *ptp)
{
- int rc;
struct smack_known *skp;
skp = smk_of_task(smack_cred(current_cred()));
- rc = smk_ptrace_rule_check(ptp, skp, PTRACE_MODE_ATTACH, __func__);
- return rc;
+ return smk_ptrace_rule_check(ptp, skp, PTRACE_MODE_ATTACH, __func__);
}
/**
--
2.15.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] smack: lsm: remove the unneeded result variable
2022-09-12 10:05 [PATCH linux-next] smack: lsm: remove the unneeded result variable cgel.zte
@ 2022-09-12 17:00 ` Casey Schaufler
0 siblings, 0 replies; 2+ messages in thread
From: Casey Schaufler @ 2022-09-12 17:00 UTC (permalink / raw)
To: cgel.zte
Cc: paul, jmorris, serge, linux-security-module, linux-kernel,
Xu Panda, Zeal Robot, casey
On 9/12/2022 3:05 AM, cgel.zte@gmail.com wrote:
> From: Xu Panda <xu.panda@zte.com.cn>
>
> Return the value smk_ptrace_rule_check() directly instead of storing it
> in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
Added to https://github.com/cschaufler/smack-next#next.
Thank you.
> ---
> security/smack/smack_lsm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 16e24a6cdc7c..b6306d71c908 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -497,13 +497,11 @@ static int smack_ptrace_access_check(struct task_struct *ctp, unsigned int mode)
> */
> static int smack_ptrace_traceme(struct task_struct *ptp)
> {
> - int rc;
> struct smack_known *skp;
>
> skp = smk_of_task(smack_cred(current_cred()));
>
> - rc = smk_ptrace_rule_check(ptp, skp, PTRACE_MODE_ATTACH, __func__);
> - return rc;
> + return smk_ptrace_rule_check(ptp, skp, PTRACE_MODE_ATTACH, __func__);
> }
>
> /**
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-12 17:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-12 10:05 [PATCH linux-next] smack: lsm: remove the unneeded result variable cgel.zte
2022-09-12 17:00 ` Casey Schaufler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.