[Buildroot] [PATCH 1/5] package/efl: remove lefover disable-wayland option

[Buildroot] [PATCH 1/5] package/efl: remove lefover disable-wayland option

[Romain Naour]

Wayland support was re-added by [1] but the --disable-wayland option
was not removed from EFL_CONF_OPTS.

[1] f30eec41f95ed99909eb2c7590d83c12b9142df2

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 package/efl/efl.mk | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/efl/efl.mk b/package/efl/efl.mk
index 3644000..8772871 100644
--- a/package/efl/efl.mk
+++ b/package/efl/efl.mk
@@ -44,7 +44,6 @@ EFL_CONF_OPTS = \
 	--disable-sdl \
 	--disable-spectre \
 	--disable-xinput22 \
-	--disable-wayland \
 	--enable-liblz4 \
 	--with-doxygen=no
 
-- 
2.9.3

[Buildroot] [PATCH 2/5] package/efl: fix coding style problems preported by check-package script

[Romain Naour]

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 package/efl/Config.in | 33 +++++++++++++++++----------------
 1 file changed, 17 insertions(+), 16 deletions(-)

diff --git a/package/efl/Config.in b/package/efl/Config.in
index b9c4334..0785ab8 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -26,8 +26,8 @@ if BR2_PACKAGE_EFL
 
 config BR2_PACKAGE_EFL_BULLET
 	bool "Enable bullet support (recommended)"
-	select BR2_PACKAGE_BULLET
 	default y
+	select BR2_PACKAGE_BULLET
 	help
 	  If you have chosen to disable physics support, this disables
 	  lots of core functionality and is effectively never
@@ -38,8 +38,8 @@ config BR2_PACKAGE_EFL_BULLET
 
 config BR2_PACKAGE_EFL_EEZE
 	bool "Enable eeze (udev) support (recommended)"
-	depends on BR2_PACKAGE_HAS_UDEV # libudev
 	default y
+	depends on BR2_PACKAGE_HAS_UDEV # libudev
 	help
 	  Eeze is EFL's hardware abstraction layer on top of udev.
 	  Having it off will disable some hardware detection, such as
@@ -51,8 +51,8 @@ comment "eeze needs udev /dev management"
 
 config BR2_PACKAGE_EFL_FONTCONFIG
 	bool "Enable fontconfig support (recommended)"
-	select BR2_PACKAGE_FONTCONFIG
 	default y
+	select BR2_PACKAGE_FONTCONFIG
 	help
 	  If fontconfig is disabled, this is going to make general
 	  font searching not work, and only some very direct 'load
@@ -64,9 +64,9 @@ config BR2_PACKAGE_EFL_FONTCONFIG
 
 config BR2_PACKAGE_EFL_GSTREAMER1
 	bool "Enable gstreamer1 support (recommended)"
+	default y
 	select BR2_PACKAGE_GSTREAMER1
 	select BR2_PACKAGE_GST1_PLUGINS_BASE
-	default y
 	help
 	  If Gstreamer 1.x support is disabled, it will heavily limit
 	  your media support options and render some functionality as
@@ -74,8 +74,8 @@ config BR2_PACKAGE_EFL_GSTREAMER1
 
 config BR2_PACKAGE_EFL_LIBFRIBIDI
 	bool "Enable libfribidi support (recommended)"
-	select BR2_PACKAGE_LIBFRIBIDI
 	default y
+	select BR2_PACKAGE_LIBFRIBIDI
 	help
 	  Fribidi is used for handling right-to-left text (like
 	  Arabic, Hebrew, Farsi, Persian etc.) and is very likely not
@@ -87,8 +87,8 @@ config BR2_PACKAGE_EFL_LIBFRIBIDI
 
 config BR2_PACKAGE_EFL_LIBSNDFILE
 	bool "Enable libsndfile support (recommended)"
-	select BR2_PACKAGE_LIBSNDFILE
 	default y
+	select BR2_PACKAGE_LIBSNDFILE
 	help
 	  If you disabled audio support in Ecore, this is not tested
 	  and may create bugs for you due to it creating untested code
@@ -96,9 +96,9 @@ config BR2_PACKAGE_EFL_LIBSNDFILE
 
 config BR2_PACKAGE_EFL_PULSEAUDIO
 	bool "Enable pulseaudio support (recommended)"
+	default y
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pulseaudio -> json-c
 	select BR2_PACKAGE_PULSEAUDIO
-	default y
 	help
 	  The only audio output method supported by Ecore right now is
 	  via Pulseaudio. You have disabled that and likely have
@@ -110,12 +110,12 @@ config BR2_PACKAGE_EFL_PULSEAUDIO
 
 config BR2_PACKAGE_EFL_UTIL_LINUX_LIBMOUNT
 	bool "Enable libmount support (recommended)"
+	default y
 	depends on BR2_PACKAGE_EFL_EEZE
 	select BR2_PACKAGE_UTIL_LINUX
 	select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
 	# libblkid is part of required tools, see EFL's README.
 	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
-	default y
 	help
 	  Libmount is used heavily inside Eeze for support of removable
 	  devices etc... and disabling this will hurt support for
@@ -144,8 +144,8 @@ config BR2_PACKAGE_EFL_EOLIAN_CPP
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # Eolian needs C++11
 	help
 	  Eolian is an EO object parser and code generator.
-	  With this option enabled Eolian will handle automatic generation
-	  of EFL bindings for the C++11 language.
+	  With this option enabled Eolian will handle automatic
+	  generation of EFL bindings for the C++11 language.
 
 comment "Eolian needs host and target gcc >= 4.8"
 	depends on !BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
@@ -188,8 +188,8 @@ comment "Wayland support needs udev /dev management (eeze) and OpenGL ES w/ EGL,
 choice
 	bool "OpenGL support"
 	help
-	  libevas can be configured to use HW acceleration with OpenGL or
-	  OpenGL ES.
+	  libevas can be configured to use HW acceleration with OpenGL
+	  or OpenGL ES.
 
 config BR2_PACKAGE_EFL_OPENGL
 	bool "OpenGL"
@@ -219,10 +219,11 @@ config BR2_PACKAGE_EFL_ELPUT
 	select BR2_PACKAGE_LIBINPUT
 	select BR2_PACKAGE_LIBXKBCOMMON
 	help
-	  The elput library is an efl abstraction for the libinput library
-	  which can be used by various other subsystems (ecore_fb,
-	  ecore_drm, etc) to handle interfacing with libinput without
-	  having to duplicate the code in each subsystem.
+	  The elput library is an efl abstraction for the libinput
+	  library which can be used by various other subsystems
+	  (ecore_fb, ecore_drm, etc) to handle interfacing with
+	  libinput without having to duplicate the code in each
+	  subsystem.
 
 comment "Elput support needs udev /dev management (eeze)"
 	depends on !BR2_PACKAGE_EFL_EEZE
-- 
2.9.3

[Buildroot] [PATCH 2/5] package/efl: fix coding style problems preported by check-package script

[Thomas Petazzoni]

Hello,

On Fri, 14 Apr 2017 14:13:42 +0200, Romain Naour wrote:
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
>  package/efl/Config.in | 33 +++++++++++++++++----------------
>  1 file changed, 17 insertions(+), 16 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 3/5] package/efl: bump to version 1.19.0

[Romain Naour]

Systemd is now enabled by default and handle newly introduced
vnc-server and net-control options.

See the release announcement [1].

[1] https://sourceforge.net/p/enlightenment/mailman/message/35785467

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 package/efl/Config.in |  1 +
 package/efl/efl.hash  |  4 ++--
 package/efl/efl.mk    | 14 ++++++++++++--
 3 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/package/efl/Config.in b/package/efl/Config.in
index 0785ab8..371ed3f 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -179,6 +179,7 @@ config BR2_PACKAGE_EFL_WAYLAND
 	depends on BR2_PACKAGE_EFL_EEZE # efl drm
 	depends on BR2_PACKAGE_EFL_OPENGLES # OpenGL ES with EGL support only
 	select BR2_PACKAGE_EFL_DRM
+	select BR2_PACKAGE_WAYLAND_PROTOCOLS
 
 comment "Wayland support needs udev /dev management (eeze) and OpenGL ES w/ EGL, threads"
 	depends on BR2_PACKAGE_WAYLAND
diff --git a/package/efl/efl.hash b/package/efl/efl.hash
index 5d7a90d..39e0f93 100644
--- a/package/efl/efl.hash
+++ b/package/efl/efl.hash
@@ -1,2 +1,2 @@
-# From https://download.enlightenment.org/rel/libs/efl/efl-1.18.4.tar.xz.sha256
-sha256	39ebc07e37437d6ecdeb0f645783484e28a882b38f7e619ad12c2bf9b5548025	efl-1.18.4.tar.xz
+# From https://download.enlightenment.org/rel/libs/efl/efl-1.19.0.tar.xz.sha256
+sha256	a4e0341081778007db414f8cd4e3b77b9d5398870292cab67e6b40cc1445eadf	efl-1.19.0.tar.xz
diff --git a/package/efl/efl.mk b/package/efl/efl.mk
index 8772871..c71c084 100644
--- a/package/efl/efl.mk
+++ b/package/efl/efl.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-EFL_VERSION = 1.18.4
+EFL_VERSION = 1.19.0
 EFL_SOURCE = efl-$(EFL_VERSION).tar.xz
 EFL_SITE = http://download.enlightenment.org/rel/libs/efl
 EFL_LICENSE = BSD-2-Clause, LGPL-2.1+, GPL-2.0+
@@ -28,7 +28,9 @@ EFL_DEPENDENCIES = host-pkgconf host-efl host-luajit dbus freetype \
 # --disable-sdl: disable sdl2 support.
 # --disable-spectre: disable spectre image loader.
 # --disable-xinput22: disable X11 XInput v2.2+ support.
+# --disable-vnc-server: remove libvncserver dependency.
 # --enable-liblz4: use liblz4 from lz4 package.
+# --with-net-control=none: disable connman networkmanager.
 # --with-doxygen: disable doxygen documentation
 EFL_CONF_OPTS = \
 	--with-edje-cc=$(HOST_DIR)/usr/bin/edje_cc \
@@ -39,11 +41,13 @@ EFL_CONF_OPTS = \
 	--with-elua=$(HOST_DIR)/usr/bin/elua \
 	--with-eolian-gen=$(HOST_DIR)/usr/bin/eolian_gen \
 	--disable-image-loader-jp2k \
+	--with-net-control=none \
 	--disable-lua-old \
 	--disable-poppler \
 	--disable-sdl \
 	--disable-spectre \
 	--disable-xinput22 \
+	--disable-vnc-server \
 	--enable-liblz4 \
 	--with-doxygen=no
 
@@ -212,7 +216,7 @@ endif
 # which depends on wayland-client to build.
 # So enable gl_drm only when wayland support is selected.
 ifeq ($(BR2_PACKAGE_EFL_WAYLAND),y)
-EFL_DEPENDENCIES += wayland
+EFL_DEPENDENCIES += wayland wayland-protocols
 EFL_CONF_OPTS += --enable-wayland --enable-gl-drm
 else
 EFL_CONF_OPTS += --disable-wayland --disable-gl-drm
@@ -323,10 +327,13 @@ HOST_EFL_DEPENDENCIES = \
 # --disable-physics: remove Bullet dependency.
 # --disable-poppler: disable poppler image loader.
 # --disable-spectre: disable spectre image loader.
+# --disable-systemd: disable systemd dependency.
+# --disable-vnc-server: remove libvncserver dependency.
 # --enable-image-loader-gif=no: disable Gif dependency.
 # --enable-image-loader-tiff=no: disable Tiff dependency.
 # --with-crypto=none: remove dependencies on openssl or gnutls.
 # --with-doxygen: disable doxygen documentation
+# --with-net-control=none: disable connman networkmanager.
 # --with-x11=none: remove dependency on X.org.
 #   Yes I really know what I am doing.
 HOST_EFL_CONF_OPTS += \
@@ -343,7 +350,9 @@ HOST_EFL_CONF_OPTS += \
 	--disable-physics \
 	--disable-poppler \
 	--disable-spectre \
+	--disable-systemd \
 	--disable-xcf \
+	--disable-vnc-server \
 	--enable-image-loader-gif=no \
 	--enable-image-loader-jpeg=yes \
 	--enable-image-loader-png=yes \
@@ -351,6 +360,7 @@ HOST_EFL_CONF_OPTS += \
 	--with-crypto=none \
 	--with-doxygen=no \
 	--with-glib=yes \
+	--with-net-control=none \
 	--with-opengl=none \
 	--with-x11=none \
 	--enable-i-really-know-what-i-am-doing-and-that-this-will-probably-break-things-and-i-will-fix-them-myself-and-send-patches-abb
-- 
2.9.3

[Buildroot] [PATCH 3/5] package/efl: bump to version 1.19.0

[Thomas Petazzoni]

Hello,

On Fri, 14 Apr 2017 14:13:43 +0200, Romain Naour wrote:
> Systemd is now enabled by default and handle newly introduced
> vnc-server and net-control options.

This wording is quite confusing. You're saying "Systemd is not enabled
by default"... but all your package .mk file does is pass
--disable-systemd.

If I understood correctly, you want to say:

"This new version of the EFL enables systemd support by default. Since
we don't support systemd for EFL in Buildroot at the moment, we
therefore pass an additional --disable-systemd option".

Same thing when you say "handle newly introduced ... options".

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 3/5] package/efl: bump to version 1.19.0

[Romain Naour]

Hi Thomas,

Le 14/04/2017 ? 15:07, Thomas Petazzoni a ?crit :
> Hello,
> 
> On Fri, 14 Apr 2017 14:13:43 +0200, Romain Naour wrote:
>> Systemd is now enabled by default and handle newly introduced
>> vnc-server and net-control options.
> 
> This wording is quite confusing. You're saying "Systemd is not enabled
> by default"... but all your package .mk file does is pass
> --disable-systemd.
> 
> If I understood correctly, you want to say:
> 
> "This new version of the EFL enables systemd support by default.

Yes exactly, except that we currently support systemd for the target.

So we have to disable systemd for the host variant since we don't have
host-systemd and enable systemd support if the user build a target system using
systemd.

 Since
> we don't support systemd for EFL in Buildroot at the moment, we
> therefore pass an additional --disable-systemd option".
> 
> Same thing when you say "handle newly introduced ... options".

ok.

Do you want me to respin all the series or do you want to apply the two first
patches ?

Best regards,
Romain

> 
> Thanks,
> 
> Thomas
> 

[Buildroot] [PATCH 4/5] package/expedite: bump version for efl 1.19 support

[Romain Naour]

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 package/expedite/expedite.hash | 2 +-
 package/expedite/expedite.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/expedite/expedite.hash b/package/expedite/expedite.hash
index 85c4444..2d1db59 100644
--- a/package/expedite/expedite.hash
+++ b/package/expedite/expedite.hash
@@ -1,2 +1,2 @@
 # locally computed
-sha256 a8690a714c16d6b67e7fd6d70973e9805c3569a9131900b1feaf183220496831  expedite-ffa005ea3de26b4219f32c285cb1665bb1366163.tar.gz
+sha256 007e382861555f1023b679e21ff44122b0622c514ce8ef9d7c390b9ac1511009 expedite-0529ce56b6fb01e9651e76461e9608e15a040fb3.tar.gz
diff --git a/package/expedite/expedite.mk b/package/expedite/expedite.mk
index c18d32b..d49e87a 100644
--- a/package/expedite/expedite.mk
+++ b/package/expedite/expedite.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-EXPEDITE_VERSION = ffa005ea3de26b4219f32c285cb1665bb1366163
+EXPEDITE_VERSION = 0529ce56b6fb01e9651e76461e9608e15a040fb3
 EXPEDITE_SITE = http://git.enlightenment.org/tools/expedite.git
 EXPEDITE_SITE_METHOD = git
 EXPEDITE_LICENSE = BSD-2-Clause
-- 
2.9.3

[Buildroot] [PATCH 5/5] package/efl: add poppler imageloader optional dependency

[Romain Naour]

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 package/efl/efl.mk | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/package/efl/efl.mk b/package/efl/efl.mk
index c71c084..4008d30 100644
--- a/package/efl/efl.mk
+++ b/package/efl/efl.mk
@@ -24,7 +24,6 @@ EFL_DEPENDENCIES = host-pkgconf host-efl host-luajit dbus freetype \
 
 # Configure options:
 # --disable-lua-old: build elua for the target.
-# --disable-poppler: disable poppler image loader.
 # --disable-sdl: disable sdl2 support.
 # --disable-spectre: disable spectre image loader.
 # --disable-xinput22: disable X11 XInput v2.2+ support.
@@ -43,7 +42,6 @@ EFL_CONF_OPTS = \
 	--disable-image-loader-jp2k \
 	--with-net-control=none \
 	--disable-lua-old \
-	--disable-poppler \
 	--disable-sdl \
 	--disable-spectre \
 	--disable-xinput22 \
@@ -262,6 +260,13 @@ else
 EFL_CONF_OPTS += --disable-image-loader-webp
 endif
 
+ifeq ($(BR2_PACKAGE_POPPLER),y)
+EFL_DEPENDENCIES += poppler
+EFL_CONF_OPTS += --enable-poppler
+else
+EFL_CONF_OPTS += --disable-poppler
+endif
+
 ifeq ($(BR2_PACKAGE_EFL_LIBRAW),y)
 EFL_DEPENDENCIES += libraw
 EFL_CONF_OPTS += --enable-libraw
-- 
2.9.3

[Buildroot] [PATCH 1/5] package/efl: remove lefover disable-wayland option

[Thomas Petazzoni]

Hello,

On Fri, 14 Apr 2017 14:13:41 +0200, Romain Naour wrote:
> Wayland support was re-added by [1] but the --disable-wayland option
> was not removed from EFL_CONF_OPTS.
> 
> [1] f30eec41f95ed99909eb2c7590d83c12b9142df2
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
>  package/efl/efl.mk | 1 -
>  1 file changed, 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com