I2C device driver names

I2C device driver names

[Matt Spinler]

Hi,

As part of my work to generate a device tree from the machine readable 
workbook XML, I need to create I2C device entries, which have the 
compatible properties that need to be filled in.

The following parts are present in the system I'm trying to build, with 
firmware requirements to access them.  I took a stab at the names.  
Could someone doublecheck them and maybe comment on if a driver is 
missing, or maybe if some upcoming work is known that will include it?  
I didn't have much luck finding a lot of these in the 
Documentation/devicetree/bindings directories.

PMBus Power supplies:   ?

MAX31785 fan controller:  max,max31785

BMP280:  bosch,bmp280

TMP4523A temp sensor:  ti,tmp423

TMP275 temp sensor: ti,tmp275

pca9552 IO expander:  nxp,pca9552

UCD90160 power sequencer: ti,ucd90160

RX8900CE RTC:  epson,rx8900ce

24c64 EEPROM:  atmel,24c64

There are also a handful of regulators, but so far I haven't heard of 
any requirements to access them.

Thanks.

Re: I2C device driver names

[Joel Stanley]

On Fri, Oct 7, 2016 at 7:14 AM, Matt Spinler
<mspinler@linux.vnet.ibm.com> wrote:
> Hi,
>
> As part of my work to generate a device tree from the machine readable
> workbook XML, I need to create I2C device entries, which have the compatible
> properties that need to be filled in.
>
> The following parts are present in the system I'm trying to build, with
> firmware requirements to access them.  I took a stab at the names.  Could
> someone doublecheck them and maybe comment on if a driver is missing, or
> maybe if some upcoming work is known that will include it?  I didn't have
> much luck finding a lot of these in the Documentation/devicetree/bindings
> directories.

If they're not in the kernel tree it could mean there is not a driver
for them, or that they are supported as part of the trivial device
bindings.

>
> PMBus Power supplies:   ?
>
> MAX31785 fan controller:  max,max31785

Doesn't appear to be an upstream driver. Please open a ticket.

>
> BMP280:  bosch,bmp280

Supported by the iio bmp280 driver.

>
> TMP4523A temp sensor:  ti,tmp423

Supported by the tmp421 hwmon driver.

>
> TMP275 temp sensor: ti,tmp275

Documentation/devicetree/bindings/i2c/trivial-devices.txt

Supported by the lm75 hwmon driver.

> pca9552 IO expander:  nxp,pca9552

This appears to be a LED driver?

There's a LED device driver called leds-pca955x.

>
> UCD90160 power sequencer: ti,ucd90160

A kernel driver called ucd9000 appears to support similar chips.
Please open a ticket.

>
> RX8900CE RTC:  epson,rx8900ce

No upstream driver. Please open a ticket.

>
> 24c64 EEPROM:  atmel,24c64

LGTM.

Cheers,

Joel

>
> There are also a handful of regulators, but so far I haven't heard of any
> requirements to access them.
>
> Thanks.
>
> _______________________________________________
> openbmc mailing list
> openbmc@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc

Re: I2C device driver names

[Milton Miller II]

[-- Attachment #1: Type: text/html, Size: 3033 bytes --]

Re: I2C device driver names

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

On Fri, Oct 07, 2016 at 10:42:24AM +1100, Joel Stanley wrote:
> > PMBus Power supplies:   ?
> >
> > MAX31785 fan controller:  max,max31785
> 
> Doesn't appear to be an upstream driver. Please open a ticket.

Timothy @ Raptor wrote a driver for this recently, didn't he?  Joel, I
thought you were going to merge it in for the time being.  Timothy
mentioned that there was some upstream work going on in that subsystem
that was preventing it from be merged in the current state but that the
subsystem owner was likely going to take it on.

https://patchwork.ozlabs.org/patch/672045/

-- 
Patrick Williams

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: I2C device driver names

[Matt Spinler]

[-- Attachment #1: Type: text/plain, Size: 2734 bytes --]

Thanks.  I opened the following issues:

Power supply:  https://github.com/openbmc/openbmc/issues/651

MAX31785: https://github.com/openbmc/openbmc/issues/652

UCD90160: https://github.com/openbmc/openbmc/issues/653

RX8900CE: https://github.com/openbmc/openbmc/issues/654



On 10/6/2016 7:24 PM, Milton Miller II wrote:
>
> On 10/06/2016 about 06:43PM somewhere, Joel Stanley <joel@jms.id.au 
> <mailto:joel@jms.id.au>> wrote:
> >
> >On Fri, Oct 7, 2016 at 7:14 AM, Matt Spinler
> ><mspinler@linux.vnet.ibm.com <mailto:mspinler@linux.vnet.ibm.com>> wrote:
> >> Hi,
> >>
> >> As part of my work to generate a device tree from the machine
> >readable
> >> workbook XML, I need to create I2C device entries, which have the
> >compatible
> >> properties that need to be filled in.
> >>
> >> The following parts are present in the system I'm trying to build,
> >with
> >> firmware requirements to access them. I took a stab at the names.
> >Could
> >> someone doublecheck them and maybe comment on if a driver is
> >missing, or
> >> maybe if some upcoming work is known that will include it? I
> >didn't have
> >> much luck finding a lot of these in the
> >Documentation/devicetree/bindings
> >> directories.
>
> Unique to the i2c subsystem, i2c devices will also match when
> the vendor is different but the chip name portion matches.
>
> >
> >If they're not in the kernel tree it could mean there is not a driver
> >for them, or that they are supported as part of the trivial device
> >bindings.
> >
> >>
> >> PMBus Power supplies: ?
> >>
> >> MAX31785 fan controller: max,max31785
>
> Maxim for the vendor? see
> Documentation/devicetree/bindings/vendor-prefixes.txt
>
> >
> >Doesn't appear to be an upstream driver. Please open a ticket.
> >
> >>
> >> BMP280: bosch,bmp280
> >
> >Supported by the iio bmp280 driver.
> >
> >>
> >> TMP4523A temp sensor: ti,tmp423
> >
> >Supported by the tmp421 hwmon driver.
> >
> >>
> >> TMP275 temp sensor: ti,tmp275
> >
> >Documentation/devicetree/bindings/i2c/trivial-devices.txt
> >
> >Supported by the lm75 hwmon driver.
> >
> >> pca9552 IO expander: nxp,pca9552
> >
> >This appears to be a LED driver?
> >
> >There's a LED device driver called leds-pca955x.
>
> There is also a gpio driver for pca955[4567] in pca953x.c.
>
> >
> >>
> >> UCD90160 power sequencer: ti,ucd90160
> >
> >A kernel driver called ucd9000 appears to support similar chips.
> >Please open a ticket.
> >
> >>
> >> RX8900CE RTC: epson,rx8900ce
> >
> >No upstream driver. Please open a ticket.
> >
> >>
> >> 24c64 EEPROM: atmel,24c64
> >
> >LGTM.
> >
> >Cheers,
> >
> >Joel
> >
> >>
> >> There are also a handful of regulators, but so far I haven't heard
> >of any
> >> requirements to access them.
> >>
> >> Thanks.
>
>
>


[-- Attachment #2: Type: text/html, Size: 5210 bytes --]

Re: I2C device driver names

[Joel Stanley]

On Fri, Oct 7, 2016 at 12:51 PM, Patrick Williams <patrick@stwcx.xyz> wrote:
> On Fri, Oct 07, 2016 at 10:42:24AM +1100, Joel Stanley wrote:
>> > PMBus Power supplies:   ?
>> >
>> > MAX31785 fan controller:  max,max31785
>>
>> Doesn't appear to be an upstream driver. Please open a ticket.
>
> Timothy @ Raptor wrote a driver for this recently, didn't he?  Joel, I
> thought you were going to merge it in for the time being.  Timothy

Yeah. I did ask that he spit out the maintainers part of that patch
before we applied it.

Timothy, are you able to make that change?


> mentioned that there was some upstream work going on in that subsystem
> that was preventing it from be merged in the current state but that the
> subsystem owner was likely going to take it on.

Timothy, do you have any update on the rewrite?

Cheers,

Joel

>
> https://patchwork.ozlabs.org/patch/672045/
>
> --
> Patrick Williams

Re: I2C device driver names

[Timothy Pearson]

On 10/09/2016 08:57 PM, Joel Stanley wrote:
> On Fri, Oct 7, 2016 at 12:51 PM, Patrick Williams <patrick@stwcx.xyz> wrote:
>> On Fri, Oct 07, 2016 at 10:42:24AM +1100, Joel Stanley wrote:
>>>> PMBus Power supplies:   ?
>>>>
>>>> MAX31785 fan controller:  max,max31785
>>>
>>> Doesn't appear to be an upstream driver. Please open a ticket.
>>
>> Timothy @ Raptor wrote a driver for this recently, didn't he?  Joel, I
>> thought you were going to merge it in for the time being.  Timothy
> 
> Yeah. I did ask that he spit out the maintainers part of that patch
> before we applied it.
> 
> Timothy, are you able to make that change?

No problem.  Updated version sent to the OpenBMC mailing list.

> 
>> mentioned that there was some upstream work going on in that subsystem
>> that was preventing it from be merged in the current state but that the
>> subsystem owner was likely going to take it on.
> 
> Timothy, do you have any update on the rewrite?

Not at this time.  I've requested a status update from the hwmon
maintainer that was working on it.

Thanks!

-- 
Timothy Pearson
Raptor Engineering
+1 (415) 727-8645 (direct line)
+1 (512) 690-0200 (switchboard)
https://www.raptorengineering.com

Re: I2C device driver names

[Joel Stanley]

On Wed, Oct 12, 2016 at 1:41 AM, Timothy Pearson
<tpearson@raptorengineering.com> wrote:
>> Yeah. I did ask that he spit out the maintainers part of that patch
>> before we applied it.
>>
>> Timothy, are you able to make that change?
>
> No problem.  Updated version sent to the OpenBMC mailing list.

Thanks. I'll take a close look and add it to our tree today.


>> Timothy, do you have any update on the rewrite?
>
> Not at this time.  I've requested a status update from the hwmon
> maintainer that was working on it.

Cool. If you could, please me on future correspondence. I'd like to
keep a track of how it goes, and we might be able to offer some help
if the hwmon guys don't have time.

Cheers,

Joel

Re: I2C device driver names

[Timothy Pearson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/11/2016 06:11 PM, Joel Stanley wrote:
> On Wed, Oct 12, 2016 at 1:41 AM, Timothy Pearson
> <tpearson@raptorengineering.com> wrote:
>>> Yeah. I did ask that he spit out the maintainers part of that patch
>>> before we applied it.
>>>
>>> Timothy, are you able to make that change?
>>
>> No problem.  Updated version sent to the OpenBMC mailing list.
> 
> Thanks. I'll take a close look and add it to our tree today.

Sounds good, thanks!

> 
>>> Timothy, do you have any update on the rewrite?
>>
>> Not at this time.  I've requested a status update from the hwmon
>> maintainer that was working on it.
> 
> Cool. If you could, please me on future correspondence. I'd like to
> keep a track of how it goes, and we might be able to offer some help
> if the hwmon guys don't have time.

I don't follow hwmon too closely, but if I hear anything I'll let you know!

- -- 
Timothy Pearson
Raptor Engineering
+1 (415) 727-8645 (direct line)
+1 (512) 690-0200 (switchboard)
https://www.raptorengineering.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJX/ldEAAoJEK+E3vEXDOFbVJkH/iUBsjkWPw4GZGfFU/6+b8Mx
qOquV1/kRXsbV3O/hjJSAbXBjRlfv7S/jCFMmnsxoMoAYzhG0rRANXBMycE9jkSi
raD2VZs48vgbUGwihrB4FlmuUHcKg8i1QkRNe70hYF0dusasKmNYeDJbt+mKRT4C
KbHAbjh9TOj52SsDz+uFmEa+iSmuOvZn4nGkMXmXRT9TuPwj4Wu/TsUeRo0CbubJ
uQCisOyqGQhdZowbJWxgWemr32u9lpXxa3b8OpMI7z3hPT2iB0E6/B28gpg9Hd3u
8XeY6co7ei+rMS89JqooXGZbV0V1A9E74e/vXAe9MLkICFfTw1Mo45nyXrBtCsw=
=CDeR
-----END PGP SIGNATURE-----

Re: I2C device driver names

[Matt Spinler]

[-- Attachment #1: Type: text/plain, Size: 3641 bytes --]

Hello,

I am taking a closer look at how to model the pca9552 LED driver in the 
machine readable workbook and device tree.   In the system, it will be 
used both for LEDs and for general purpose GPIOs.

I see there is both a pca955x driver and a pca963x driver.  The 955x one 
has no documentation in the bindings directory.  The 963x one has 
documentation, but doesn't mention anything about how to handle GPIOs, 
nor am I sure that a 9552 is register compatible with the 16 LED 963x 
chip anyway.

Does anyone here have any experience describing this chip in the device 
tree?

Thanks.

On 10/7/2016 3:08 PM, Matt Spinler wrote:
>
> Thanks.  I opened the following issues:
>
> Power supply: https://github.com/openbmc/openbmc/issues/651
>
> MAX31785: https://github.com/openbmc/openbmc/issues/652
>
> UCD90160: https://github.com/openbmc/openbmc/issues/653
>
> RX8900CE: https://github.com/openbmc/openbmc/issues/654
>
>
>
> On 10/6/2016 7:24 PM, Milton Miller II wrote:
>>
>> On 10/06/2016 about 06:43PM somewhere, Joel Stanley <joel@jms.id.au 
>> <mailto:joel@jms.id.au>> wrote:
>> >
>> >On Fri, Oct 7, 2016 at 7:14 AM, Matt Spinler
>> ><mspinler@linux.vnet.ibm.com <mailto:mspinler@linux.vnet.ibm.com>> 
>> wrote:
>> >> Hi,
>> >>
>> >> As part of my work to generate a device tree from the machine
>> >readable
>> >> workbook XML, I need to create I2C device entries, which have the
>> >compatible
>> >> properties that need to be filled in.
>> >>
>> >> The following parts are present in the system I'm trying to build,
>> >with
>> >> firmware requirements to access them. I took a stab at the names.
>> >Could
>> >> someone doublecheck them and maybe comment on if a driver is
>> >missing, or
>> >> maybe if some upcoming work is known that will include it? I
>> >didn't have
>> >> much luck finding a lot of these in the
>> >Documentation/devicetree/bindings
>> >> directories.
>>
>> Unique to the i2c subsystem, i2c devices will also match when
>> the vendor is different but the chip name portion matches.
>>
>> >
>> >If they're not in the kernel tree it could mean there is not a driver
>> >for them, or that they are supported as part of the trivial device
>> >bindings.
>> >
>> >>
>> >> PMBus Power supplies: ?
>> >>
>> >> MAX31785 fan controller: max,max31785
>>
>> Maxim for the vendor? see
>> Documentation/devicetree/bindings/vendor-prefixes.txt
>>
>> >
>> >Doesn't appear to be an upstream driver. Please open a ticket.
>> >
>> >>
>> >> BMP280: bosch,bmp280
>> >
>> >Supported by the iio bmp280 driver.
>> >
>> >>
>> >> TMP4523A temp sensor: ti,tmp423
>> >
>> >Supported by the tmp421 hwmon driver.
>> >
>> >>
>> >> TMP275 temp sensor: ti,tmp275
>> >
>> >Documentation/devicetree/bindings/i2c/trivial-devices.txt
>> >
>> >Supported by the lm75 hwmon driver.
>> >
>> >> pca9552 IO expander: nxp,pca9552
>> >
>> >This appears to be a LED driver?
>> >
>> >There's a LED device driver called leds-pca955x.
>>
>> There is also a gpio driver for pca955[4567] in pca953x.c.
>>
>> >
>> >>
>> >> UCD90160 power sequencer: ti,ucd90160
>> >
>> >A kernel driver called ucd9000 appears to support similar chips.
>> >Please open a ticket.
>> >
>> >>
>> >> RX8900CE RTC: epson,rx8900ce
>> >
>> >No upstream driver. Please open a ticket.
>> >
>> >>
>> >> 24c64 EEPROM: atmel,24c64
>> >
>> >LGTM.
>> >
>> >Cheers,
>> >
>> >Joel
>> >
>> >>
>> >> There are also a handful of regulators, but so far I haven't heard
>> >of any
>> >> requirements to access them.
>> >>
>> >> Thanks.
>>
>>
>>
>
>
>
> _______________________________________________
> openbmc mailing list
> openbmc@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc


[-- Attachment #2: Type: text/html, Size: 7079 bytes --]