All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vesa Jääskeläinen" <chaac@nic.fi>
To: grub-devel@gnu.org
Subject: Re: [PATCH] GSoC #10 new font engine (UTF-8 support+bugfix)
Date: Sat, 06 Dec 2008 22:18:14 +0200	[thread overview]
Message-ID: <493ADE06.7080001@nic.fi> (raw)
In-Reply-To: <20081030205736.7e080a5e@gibibit.com>

Colin D Bennett wrote:
> Update: 
> 
> I fixed an error pointed out to me by Y.Volta: 
> In grub_font_get(), if no fonts are loaded, a null pointer is
> dereferenced.  This is fixed in the attached patch.
> 
> The grub_font_get() function now returns a dummy font object (a
> statically allocated font object with no characters) so that callers of
> grub_font_get() can be assured that the return value will never be
> NULL.  If no fonts are loaded, then the "unknown glyph" will be used
> for all characters, but it will be safe.

Hi Colin,

I applied this patch against SVN today and tried it out. And noticed
that gfxterm gets a bit "broken" after this. Was this the thing that I
promised to look at :) ? Or was my merge just incomplete?

Videotest was fine however. (or how fine it can be with just unifont.bdf)

After:
loadfont /boot/grub/unifont.pf2

lsfonts gives:
Loaded fonts:
Unknown -1

Is this expected?

Thanks,
Vesa Jääskeläinen



  parent reply	other threads:[~2008-12-06 20:18 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-01 16:27 [PATCH] GSoC #10 new font engine Colin D Bennett
2008-10-05  4:46 ` [PATCH] GSoC #10 new font engine (vs r1885) Colin D Bennett
2008-10-05  8:50   ` Vesa Jääskeläinen
2008-10-30 19:11     ` [PATCH] GSoC #10 new font engine (UTF-8 support) Colin D Bennett
2008-10-31  3:57       ` [PATCH] GSoC #10 new font engine (UTF-8 support+bugfix) Colin D Bennett
2008-10-31 18:31         ` Matt Sturgeon
2008-10-31 19:50           ` Colin D Bennett
2008-11-04 20:19             ` Vesa Jääskeläinen
2008-11-04 20:31               ` Robert Millan
2008-11-04 20:52                 ` Colin D Bennett
2008-12-06 20:18         ` Vesa Jääskeläinen [this message]
2008-12-22 17:14           ` Colin D Bennett
2008-12-23 18:39             ` Vesa Jääskeläinen
2008-12-24  1:17               ` Colin D Bennett
2008-12-28  0:34                 ` Vesa Jääskeläinen
2008-12-28  0:35                   ` Vesa Jääskeläinen
2009-01-02 15:26                     ` Vesa Jääskeläinen
2008-12-28  8:44                   ` Arthur Marsh
2009-01-02 22:44                   ` Jerone Young
2009-01-02 22:57                     ` Vesa Jääskeläinen
2009-01-03  4:52                       ` Bean
2009-01-03  7:30                         ` Colin D Bennett
2009-01-03 16:45                     ` Colin D Bennett
2009-01-03 16:54                       ` Vesa Jääskeläinen
2009-01-05  5:05                       ` Jerone Young
2009-01-05  7:59                         ` Colin D Bennett
2009-01-05 13:29                           ` Jerone Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=493ADE06.7080001@nic.fi \
    --to=chaac@nic.fi \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.