* [U-Boot] init FEC @ MPC5200
@ 2008-12-10 10:41 Andre Schwarz
2008-12-10 18:12 ` Ben Warren
0 siblings, 1 reply; 3+ messages in thread
From: Andre Schwarz @ 2008-12-10 10:41 UTC (permalink / raw)
To: u-boot
Ben,
after cloning the latest u-boot git I can see that you've added this
inside the mvBC-P board setup :
int board_eth_init(bd_t *bis)
{
cpu_eth_init(bis); /* Built in FEC comes first */
return pci_eth_init(bis);
}
Are you aware that there's no PHY connected and the ETH-Pins are used
otherwise ?
CONFIG_MPC5xxx_FEC is _not_ defined.
Can you tell me where "cpu_eth_init(bis)" is actually pointing to ?
regards,
Andr?
MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler - Registergericht: Amtsgericht Stuttgart, HRB 271090
Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] init FEC @ MPC5200
2008-12-10 10:41 [U-Boot] init FEC @ MPC5200 Andre Schwarz
@ 2008-12-10 18:12 ` Ben Warren
2008-12-10 23:34 ` André Schwarz
0 siblings, 1 reply; 3+ messages in thread
From: Ben Warren @ 2008-12-10 18:12 UTC (permalink / raw)
To: u-boot
Andre Schwarz wrote:
> Ben,
>
> after cloning the latest u-boot git I can see that you've added this
> inside the mvBC-P board setup :
>
> int board_eth_init(bd_t *bis)
> {
> cpu_eth_init(bis); /* Built in FEC comes first */
> return pci_eth_init(bis);
> }
>
> Are you aware that there's no PHY connected and the ETH-Pins are used
> otherwise ?
>
> CONFIG_MPC5xxx_FEC is _not_ defined.
>
>
> Can you tell me where "cpu_eth_init(bis)" is actually pointing to ?
>
>
>
Since CONFIG_MPC5xxx_FEC isn't defined, the default weak cpu_eth_init()
function in net/eth.c should get called, which does essentially
nothing. I assumed that since you #undef'd the FEC controller in your
board header file (instead of leaving it out completely), that it was
perhaps optional, and so kept the call to cpu_eth_init() as shown above.
Are you seeing a problem with this?
> regards,
> Andr?
>
> MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler - Registergericht: Amtsgericht Stuttgart, HRB 271090
> Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
>
regards,
Ben
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] init FEC @ MPC5200
2008-12-10 18:12 ` Ben Warren
@ 2008-12-10 23:34 ` André Schwarz
0 siblings, 0 replies; 3+ messages in thread
From: André Schwarz @ 2008-12-10 23:34 UTC (permalink / raw)
To: u-boot
Ben Warren wrote:
> Andre Schwarz wrote:
>> Ben,
>>
>> after cloning the latest u-boot git I can see that you've added this
>> inside the mvBC-P board setup :
>>
>> int board_eth_init(bd_t *bis)
>> {
>> cpu_eth_init(bis); /* Built in FEC comes first */
>> return pci_eth_init(bis);
>> }
>>
>> Are you aware that there's no PHY connected and the ETH-Pins are used
>> otherwise ?
>>
>> CONFIG_MPC5xxx_FEC is _not_ defined.
>>
>>
>> Can you tell me where "cpu_eth_init(bis)" is actually pointing to ?
>>
>>
>>
> Since CONFIG_MPC5xxx_FEC isn't defined, the default weak
> cpu_eth_init() function in net/eth.c should get called, which does
> essentially nothing. I assumed that since you #undef'd the FEC
> controller in your board header file (instead of leaving it out
> completely), that it was perhaps optional, and so kept the call to
> cpu_eth_init() as shown above.
ok - missed that.
>
> Are you seeing a problem with this?
no - just wanted to know.
Thanks for the hint,
Andr?
>> regards,
>> Andr?
>>
>> MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler -
>> Registergericht: Amtsgericht Stuttgart, HRB 271090
>> Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
>>
> regards,
> Ben
MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler - Registergericht: Amtsgericht Stuttgart, HRB 271090
Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-12-10 23:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-12-10 10:41 [U-Boot] init FEC @ MPC5200 Andre Schwarz
2008-12-10 18:12 ` Ben Warren
2008-12-10 23:34 ` André Schwarz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.