[PATCH] iovmm: IVA2 MMU range is from 0x11000000 to 0xFFFFFFFF

[PATCH] iovmm: IVA2 MMU range is from 0x11000000 to 0xFFFFFFFF

[Fernando Guzman Lugo]

IV2 MMU capable addresses start from 0x11000000

Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com>
---
 arch/arm/plat-omap/iovmm.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c
index 75965a1..c0344f4 100644
--- a/arch/arm/plat-omap/iovmm.c
+++ b/arch/arm/plat-omap/iovmm.c
@@ -286,7 +286,12 @@ static struct iovm_struct *alloc_iovm_area(struct iommu *obj, u32 da,
 		/*
 		 * Reserve the first page for NULL
 		 */
-		start = PAGE_SIZE;
+		if (!strcmp(obj->name, "iva2"))
+			/* IVA2 MMU control starts from 0x11000000 */
+			start = 0x11000000;
+		else
+			start = PAGE_SIZE;
+
 		if (flags & IOVMF_LINEAR)
 			alignement = iopgsz_max(bytes);
 		start = roundup(start, alignement);
-- 
1.6.3.3

[PATCH] iovmm: IVA2 MMU range is from 0x11000000 to 0xFFFFFFFF

[Fernando Guzman Lugo]

IV2 MMU capable addresses start from 0x11000000

Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com>
---
 arch/arm/plat-omap/iovmm.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c
index 75965a1..c0344f4 100644
--- a/arch/arm/plat-omap/iovmm.c
+++ b/arch/arm/plat-omap/iovmm.c
@@ -286,7 +286,12 @@ static struct iovm_struct *alloc_iovm_area(struct iommu *obj, u32 da,
 		/*
 		 * Reserve the first page for NULL
 		 */
-		start = PAGE_SIZE;
+		if (!strcmp(obj->name, "iva2"))
+			/* IVA2 MMU control starts from 0x11000000 */
+			start = 0x11000000;
+		else
+			start = PAGE_SIZE;
+
 		if (flags & IOVMF_LINEAR)
 			alignement = iopgsz_max(bytes);
 		start = roundup(start, alignement);
-- 
1.6.3.3

Re: [PATCH] iovmm: IVA2 MMU range is from 0x11000000 to 0xFFFFFFFF

[Hiroshi DOYU]

From: ext Fernando Guzman Lugo <x0095840@ti.com>
Subject: [PATCH] iovmm: IVA2 MMU range is from 0x11000000 to 0xFFFFFFFF
Date: Thu, 7 Oct 2010 20:43:41 +0200

> IV2 MMU capable addresses start from 0x11000000

Wouldn't it be better to add an general API to configure the valid
'da' range in advance?

I don't think that it's a good idea to introduce the iommu
instance("iva2:iommu") specific code here.

RE: [PATCH] iovmm: IVA2 MMU range is from 0x11000000 to 0xFFFFFFFF

[Guzman Lugo, Fernando]

Hi Hiroshi, 

> -----Original Message-----
> From: Hiroshi DOYU [mailto:Hiroshi.DOYU@nokia.com] 
> Sent: Thursday, October 07, 2010 2:14 PM
> To: Guzman Lugo, Fernando
> Cc: felipe.contreras@nokia.com; ameya.palande@nokia.com; 
> david.cohen@nokia.com; linux-kernel@vger.kernel.org; 
> andy.shevchenko@gmail.com; linux-omap@vger.kernel.org
> Subject: Re: [PATCH] iovmm: IVA2 MMU range is from 0x11000000 
> to 0xFFFFFFFF
> 
> From: ext Fernando Guzman Lugo <x0095840@ti.com>
> Subject: [PATCH] iovmm: IVA2 MMU range is from 0x11000000 to 
> 0xFFFFFFFF
> Date: Thu, 7 Oct 2010 20:43:41 +0200
> 
> > IV2 MMU capable addresses start from 0x11000000
> 
> Wouldn't it be better to add an general API to configure the 
> valid 'da' range in advance?

Yes I was thinking in passing start and end range in iommu_get
(because don't need to change rage, it is needed only one time)
And create new elements in iommu struct for start and end address
 or maybe defining the range statically when the structures are
Fillup for omapxxx. But I tought I was break other users of iommu
Like omap4 and isp and it would be easier to accept an small patch.

But I am agree with you it would be better to make it configurable.
As tidspbridge iommu migratio seems to be target to 37 I can 
Make a new patch and resend.

Please let me know if you have some suggestions.

Regards,
Fernando.

> 
> I don't think that it's a good idea to introduce the iommu
> instance("iva2:iommu") specific code here.
> 

RE: [PATCH] iovmm: IVA2 MMU range is from 0x11000000 to 0xFFFFFFFF

[Guzman Lugo, Fernando]

 

> -----Original Message-----
> From: Hiroshi DOYU [mailto:Hiroshi.DOYU@nokia.com] 
> Sent: Thursday, October 07, 2010 2:14 PM
> To: Guzman Lugo, Fernando
> Cc: felipe.contreras@nokia.com; ameya.palande@nokia.com; 
> david.cohen@nokia.com; linux-kernel@vger.kernel.org; 
> andy.shevchenko@gmail.com; linux-omap@vger.kernel.org
> Subject: Re: [PATCH] iovmm: IVA2 MMU range is from 0x11000000 
> to 0xFFFFFFFF
> 
> From: ext Fernando Guzman Lugo <x0095840@ti.com>
> Subject: [PATCH] iovmm: IVA2 MMU range is from 0x11000000 to 
> 0xFFFFFFFF
> Date: Thu, 7 Oct 2010 20:43:41 +0200
> 
> > IV2 MMU capable addresses start from 0x11000000
> 
> Wouldn't it be better to add an general API to configure the 
> valid 'da' range in advance?
> 
> I don't think that it's a good idea to introduce the iommu
> instance("iva2:iommu") specific code here.

Please discard this patch. I will send a one base on comments
Along with the other iommu fixes serie.

Regards,
Fernando.

>