* [PATCH] lz4: actually install things
@ 2014-01-23 9:06 Koen Kooi
2014-01-23 11:31 ` Otavio Salvador
0 siblings, 1 reply; 10+ messages in thread
From: Koen Kooi @ 2014-01-23 9:06 UTC (permalink / raw)
To: openembedded-core; +Cc: Koen Kooi
This failure was masked by having lz4 installed on the host system :(
Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
---
meta/recipes-support/lz4/lz4_svn.bb | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-support/lz4/lz4_svn.bb b/meta/recipes-support/lz4/lz4_svn.bb
index 41464e2..a760313 100644
--- a/meta/recipes-support/lz4/lz4_svn.bb
+++ b/meta/recipes-support/lz4/lz4_svn.bb
@@ -12,6 +12,10 @@ SRC_URI = "svn://lz4.googlecode.com/svn/;module=trunk;protocol=http"
S = "${WORKDIR}/trunk"
-EXTRA_OEMAKE = "PREFIX=${prefix} CC=${TARGET_PREFIX}gcc DESTDIR=${D}"
+EXTRA_OEMAKE = "PREFIX=${prefix} CC=${TARGET_PREFIX}gcc DESTDIR=${D} LIBDIR=${libdir} INCLUDEDIR=${includedir}"
+
+do_install() {
+ oe_runmake install
+}
BBCLASSEXTEND += "native nativesdk"
--
1.8.4.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] lz4: actually install things
2014-01-23 9:06 [PATCH] lz4: actually install things Koen Kooi
@ 2014-01-23 11:31 ` Otavio Salvador
2014-01-23 11:35 ` Koen Kooi
0 siblings, 1 reply; 10+ messages in thread
From: Otavio Salvador @ 2014-01-23 11:31 UTC (permalink / raw)
To: Koen Kooi; +Cc: Patches and discussions about the oe-core layer
On Thu, Jan 23, 2014 at 7:06 AM, Koen Kooi <koen.kooi@linaro.org> wrote:
> This failure was masked by having lz4 installed on the host system :(
>
> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
Couldn't it inherit autotools?
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] lz4: actually install things
2014-01-23 11:31 ` Otavio Salvador
@ 2014-01-23 11:35 ` Koen Kooi
2014-01-23 11:36 ` Otavio Salvador
0 siblings, 1 reply; 10+ messages in thread
From: Koen Kooi @ 2014-01-23 11:35 UTC (permalink / raw)
To: Otavio Salvador
Cc: Koen Kooi, Patches and discussions about the oe-core layer
Op 23 jan. 2014, om 12:31 heeft Otavio Salvador <otavio@ossystems.com.br> het volgende geschreven:
> On Thu, Jan 23, 2014 at 7:06 AM, Koen Kooi <koen.kooi@linaro.org> wrote:
>> This failure was masked by having lz4 installed on the host system :(
>>
>> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
>
> Couldn't it inherit autotools?
It's a handcrafted Makefile, not autotools :(
regards,
Koen
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] lz4: actually install things
2014-01-23 11:35 ` Koen Kooi
@ 2014-01-23 11:36 ` Otavio Salvador
2014-01-23 11:40 ` Koen Kooi
2014-01-23 11:46 ` Paul Eggleton
0 siblings, 2 replies; 10+ messages in thread
From: Otavio Salvador @ 2014-01-23 11:36 UTC (permalink / raw)
To: Koen Kooi; +Cc: Koen Kooi, Patches and discussions about the oe-core layer
On Thu, Jan 23, 2014 at 9:35 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>
> Op 23 jan. 2014, om 12:31 heeft Otavio Salvador <otavio@ossystems.com.br> het volgende geschreven:
>
>> On Thu, Jan 23, 2014 at 7:06 AM, Koen Kooi <koen.kooi@linaro.org> wrote:
>>> This failure was masked by having lz4 installed on the host system :(
>>>
>>> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
>>
>> Couldn't it inherit autotools?
>
> It's a handcrafted Makefile, not autotools :(
No problem, it works as well.
The do_configure checks for configure.ac/configure.in and it avoid you
to handcraft do_install and like.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] lz4: actually install things
2014-01-23 11:36 ` Otavio Salvador
@ 2014-01-23 11:40 ` Koen Kooi
2014-01-23 11:47 ` Burton, Ross
2014-01-23 11:46 ` Paul Eggleton
1 sibling, 1 reply; 10+ messages in thread
From: Koen Kooi @ 2014-01-23 11:40 UTC (permalink / raw)
To: Otavio Salvador
Cc: Koen Kooi, Patches and discussions about the oe-core layer
Op 23 jan. 2014, om 12:36 heeft Otavio Salvador <otavio@ossystems.com.br> het volgende geschreven:
> On Thu, Jan 23, 2014 at 9:35 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>>
>> Op 23 jan. 2014, om 12:31 heeft Otavio Salvador <otavio@ossystems.com.br> het volgende geschreven:
>>
>>> On Thu, Jan 23, 2014 at 7:06 AM, Koen Kooi <koen.kooi@linaro.org> wrote:
>>>> This failure was masked by having lz4 installed on the host system :(
>>>>
>>>> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
>>>
>>> Couldn't it inherit autotools?
>>
>> It's a handcrafted Makefile, not autotools :(
>
> No problem, it works as well.
>
> The do_configure checks for configure.ac/configure.in and it avoid you
> to handcraft do_install and like.
The recipes that used such a workaround have all been changed to remote autotools.bbclass over the years, so I'm not sure how encouraged it is.
regards,
Koen
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] lz4: actually install things
2014-01-23 11:36 ` Otavio Salvador
2014-01-23 11:40 ` Koen Kooi
@ 2014-01-23 11:46 ` Paul Eggleton
1 sibling, 0 replies; 10+ messages in thread
From: Paul Eggleton @ 2014-01-23 11:46 UTC (permalink / raw)
To: Otavio Salvador; +Cc: Koen Kooi, Koen Kooi, openembedded-core
On Thursday 23 January 2014 09:36:09 Otavio Salvador wrote:
> On Thu, Jan 23, 2014 at 9:35 AM, Koen Kooi <koen@dominion.thruhere.net>
> wrote:
> > Op 23 jan. 2014, om 12:31 heeft Otavio Salvador <otavio@ossystems.com.br>
> het volgende geschreven:
> >> On Thu, Jan 23, 2014 at 7:06 AM, Koen Kooi <koen.kooi@linaro.org> wrote:
> >>> This failure was masked by having lz4 installed on the host system :(
> >>>
> >>> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
> >>
> >> Couldn't it inherit autotools?
> >
> > It's a handcrafted Makefile, not autotools :(
>
> No problem, it works as well.
>
> The do_configure checks for configure.ac/configure.in and it avoid you
> to handcraft do_install and like.
Do _not_ inherit autotools if the software being built doesn't use
autoconf/automake. Whilst it may work now in some situations, there's
absolutely no guarantee it won't break in the future. autotools.bbclass needs
to be able to assume it's actually being used with autotools.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] lz4: actually install things
2014-01-23 11:40 ` Koen Kooi
@ 2014-01-23 11:47 ` Burton, Ross
2014-01-23 11:49 ` Otavio Salvador
0 siblings, 1 reply; 10+ messages in thread
From: Burton, Ross @ 2014-01-23 11:47 UTC (permalink / raw)
To: Koen Kooi
Cc: Koen Kooi, Otavio Salvador,
Patches and discussions about the oe-core layer
On 23 January 2014 11:40, Koen Kooi <koen@dominion.thruhere.net> wrote:
>>>> Couldn't it inherit autotools?
>>>
>>> It's a handcrafted Makefile, not autotools :(
>>
>> No problem, it works as well.
>>
>> The do_configure checks for configure.ac/configure.in and it avoid you
>> to handcraft do_install and like.
>
> The recipes that used such a workaround have all been changed to remote autotools.bbclass over the years, so I'm not sure how encouraged it is.
Personally a recipe should only inherit autotools if it actually uses
autotools. Hand crafted makefiles should mean hand-crafted recipes.
Ross
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] lz4: actually install things
2014-01-23 11:47 ` Burton, Ross
@ 2014-01-23 11:49 ` Otavio Salvador
2014-01-23 11:53 ` Burton, Ross
0 siblings, 1 reply; 10+ messages in thread
From: Otavio Salvador @ 2014-01-23 11:49 UTC (permalink / raw)
To: Burton, Ross
Cc: Koen Kooi, Koen Kooi, Patches and discussions about the oe-core layer
On Thu, Jan 23, 2014 at 9:47 AM, Burton, Ross <ross.burton@intel.com> wrote:
> On 23 January 2014 11:40, Koen Kooi <koen@dominion.thruhere.net> wrote:
>>>>> Couldn't it inherit autotools?
>>>>
>>>> It's a handcrafted Makefile, not autotools :(
>>>
>>> No problem, it works as well.
>>>
>>> The do_configure checks for configure.ac/configure.in and it avoid you
>>> to handcraft do_install and like.
>>
>> The recipes that used such a workaround have all been changed to remote autotools.bbclass over the years, so I'm not sure how encouraged it is.
>
>
> Personally a recipe should only inherit autotools if it actually uses
> autotools. Hand crafted makefiles should mean hand-crafted recipes.
I will respect your opinions but I see no reason to not use autoconf
if do_configure checks for it.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] lz4: actually install things
2014-01-23 11:49 ` Otavio Salvador
@ 2014-01-23 11:53 ` Burton, Ross
2014-01-23 12:01 ` Otavio Salvador
0 siblings, 1 reply; 10+ messages in thread
From: Burton, Ross @ 2014-01-23 11:53 UTC (permalink / raw)
To: Otavio Salvador
Cc: Koen Kooi, Koen Kooi, Patches and discussions about the oe-core layer
On 23 January 2014 11:49, Otavio Salvador <otavio@ossystems.com.br> wrote:
>> Personally a recipe should only inherit autotools if it actually uses
>> autotools. Hand crafted makefiles should mean hand-crafted recipes.
>
> I will respect your opinions but I see no reason to not use autoconf
> if do_configure checks for it.
Extra build dependencies, extra logic beyond what is needed, the need
to be careful in the future when we can't assume that
autotools.bbclass is used with autotools-using recipes.
Ross
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] lz4: actually install things
2014-01-23 11:53 ` Burton, Ross
@ 2014-01-23 12:01 ` Otavio Salvador
0 siblings, 0 replies; 10+ messages in thread
From: Otavio Salvador @ 2014-01-23 12:01 UTC (permalink / raw)
To: Burton, Ross
Cc: Koen Kooi, Koen Kooi, Patches and discussions about the oe-core layer
On Thu, Jan 23, 2014 at 9:53 AM, Burton, Ross <ross.burton@intel.com> wrote:
> On 23 January 2014 11:49, Otavio Salvador <otavio@ossystems.com.br> wrote:
>>> Personally a recipe should only inherit autotools if it actually uses
>>> autotools. Hand crafted makefiles should mean hand-crafted recipes.
>>
>> I will respect your opinions but I see no reason to not use autoconf
>> if do_configure checks for it.
>
> Extra build dependencies, extra logic beyond what is needed, the need
> to be careful in the future when we can't assume that
> autotools.bbclass is used with autotools-using recipes.
Ok; you won.
heheh
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-01-23 12:01 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-23 9:06 [PATCH] lz4: actually install things Koen Kooi
2014-01-23 11:31 ` Otavio Salvador
2014-01-23 11:35 ` Koen Kooi
2014-01-23 11:36 ` Otavio Salvador
2014-01-23 11:40 ` Koen Kooi
2014-01-23 11:47 ` Burton, Ross
2014-01-23 11:49 ` Otavio Salvador
2014-01-23 11:53 ` Burton, Ross
2014-01-23 12:01 ` Otavio Salvador
2014-01-23 11:46 ` Paul Eggleton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.