* [PATCH] app/testpmd: fix commands to config some offload
@ 2018-07-24 3:45 Wei Dai
2018-07-24 14:22 ` Iremonger, Bernard
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Wei Dai @ 2018-07-24 3:45 UTC (permalink / raw)
To: jingjing.wu, wenzhuo.lu, dev; +Cc: Wei Dai, stable
Without this patch, testpmd command to config Rx offload keep_crc
would fail and report "Bad argument".
This patch aslo fix the command to config the Tx offload mbuf_fast_free.
Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC")
Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API")
Cc: stable@dpdk.org
Signed-off-by: Wei Dai <wei.dai@intel.com>
---
app/test-pmd/cmdline.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 5885289..a0ed3a0 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -16665,7 +16665,7 @@ struct cmd_config_per_port_rx_offload_result {
offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#"
"qinq_strip#outer_ipv4_cksum#macsec_strip#"
"header_split#vlan_filter#vlan_extend#jumbo_frame#"
- "crc_strip#scatter#timestamp#security");
+ "crc_strip#scatter#timestamp#security#keep_crc");
cmdline_parse_token_string_t cmd_config_per_port_rx_offload_result_on_off =
TOKEN_STRING_INITIALIZER
(struct cmd_config_per_port_rx_offload_result,
@@ -16744,7 +16744,7 @@ struct cmd_config_per_port_rx_offload_result {
.help_str = "port config <port_id> rx_offload vlan_strip|ipv4_cksum|"
"udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|"
"macsec_strip|header_split|vlan_filter|vlan_extend|"
- "jumbo_frame|crc_strip|scatter|timestamp|security "
+ "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc "
"on|off",
.tokens = {
(void *)&cmd_config_per_port_rx_offload_result_port,
@@ -16794,7 +16794,7 @@ struct cmd_config_per_queue_rx_offload_result {
offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#"
"qinq_strip#outer_ipv4_cksum#macsec_strip#"
"header_split#vlan_filter#vlan_extend#jumbo_frame#"
- "crc_strip#scatter#timestamp#security");
+ "crc_strip#scatter#timestamp#security#keep_crc");
cmdline_parse_token_string_t cmd_config_per_queue_rx_offload_result_on_off =
TOKEN_STRING_INITIALIZER
(struct cmd_config_per_queue_rx_offload_result,
@@ -16846,7 +16846,7 @@ struct cmd_config_per_queue_rx_offload_result {
"vlan_strip|ipv4_cksum|"
"udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|"
"macsec_strip|header_split|vlan_filter|vlan_extend|"
- "jumbo_frame|crc_strip|scatter|timestamp|security "
+ "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc "
"on|off",
.tokens = {
(void *)&cmd_config_per_queue_rx_offload_result_port,
@@ -17063,7 +17063,7 @@ struct cmd_config_per_port_tx_offload_result {
"sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#"
"qinq_insert#vxlan_tnl_tso#gre_tnl_tso#"
"ipip_tnl_tso#geneve_tnl_tso#macsec_insert#"
- "mt_lockfree#multi_segs#fast_free#security");
+ "mt_lockfree#multi_segs#mbuf_fast_free#security");
cmdline_parse_token_string_t cmd_config_per_port_tx_offload_result_on_off =
TOKEN_STRING_INITIALIZER
(struct cmd_config_per_port_tx_offload_result,
@@ -17144,7 +17144,7 @@ struct cmd_config_per_port_tx_offload_result {
"sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|"
"qinq_insert|vxlan_tnl_tso|gre_tnl_tso|"
"ipip_tnl_tso|geneve_tnl_tso|macsec_insert|"
- "mt_lockfree|multi_segs|fast_free|security "
+ "mt_lockfree|multi_segs|mbuf_fast_free|security "
"on|off",
.tokens = {
(void *)&cmd_config_per_port_tx_offload_result_port,
@@ -17195,7 +17195,7 @@ struct cmd_config_per_queue_tx_offload_result {
"sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#"
"qinq_insert#vxlan_tnl_tso#gre_tnl_tso#"
"ipip_tnl_tso#geneve_tnl_tso#macsec_insert#"
- "mt_lockfree#multi_segs#fast_free#security");
+ "mt_lockfree#multi_segs#mbuf_fast_free#security");
cmdline_parse_token_string_t cmd_config_per_queue_tx_offload_result_on_off =
TOKEN_STRING_INITIALIZER
(struct cmd_config_per_queue_tx_offload_result,
@@ -17248,7 +17248,7 @@ struct cmd_config_per_queue_tx_offload_result {
"sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|"
"qinq_insert|vxlan_tnl_tso|gre_tnl_tso|"
"ipip_tnl_tso|geneve_tnl_tso|macsec_insert|"
- "mt_lockfree|multi_segs|fast_free|security "
+ "mt_lockfree|multi_segs|mbuf_fast_free|security "
"on|off",
.tokens = {
(void *)&cmd_config_per_queue_tx_offload_result_port,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH] app/testpmd: fix commands to config some offload 2018-07-24 3:45 [PATCH] app/testpmd: fix commands to config some offload Wei Dai @ 2018-07-24 14:22 ` Iremonger, Bernard 2018-08-02 1:41 ` Dai, Wei 2018-07-25 3:29 ` Peng, Yuan 2018-08-02 1:32 ` Wei Dai 2 siblings, 1 reply; 11+ messages in thread From: Iremonger, Bernard @ 2018-07-24 14:22 UTC (permalink / raw) To: Dai, Wei, Wu, Jingjing, Lu, Wenzhuo, dev; +Cc: Dai, Wei, stable Hi Wei, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Dai > Sent: Tuesday, July 24, 2018 4:45 AM > To: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo > <wenzhuo.lu@intel.com>; dev@dpdk.org > Cc: Dai, Wei <wei.dai@intel.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some > offload > > Without this patch, testpmd command to config Rx offload keep_crc would > fail and report "Bad argument". > This patch aslo fix the command to config the Tx offload mbuf_fast_free. > > Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") > Fixes: c73a9071877a ("app/testpmd: add commands to test new offload > API") > Cc: stable@dpdk.org > > Signed-off-by: Wei Dai <wei.dai@intel.com> > --- > app/test-pmd/cmdline.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 5885289..a0ed3a0 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -16665,7 +16665,7 @@ struct cmd_config_per_port_rx_offload_result { > offload, > "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" > "qinq_strip#outer_ipv4_cksum#macsec_strip#" > > "header_split#vlan_filter#vlan_extend#jumbo_frame#" > - "crc_strip#scatter#timestamp#security"); > + "crc_strip#scatter#timestamp#security#keep_crc"); > cmdline_parse_token_string_t > cmd_config_per_port_rx_offload_result_on_off = > TOKEN_STRING_INITIALIZER > (struct cmd_config_per_port_rx_offload_result, > @@ -16744,7 +16744,7 @@ struct cmd_config_per_port_rx_offload_result { > .help_str = "port config <port_id> rx_offload > vlan_strip|ipv4_cksum|" > > "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" > "macsec_strip|header_split|vlan_filter|vlan_extend|" > - "jumbo_frame|crc_strip|scatter|timestamp|security " > + > "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " > "on|off", > .tokens = { > (void *)&cmd_config_per_port_rx_offload_result_port, > @@ -16794,7 +16794,7 @@ struct cmd_config_per_queue_rx_offload_result > { > offload, > "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" > "qinq_strip#outer_ipv4_cksum#macsec_strip#" > > "header_split#vlan_filter#vlan_extend#jumbo_frame#" > - "crc_strip#scatter#timestamp#security"); > + "crc_strip#scatter#timestamp#security#keep_crc"); > cmdline_parse_token_string_t > cmd_config_per_queue_rx_offload_result_on_off = > TOKEN_STRING_INITIALIZER > (struct cmd_config_per_queue_rx_offload_result, > @@ -16846,7 +16846,7 @@ struct cmd_config_per_queue_rx_offload_result > { > "vlan_strip|ipv4_cksum|" > > "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" > "macsec_strip|header_split|vlan_filter|vlan_extend|" > - "jumbo_frame|crc_strip|scatter|timestamp|security " > + > "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " > "on|off", > .tokens = { > (void *)&cmd_config_per_queue_rx_offload_result_port, > @@ -17063,7 +17063,7 @@ struct cmd_config_per_port_tx_offload_result { > > "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" > "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" > "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" > - "mt_lockfree#multi_segs#fast_free#security"); > + > "mt_lockfree#multi_segs#mbuf_fast_free#security"); > cmdline_parse_token_string_t > cmd_config_per_port_tx_offload_result_on_off = > TOKEN_STRING_INITIALIZER > (struct cmd_config_per_port_tx_offload_result, > @@ -17144,7 +17144,7 @@ struct cmd_config_per_port_tx_offload_result { > "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" > "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" > "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" > - "mt_lockfree|multi_segs|fast_free|security " > + "mt_lockfree|multi_segs|mbuf_fast_free|security " > "on|off", > .tokens = { > (void *)&cmd_config_per_port_tx_offload_result_port, > @@ -17195,7 +17195,7 @@ struct cmd_config_per_queue_tx_offload_result > { > > "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" > "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" > "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" > - "mt_lockfree#multi_segs#fast_free#security"); > + > "mt_lockfree#multi_segs#mbuf_fast_free#security"); > cmdline_parse_token_string_t > cmd_config_per_queue_tx_offload_result_on_off = > TOKEN_STRING_INITIALIZER > (struct cmd_config_per_queue_tx_offload_result, > @@ -17248,7 +17248,7 @@ struct cmd_config_per_queue_tx_offload_result > { > "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" > "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" > "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" > - "mt_lockfree|multi_segs|fast_free|security " > + "mt_lockfree|multi_segs|mbuf_fast_free|security " > "on|off", > .tokens = { > (void *)&cmd_config_per_queue_tx_offload_result_port, > -- > 1.8.3.1 Changes are also needed in dpdk/doc/guides/testpmd_app_guide/testpmd_funcs.rst for mbuf_fast_free and keep_crc. Regards, Bernard ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] app/testpmd: fix commands to config some offload 2018-07-24 14:22 ` Iremonger, Bernard @ 2018-08-02 1:41 ` Dai, Wei 0 siblings, 0 replies; 11+ messages in thread From: Dai, Wei @ 2018-08-02 1:41 UTC (permalink / raw) To: Iremonger, Bernard, Wu, Jingjing, Lu, Wenzhuo, dev; +Cc: stable Hi, Bernard Thanks for your feedback and guidance. I have just submitted a v2 patch to include modification on document. Thanks & Best Regrards -Wei > -----Original Message----- > From: Iremonger, Bernard > Sent: Tuesday, July 24, 2018 10:22 PM > To: Dai, Wei <wei.dai@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Lu, > Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org > Cc: Dai, Wei <wei.dai@intel.com>; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some > offload > > Hi Wei, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Dai > > Sent: Tuesday, July 24, 2018 4:45 AM > > To: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo > > <wenzhuo.lu@intel.com>; dev@dpdk.org > > Cc: Dai, Wei <wei.dai@intel.com>; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some > > offload > > > > Without this patch, testpmd command to config Rx offload keep_crc > > would fail and report "Bad argument". > > This patch aslo fix the command to config the Tx offload mbuf_fast_free. > > > > Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") > > Fixes: c73a9071877a ("app/testpmd: add commands to test new offload > > API") > > Cc: stable@dpdk.org > > > > Signed-off-by: Wei Dai <wei.dai@intel.com> > > --- > > app/test-pmd/cmdline.c | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > 5885289..a0ed3a0 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -16665,7 +16665,7 @@ struct > cmd_config_per_port_rx_offload_result { > > offload, > > "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" > > "qinq_strip#outer_ipv4_cksum#macsec_strip#" > > > > "header_split#vlan_filter#vlan_extend#jumbo_frame#" > > - "crc_strip#scatter#timestamp#security"); > > + "crc_strip#scatter#timestamp#security#keep_crc"); > > cmdline_parse_token_string_t > > cmd_config_per_port_rx_offload_result_on_off = > > TOKEN_STRING_INITIALIZER > > (struct cmd_config_per_port_rx_offload_result, > > @@ -16744,7 +16744,7 @@ struct > cmd_config_per_port_rx_offload_result { > > .help_str = "port config <port_id> rx_offload > > vlan_strip|ipv4_cksum|" > > > > "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" > > "macsec_strip|header_split|vlan_filter|vlan_extend|" > > - "jumbo_frame|crc_strip|scatter|timestamp|security " > > + > > "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " > > "on|off", > > .tokens = { > > (void *)&cmd_config_per_port_rx_offload_result_port, > > @@ -16794,7 +16794,7 @@ struct > cmd_config_per_queue_rx_offload_result > > { > > offload, > > "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" > > "qinq_strip#outer_ipv4_cksum#macsec_strip#" > > > > "header_split#vlan_filter#vlan_extend#jumbo_frame#" > > - "crc_strip#scatter#timestamp#security"); > > + "crc_strip#scatter#timestamp#security#keep_crc"); > > cmdline_parse_token_string_t > > cmd_config_per_queue_rx_offload_result_on_off = > > TOKEN_STRING_INITIALIZER > > (struct cmd_config_per_queue_rx_offload_result, > > @@ -16846,7 +16846,7 @@ struct > cmd_config_per_queue_rx_offload_result > > { > > "vlan_strip|ipv4_cksum|" > > > > "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" > > "macsec_strip|header_split|vlan_filter|vlan_extend|" > > - "jumbo_frame|crc_strip|scatter|timestamp|security " > > + > > "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " > > "on|off", > > .tokens = { > > (void *)&cmd_config_per_queue_rx_offload_result_port, > > @@ -17063,7 +17063,7 @@ struct > cmd_config_per_port_tx_offload_result { > > > > "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" > > "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" > > "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" > > - "mt_lockfree#multi_segs#fast_free#security"); > > + > > "mt_lockfree#multi_segs#mbuf_fast_free#security"); > > cmdline_parse_token_string_t > > cmd_config_per_port_tx_offload_result_on_off = > > TOKEN_STRING_INITIALIZER > > (struct cmd_config_per_port_tx_offload_result, > > @@ -17144,7 +17144,7 @@ struct > cmd_config_per_port_tx_offload_result { > > "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" > > "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" > > "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" > > - "mt_lockfree|multi_segs|fast_free|security " > > + "mt_lockfree|multi_segs|mbuf_fast_free|security " > > "on|off", > > .tokens = { > > (void *)&cmd_config_per_port_tx_offload_result_port, > > @@ -17195,7 +17195,7 @@ struct > cmd_config_per_queue_tx_offload_result > > { > > > > "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" > > "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" > > "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" > > - "mt_lockfree#multi_segs#fast_free#security"); > > + > > "mt_lockfree#multi_segs#mbuf_fast_free#security"); > > cmdline_parse_token_string_t > > cmd_config_per_queue_tx_offload_result_on_off = > > TOKEN_STRING_INITIALIZER > > (struct cmd_config_per_queue_tx_offload_result, > > @@ -17248,7 +17248,7 @@ struct > cmd_config_per_queue_tx_offload_result > > { > > "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" > > "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" > > "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" > > - "mt_lockfree|multi_segs|fast_free|security " > > + "mt_lockfree|multi_segs|mbuf_fast_free|security " > > "on|off", > > .tokens = { > > (void *)&cmd_config_per_queue_tx_offload_result_port, > > -- > > 1.8.3.1 > > Changes are also needed in > dpdk/doc/guides/testpmd_app_guide/testpmd_funcs.rst for mbuf_fast_free > and keep_crc. > > Regards, > > Bernard ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] app/testpmd: fix commands to config some offload 2018-07-24 3:45 [PATCH] app/testpmd: fix commands to config some offload Wei Dai 2018-07-24 14:22 ` Iremonger, Bernard @ 2018-07-25 3:29 ` Peng, Yuan 2018-08-02 1:32 ` Wei Dai 2 siblings, 0 replies; 11+ messages in thread From: Peng, Yuan @ 2018-07-25 3:29 UTC (permalink / raw) To: Dai, Wei, Wu, Jingjing, Lu, Wenzhuo, dev; +Cc: Dai, Wei, stable -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Dai Sent: Tuesday, July 24, 2018 11:45 AM To: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org Cc: Dai, Wei <wei.dai@intel.com>; stable@dpdk.org Subject: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some offload Without this patch, testpmd command to config Rx offload keep_crc would fail and report "Bad argument". This patch aslo fix the command to config the Tx offload mbuf_fast_free. Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API") Cc: stable@dpdk.org Signed-off-by: Wei Dai <wei.dai@intel.com> Tested-by: Peng, Yuan <yuan.peng@intel.com> - DPDK version: 18.08-rc1 commit c27dbc300eee78c2eb33e84181617fdd7cbaaae4 - OS: 4.5.5-300.fc24.x86_64 - Compiler: gcc (GCC) 5.3.1 20151207 (Red Hat 5.3.1-2) - Hardware platform: BDE-EP - NIC Intel Corporation Device Fortville [8086:1583] - driver: i40e - version: 2.4.3 - firmware-version: 6.01 0x80003205 1.1691.0 - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz - Default x86_64-native-linuxapp-gcc configuration - Prerequisites: - Total 2 cases, 2 passed, 0 failed --- app/test-pmd/cmdline.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 5885289..a0ed3a0 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -16665,7 +16665,7 @@ struct cmd_config_per_port_rx_offload_result { offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" "qinq_strip#outer_ipv4_cksum#macsec_strip#" "header_split#vlan_filter#vlan_extend#jumbo_frame#" - "crc_strip#scatter#timestamp#security"); + "crc_strip#scatter#timestamp#security#keep_crc"); cmdline_parse_token_string_t cmd_config_per_port_rx_offload_result_on_off = TOKEN_STRING_INITIALIZER (struct cmd_config_per_port_rx_offload_result, @@ -16744,7 +16744,7 @@ struct cmd_config_per_port_rx_offload_result { .help_str = "port config <port_id> rx_offload vlan_strip|ipv4_cksum|" "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" "macsec_strip|header_split|vlan_filter|vlan_extend|" - "jumbo_frame|crc_strip|scatter|timestamp|security " + "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " "on|off", .tokens = { (void *)&cmd_config_per_port_rx_offload_result_port, @@ -16794,7 +16794,7 @@ struct cmd_config_per_queue_rx_offload_result { offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" "qinq_strip#outer_ipv4_cksum#macsec_strip#" "header_split#vlan_filter#vlan_extend#jumbo_frame#" - "crc_strip#scatter#timestamp#security"); + "crc_strip#scatter#timestamp#security#keep_crc"); cmdline_parse_token_string_t cmd_config_per_queue_rx_offload_result_on_off = TOKEN_STRING_INITIALIZER (struct cmd_config_per_queue_rx_offload_result, @@ -16846,7 +16846,7 @@ struct cmd_config_per_queue_rx_offload_result { "vlan_strip|ipv4_cksum|" "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" "macsec_strip|header_split|vlan_filter|vlan_extend|" - "jumbo_frame|crc_strip|scatter|timestamp|security " + "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " "on|off", .tokens = { (void *)&cmd_config_per_queue_rx_offload_result_port, @@ -17063,7 +17063,7 @@ struct cmd_config_per_port_tx_offload_result { "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" - "mt_lockfree#multi_segs#fast_free#security"); + "mt_lockfree#multi_segs#mbuf_fast_free#security"); cmdline_parse_token_string_t cmd_config_per_port_tx_offload_result_on_off = TOKEN_STRING_INITIALIZER (struct cmd_config_per_port_tx_offload_result, @@ -17144,7 +17144,7 @@ struct cmd_config_per_port_tx_offload_result { "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" - "mt_lockfree|multi_segs|fast_free|security " + "mt_lockfree|multi_segs|mbuf_fast_free|security " "on|off", .tokens = { (void *)&cmd_config_per_port_tx_offload_result_port, @@ -17195,7 +17195,7 @@ struct cmd_config_per_queue_tx_offload_result { "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" - "mt_lockfree#multi_segs#fast_free#security"); + "mt_lockfree#multi_segs#mbuf_fast_free#security"); cmdline_parse_token_string_t cmd_config_per_queue_tx_offload_result_on_off = TOKEN_STRING_INITIALIZER (struct cmd_config_per_queue_tx_offload_result, @@ -17248,7 +17248,7 @@ struct cmd_config_per_queue_tx_offload_result { "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" - "mt_lockfree|multi_segs|fast_free|security " + "mt_lockfree|multi_segs|mbuf_fast_free|security " "on|off", .tokens = { (void *)&cmd_config_per_queue_tx_offload_result_port, -- 1.8.3.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] app/testpmd: fix commands to config some offload 2018-07-24 3:45 [PATCH] app/testpmd: fix commands to config some offload Wei Dai 2018-07-24 14:22 ` Iremonger, Bernard 2018-07-25 3:29 ` Peng, Yuan @ 2018-08-02 1:32 ` Wei Dai 2018-08-02 9:11 ` Iremonger, Bernard 2018-08-03 12:55 ` [PATCH v3] " Wei Dai 2 siblings, 2 replies; 11+ messages in thread From: Wei Dai @ 2018-08-02 1:32 UTC (permalink / raw) To: jingjing.wu, wenzhuo.lu; +Cc: dev, Wei Dai, stable Without this patch, testpmd command to config Rx offload keep_crc would fail and report "Bad argument". This patch aslo fix the command to config the Tx offload mbuf_fast_free. Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API") Cc: stable@dpdk.org Signed-off-by: Wei Dai <wei.dai@intel.com> Tested-by: Yuan Peng <yuan.peng@intel.com> --- app/test-pmd/cmdline.c | 16 ++++++++-------- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 ++++---- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 54ba2f5..589121d 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -17005,7 +17005,7 @@ struct cmd_config_per_port_rx_offload_result { offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" "qinq_strip#outer_ipv4_cksum#macsec_strip#" "header_split#vlan_filter#vlan_extend#jumbo_frame#" - "crc_strip#scatter#timestamp#security"); + "crc_strip#scatter#timestamp#security#keep_crc"); cmdline_parse_token_string_t cmd_config_per_port_rx_offload_result_on_off = TOKEN_STRING_INITIALIZER (struct cmd_config_per_port_rx_offload_result, @@ -17084,7 +17084,7 @@ struct cmd_config_per_port_rx_offload_result { .help_str = "port config <port_id> rx_offload vlan_strip|ipv4_cksum|" "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" "macsec_strip|header_split|vlan_filter|vlan_extend|" - "jumbo_frame|crc_strip|scatter|timestamp|security " + "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " "on|off", .tokens = { (void *)&cmd_config_per_port_rx_offload_result_port, @@ -17134,7 +17134,7 @@ struct cmd_config_per_queue_rx_offload_result { offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" "qinq_strip#outer_ipv4_cksum#macsec_strip#" "header_split#vlan_filter#vlan_extend#jumbo_frame#" - "crc_strip#scatter#timestamp#security"); + "crc_strip#scatter#timestamp#security#keep_crc"); cmdline_parse_token_string_t cmd_config_per_queue_rx_offload_result_on_off = TOKEN_STRING_INITIALIZER (struct cmd_config_per_queue_rx_offload_result, @@ -17186,7 +17186,7 @@ struct cmd_config_per_queue_rx_offload_result { "vlan_strip|ipv4_cksum|" "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" "macsec_strip|header_split|vlan_filter|vlan_extend|" - "jumbo_frame|crc_strip|scatter|timestamp|security " + "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " "on|off", .tokens = { (void *)&cmd_config_per_queue_rx_offload_result_port, @@ -17403,7 +17403,7 @@ struct cmd_config_per_port_tx_offload_result { "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" - "mt_lockfree#multi_segs#fast_free#security"); + "mt_lockfree#multi_segs#mbuf_fast_free#security"); cmdline_parse_token_string_t cmd_config_per_port_tx_offload_result_on_off = TOKEN_STRING_INITIALIZER (struct cmd_config_per_port_tx_offload_result, @@ -17484,7 +17484,7 @@ struct cmd_config_per_port_tx_offload_result { "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" - "mt_lockfree|multi_segs|fast_free|security " + "mt_lockfree|multi_segs|mbuf_fast_free|security " "on|off", .tokens = { (void *)&cmd_config_per_port_tx_offload_result_port, @@ -17535,7 +17535,7 @@ struct cmd_config_per_queue_tx_offload_result { "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" - "mt_lockfree#multi_segs#fast_free#security"); + "mt_lockfree#multi_segs#mbuf_fast_free#security"); cmdline_parse_token_string_t cmd_config_per_queue_tx_offload_result_on_off = TOKEN_STRING_INITIALIZER (struct cmd_config_per_queue_tx_offload_result, @@ -17588,7 +17588,7 @@ struct cmd_config_per_queue_tx_offload_result { "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" - "mt_lockfree|multi_segs|fast_free|security " + "mt_lockfree|multi_segs|mbuf_fast_free|security " "on|off", .tokens = { (void *)&cmd_config_per_queue_tx_offload_result_port, diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index c35077c..a705366 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -1490,7 +1490,7 @@ Enable or disable a per port Rx offloading on all Rx queues of a port:: vlan_strip, ipv4_cksum, udp_cksum, tcp_cksum, tcp_lro, qinq_strip, outer_ipv4_cksum, macsec_strip, header_split, vlan_filter, vlan_extend, jumbo_frame, - crc_strip, scatter, timestamp, security + crc_strip, scatter, timestamp, security, keep_crc This command should be run when the port is stopped, or else it will fail. @@ -1505,7 +1505,7 @@ Enable or disable a per queue Rx offloading only on a specific Rx queue:: vlan_strip, ipv4_cksum, udp_cksum, tcp_cksum, tcp_lro, qinq_strip, outer_ipv4_cksum, macsec_strip, header_split, vlan_filter, vlan_extend, jumbo_frame, - crc_strip, scatter, timestamp, security + crc_strip, scatter, timestamp, security, keep_crc This command should be run when the port is stopped, or else it will fail. @@ -1521,7 +1521,7 @@ Enable or disable a per port Tx offloading on all Tx queues of a port:: sctp_cksum, tcp_tso, udp_tso, outer_ipv4_cksum, qinq_insert, vxlan_tnl_tso, gre_tnl_tso, ipip_tnl_tso, geneve_tnl_tso, macsec_insert, - mt_lockfree, multi_segs, fast_free, security + mt_lockfree, multi_segs, mbuf_fast_free, security This command should be run when the port is stopped, or else it will fail. @@ -1537,7 +1537,7 @@ Enable or disable a per queue Tx offloading only on a specific Tx queue:: sctp_cksum, tcp_tso, udp_tso, outer_ipv4_cksum, qinq_insert, vxlan_tnl_tso, gre_tnl_tso, ipip_tnl_tso, geneve_tnl_tso, macsec_insert, - mt_lockfree, multi_segs, fast_free, security + mt_lockfree, multi_segs, mbuf_fast_free, security This command should be run when the port is stopped, or else it will fail. -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] app/testpmd: fix commands to config some offload 2018-08-02 1:32 ` Wei Dai @ 2018-08-02 9:11 ` Iremonger, Bernard 2018-08-03 12:53 ` Dai, Wei 2018-08-03 12:55 ` [PATCH v3] " Wei Dai 1 sibling, 1 reply; 11+ messages in thread From: Iremonger, Bernard @ 2018-08-02 9:11 UTC (permalink / raw) To: Dai, Wei, Wu, Jingjing, Lu, Wenzhuo; +Cc: dev, Dai, Wei, stable > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Dai > Sent: Thursday, August 2, 2018 2:32 AM > To: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo > <wenzhuo.lu@intel.com> > Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some offload > > Without this patch, testpmd command to config Rx offload keep_crc would fail > and report "Bad argument". > This patch aslo fix the command to config the Tx offload mbuf_fast_free. > > Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") > Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API") > Cc: stable@dpdk.org > > Signed-off-by: Wei Dai <wei.dai@intel.com> > Tested-by: Yuan Peng <yuan.peng@intel.com> Should have been [PATCH v2] otherwise fine. Acked-by: Bernard Iremonger <Bernard.iremonger@intel.com> ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] app/testpmd: fix commands to config some offload 2018-08-02 9:11 ` Iremonger, Bernard @ 2018-08-03 12:53 ` Dai, Wei 0 siblings, 0 replies; 11+ messages in thread From: Dai, Wei @ 2018-08-03 12:53 UTC (permalink / raw) To: Iremonger, Bernard, Wu, Jingjing, Lu, Wenzhuo; +Cc: dev, stable Thanks, Iremonger. I will reply this patch with a v3 patch. > -----Original Message----- > From: Iremonger, Bernard > Sent: Thursday, August 2, 2018 5:12 PM > To: Dai, Wei <wei.dai@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Lu, > Wenzhuo <wenzhuo.lu@intel.com> > Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some > offload > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Dai > > Sent: Thursday, August 2, 2018 2:32 AM > > To: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo > > <wenzhuo.lu@intel.com> > > Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some > > offload > > > > Without this patch, testpmd command to config Rx offload keep_crc > > would fail and report "Bad argument". > > This patch aslo fix the command to config the Tx offload mbuf_fast_free. > > > > Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") > > Fixes: c73a9071877a ("app/testpmd: add commands to test new offload > > API") > > Cc: stable@dpdk.org > > > > Signed-off-by: Wei Dai <wei.dai@intel.com> > > Tested-by: Yuan Peng <yuan.peng@intel.com> > > Should have been [PATCH v2] otherwise fine. > > Acked-by: Bernard Iremonger <Bernard.iremonger@intel.com> > ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v3] app/testpmd: fix commands to config some offload 2018-08-02 1:32 ` Wei Dai 2018-08-02 9:11 ` Iremonger, Bernard @ 2018-08-03 12:55 ` Wei Dai 2018-08-05 10:41 ` Thomas Monjalon 1 sibling, 1 reply; 11+ messages in thread From: Wei Dai @ 2018-08-03 12:55 UTC (permalink / raw) To: bernard.iremonger, jingjing.wu, wenzhuo.lu; +Cc: dev, Wei Dai, stable Without this patch, testpmd command to config Rx offload keep_crc would fail and report "Bad argument". This patch aslo fix the command to config the Tx offload mbuf_fast_free. Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API") Cc: stable@dpdk.org Signed-off-by: Wei Dai <wei.dai@intel.com> Tested-by: Yuan Peng <yuan.peng@intel.com> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com> --- app/test-pmd/cmdline.c | 16 ++++++++-------- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 ++++---- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 54ba2f5..589121d 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -17005,7 +17005,7 @@ struct cmd_config_per_port_rx_offload_result { offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" "qinq_strip#outer_ipv4_cksum#macsec_strip#" "header_split#vlan_filter#vlan_extend#jumbo_frame#" - "crc_strip#scatter#timestamp#security"); + "crc_strip#scatter#timestamp#security#keep_crc"); cmdline_parse_token_string_t cmd_config_per_port_rx_offload_result_on_off = TOKEN_STRING_INITIALIZER (struct cmd_config_per_port_rx_offload_result, @@ -17084,7 +17084,7 @@ struct cmd_config_per_port_rx_offload_result { .help_str = "port config <port_id> rx_offload vlan_strip|ipv4_cksum|" "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" "macsec_strip|header_split|vlan_filter|vlan_extend|" - "jumbo_frame|crc_strip|scatter|timestamp|security " + "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " "on|off", .tokens = { (void *)&cmd_config_per_port_rx_offload_result_port, @@ -17134,7 +17134,7 @@ struct cmd_config_per_queue_rx_offload_result { offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" "qinq_strip#outer_ipv4_cksum#macsec_strip#" "header_split#vlan_filter#vlan_extend#jumbo_frame#" - "crc_strip#scatter#timestamp#security"); + "crc_strip#scatter#timestamp#security#keep_crc"); cmdline_parse_token_string_t cmd_config_per_queue_rx_offload_result_on_off = TOKEN_STRING_INITIALIZER (struct cmd_config_per_queue_rx_offload_result, @@ -17186,7 +17186,7 @@ struct cmd_config_per_queue_rx_offload_result { "vlan_strip|ipv4_cksum|" "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" "macsec_strip|header_split|vlan_filter|vlan_extend|" - "jumbo_frame|crc_strip|scatter|timestamp|security " + "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " "on|off", .tokens = { (void *)&cmd_config_per_queue_rx_offload_result_port, @@ -17403,7 +17403,7 @@ struct cmd_config_per_port_tx_offload_result { "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" - "mt_lockfree#multi_segs#fast_free#security"); + "mt_lockfree#multi_segs#mbuf_fast_free#security"); cmdline_parse_token_string_t cmd_config_per_port_tx_offload_result_on_off = TOKEN_STRING_INITIALIZER (struct cmd_config_per_port_tx_offload_result, @@ -17484,7 +17484,7 @@ struct cmd_config_per_port_tx_offload_result { "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" - "mt_lockfree|multi_segs|fast_free|security " + "mt_lockfree|multi_segs|mbuf_fast_free|security " "on|off", .tokens = { (void *)&cmd_config_per_port_tx_offload_result_port, @@ -17535,7 +17535,7 @@ struct cmd_config_per_queue_tx_offload_result { "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" - "mt_lockfree#multi_segs#fast_free#security"); + "mt_lockfree#multi_segs#mbuf_fast_free#security"); cmdline_parse_token_string_t cmd_config_per_queue_tx_offload_result_on_off = TOKEN_STRING_INITIALIZER (struct cmd_config_per_queue_tx_offload_result, @@ -17588,7 +17588,7 @@ struct cmd_config_per_queue_tx_offload_result { "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" - "mt_lockfree|multi_segs|fast_free|security " + "mt_lockfree|multi_segs|mbuf_fast_free|security " "on|off", .tokens = { (void *)&cmd_config_per_queue_tx_offload_result_port, diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index c35077c..a705366 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -1490,7 +1490,7 @@ Enable or disable a per port Rx offloading on all Rx queues of a port:: vlan_strip, ipv4_cksum, udp_cksum, tcp_cksum, tcp_lro, qinq_strip, outer_ipv4_cksum, macsec_strip, header_split, vlan_filter, vlan_extend, jumbo_frame, - crc_strip, scatter, timestamp, security + crc_strip, scatter, timestamp, security, keep_crc This command should be run when the port is stopped, or else it will fail. @@ -1505,7 +1505,7 @@ Enable or disable a per queue Rx offloading only on a specific Rx queue:: vlan_strip, ipv4_cksum, udp_cksum, tcp_cksum, tcp_lro, qinq_strip, outer_ipv4_cksum, macsec_strip, header_split, vlan_filter, vlan_extend, jumbo_frame, - crc_strip, scatter, timestamp, security + crc_strip, scatter, timestamp, security, keep_crc This command should be run when the port is stopped, or else it will fail. @@ -1521,7 +1521,7 @@ Enable or disable a per port Tx offloading on all Tx queues of a port:: sctp_cksum, tcp_tso, udp_tso, outer_ipv4_cksum, qinq_insert, vxlan_tnl_tso, gre_tnl_tso, ipip_tnl_tso, geneve_tnl_tso, macsec_insert, - mt_lockfree, multi_segs, fast_free, security + mt_lockfree, multi_segs, mbuf_fast_free, security This command should be run when the port is stopped, or else it will fail. @@ -1537,7 +1537,7 @@ Enable or disable a per queue Tx offloading only on a specific Tx queue:: sctp_cksum, tcp_tso, udp_tso, outer_ipv4_cksum, qinq_insert, vxlan_tnl_tso, gre_tnl_tso, ipip_tnl_tso, geneve_tnl_tso, macsec_insert, - mt_lockfree, multi_segs, fast_free, security + mt_lockfree, multi_segs, mbuf_fast_free, security This command should be run when the port is stopped, or else it will fail. -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v3] app/testpmd: fix commands to config some offload 2018-08-03 12:55 ` [PATCH v3] " Wei Dai @ 2018-08-05 10:41 ` Thomas Monjalon 0 siblings, 0 replies; 11+ messages in thread From: Thomas Monjalon @ 2018-08-05 10:41 UTC (permalink / raw) To: Wei Dai; +Cc: dev, bernard.iremonger, jingjing.wu, wenzhuo.lu, stable 03/08/2018 14:55, Wei Dai: > Without this patch, testpmd command to config Rx offload keep_crc > would fail and report "Bad argument". > This patch aslo fix the command to config the Tx offload mbuf_fast_free. > > Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") > Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API") > Cc: stable@dpdk.org > > Signed-off-by: Wei Dai <wei.dai@intel.com> > Tested-by: Yuan Peng <yuan.peng@intel.com> > Acked-by: Bernard Iremonger <bernard.iremonger@intel.com> Applied, thanks ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <1532054553-21844-1-git-send-email-wei.dai@intel.com>]
* Re: [PATCH] app/testpmd: fix commands to config some offload [not found] <1532054553-21844-1-git-send-email-wei.dai@intel.com> @ 2018-07-20 3:20 ` Peng, Yuan 0 siblings, 0 replies; 11+ messages in thread From: Peng, Yuan @ 2018-07-20 3:20 UTC (permalink / raw) To: Dai, Wei, Wu, Jingjing, Peng, Yuan; +Cc: dev, stable Tested-by: Peng, Yuan <yuan.peng@intel.com> - DPDK version: 18.08-rc1 commit c27dbc300eee78c2eb33e84181617fdd7cbaaae4 - OS: 4.5.5-300.fc24.x86_64 - Compiler: gcc (GCC) 5.3.1 20151207 (Red Hat 5.3.1-2) - Hardware platform: BDE-EP - NIC Intel Corporation Device Fortville [8086:1583] - driver: i40e - version: 2.4.3 - firmware-version: 6.01 0x80003205 1.1691.0 - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz - Default x86_64-native-linuxapp-gcc configuration - Prerequisites: - Total 2 cases, 2 passed, 0 failed Test1: ./usertools/dpdk-devbind.py -b igb_uio 05:00.0 05:00.1 1../x86_64-native-linuxapp-gcc/app/testpmd -c f -n 4 - -i --rxq=4 --txq=4 testpmd> show port 0 rx_offload capabilities Rx Offloading Capabilities of port 0 : Per Queue : Per Port : VLAN_STRIP IPV4_CKSUM UDP_CKSUM TCP_CKSUM QINQ_STRIP OUTER_IPV4_CKSUM VLAN_FILTER VLAN_EXTEND JUMBO_FRAME CRC_STRIP KEEP_CRC testpmd> show port 0 rx_offload configuration Rx Offloading Configuration of port 0 : Port : Queue[ 0] : Queue[ 1] : Queue[ 2] : Queue[ 3] : Testpmd> port stop 0 testpmd> port config 0 rx_offload keep_crc on testpmd> port start 0 The port can be started normally. Test2: 1. Start testpmd and get the tx_offload capability and configuration:: ./testpmd -c f -n 4 -- -i --rxq=4 --txq=4 testpmd> show port 0 tx_offload capabilities Tx Offloading Capabilities of port 0 : Per Queue : MBUF_FAST_FREE Per Port : VLAN_INSERT IPV4_CKSUM UDP_CKSUM TCP_CKSUM SCTP_CKSUM TCP_TSO OUTER_IPV4_CKSUM QINQ_INSERT VXLAN_TNL_TSO GRE_TNL_TSO IPIP_TNL_TSO GENEVE_TNL_TSO MULTI_SEGS testpmd> show port 0 tx_offload configuration Tx Offloading Configuration of port 0 : Port : MBUF_FAST_FREE Queue[ 0] : Queue[ 1] : Queue[ 2] : Queue[ 3] : 2. Disable mbuf_fast_free per_port:: testpmd> port stop 0 testpmd> port config 0 tx_offload mbuf_fast_free off testpmd> port start 0 testpmd> show port 0 tx_offload configuration Tx Offloading Configuration of port 0 : Port : Queue[ 0] : Queue[ 1] : Queue[ 2] : Queue[ 3] : 3. Enable mbuf_fast_free per_queue:: testpmd> port 0 txq 0 tx_offload mbuf_fast_free on testpmd> port 0 txq 1 tx_offload mbuf_fast_free on testpmd> port 0 txq 2 tx_offload mbuf_fast_free on testpmd> port 0 txq 3 tx_offload mbuf_fast_free on testpmd> port start 0 testpmd> show port 0 tx_offload configuration Tx Offloading Configuration of port 0 : Port : Queue[ 0] : MBUF_FAST_FREE Queue[ 1] : MBUF_FAST_FREE Queue[ 2] : MBUF_FAST_FREE Queue[ 3] : MBUF_FAST_FREE 4. Disable mbuf_fast_free per_queue:: testpmd> port 0 txq 0 tx_offload mbuf_fast_free off testpmd> port 0 txq 1 tx_offload mbuf_fast_free off testpmd> port 0 txq 2 tx_offload mbuf_fast_free off testpmd> port 0 txq 3 tx_offload mbuf_fast_free off testpmd> port start 0 testpmd> show port 0 tx_offload configuration Tx Offloading Configuration of port 0 : Port : Queue[ 0] : Queue[ 1] : Queue[ 2] : Queue[ 3] : The mbuf_fast_free per_queue can be set normally. -----Original Message----- From: Dai, Wei Sent: Friday, July 20, 2018 10:43 AM To: Wu, Jingjing <jingjing.wu@intel.com>; Peng, Yuan <yuan.peng@intel.com> Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; stable@dpdk.org Subject: [PATCH] app/testpmd: fix commands to config some offload Without this patch, testpmd command to config Rx offload keep_crc would fail and report "Bad argument". This patch aslo fix the command to config the Tx offload mbuf_fast_free. Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API") Cc: stable@dpdk.org Signed-off-by: Wei Dai <wei.dai@intel.com> --- app/test-pmd/cmdline.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 5885289..a0ed3a0 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -16665,7 +16665,7 @@ struct cmd_config_per_port_rx_offload_result { offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" "qinq_strip#outer_ipv4_cksum#macsec_strip#" "header_split#vlan_filter#vlan_extend#jumbo_frame#" - "crc_strip#scatter#timestamp#security"); + "crc_strip#scatter#timestamp#security#keep_crc"); cmdline_parse_token_string_t cmd_config_per_port_rx_offload_result_on_off = TOKEN_STRING_INITIALIZER (struct cmd_config_per_port_rx_offload_result, @@ -16744,7 +16744,7 @@ struct cmd_config_per_port_rx_offload_result { .help_str = "port config <port_id> rx_offload vlan_strip|ipv4_cksum|" "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" "macsec_strip|header_split|vlan_filter|vlan_extend|" - "jumbo_frame|crc_strip|scatter|timestamp|security " + "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " "on|off", .tokens = { (void *)&cmd_config_per_port_rx_offload_result_port, @@ -16794,7 +16794,7 @@ struct cmd_config_per_queue_rx_offload_result { offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" "qinq_strip#outer_ipv4_cksum#macsec_strip#" "header_split#vlan_filter#vlan_extend#jumbo_frame#" - "crc_strip#scatter#timestamp#security"); + "crc_strip#scatter#timestamp#security#keep_crc"); cmdline_parse_token_string_t cmd_config_per_queue_rx_offload_result_on_off = TOKEN_STRING_INITIALIZER (struct cmd_config_per_queue_rx_offload_result, @@ -16846,7 +16846,7 @@ struct cmd_config_per_queue_rx_offload_result { "vlan_strip|ipv4_cksum|" "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" "macsec_strip|header_split|vlan_filter|vlan_extend|" - "jumbo_frame|crc_strip|scatter|timestamp|security " + "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " "on|off", .tokens = { (void *)&cmd_config_per_queue_rx_offload_result_port, @@ -17063,7 +17063,7 @@ struct cmd_config_per_port_tx_offload_result { "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" - "mt_lockfree#multi_segs#fast_free#security"); + "mt_lockfree#multi_segs#mbuf_fast_free#security"); cmdline_parse_token_string_t cmd_config_per_port_tx_offload_result_on_off = TOKEN_STRING_INITIALIZER (struct cmd_config_per_port_tx_offload_result, @@ -17144,7 +17144,7 @@ struct cmd_config_per_port_tx_offload_result { "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" - "mt_lockfree|multi_segs|fast_free|security " + "mt_lockfree|multi_segs|mbuf_fast_free|security " "on|off", .tokens = { (void *)&cmd_config_per_port_tx_offload_result_port, @@ -17195,7 +17195,7 @@ struct cmd_config_per_queue_tx_offload_result { "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" - "mt_lockfree#multi_segs#fast_free#security"); + "mt_lockfree#multi_segs#mbuf_fast_free#security"); cmdline_parse_token_string_t cmd_config_per_queue_tx_offload_result_on_off = TOKEN_STRING_INITIALIZER (struct cmd_config_per_queue_tx_offload_result, @@ -17248,7 +17248,7 @@ struct cmd_config_per_queue_tx_offload_result { "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" - "mt_lockfree|multi_segs|fast_free|security " + "mt_lockfree|multi_segs|mbuf_fast_free|security " "on|off", .tokens = { (void *)&cmd_config_per_queue_tx_offload_result_port, -- 1.8.3.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <1532002875-29504-1-git-send-email-wei.dai@intel.com>]
* Re: [PATCH] app/testpmd: fix commands to config some offload [not found] <1532002875-29504-1-git-send-email-wei.dai@intel.com> @ 2018-07-20 2:34 ` Dai, Wei 0 siblings, 0 replies; 11+ messages in thread From: Dai, Wei @ 2018-07-20 2:34 UTC (permalink / raw) To: Wu, Jingjing, Peng, Yuan; +Cc: dev, stable Hi, Yuan How about your test result ? Thanks a lot! > -----Original Message----- > From: Dai, Wei > Sent: Thursday, July 19, 2018 8:21 PM > To: Wu, Jingjing <jingjing.wu@intel.com>; yuan.peng@intle.com > Cc: dev@dpdk.org; stable@dpdk.org; Dai, Wei <wei.dai@intel.com> > Subject: [PATCH] app/testpmd: fix commands to config some offload > > Without this patch, testpmd command to config Rx offload keep_crc would > fail and report "Bad argument". > This patch aslo fix the command to config the Tx offload mbuf_fast_free. > > Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") > Fixes: c73a9071877a ("app/testpmd: add commands to test new offload > API") > Cc: stable@dpdk.org > > Signed-off-by: Wei Dai <wei.dai@intel.com> > --- > app/test-pmd/cmdline.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 5885289..a0ed3a0 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -16665,7 +16665,7 @@ struct cmd_config_per_port_rx_offload_result > { > offload, > "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" > "qinq_strip#outer_ipv4_cksum#macsec_strip#" > "header_split#vlan_filter#vlan_extend#jumbo_frame#" > - "crc_strip#scatter#timestamp#security"); > + "crc_strip#scatter#timestamp#security#keep_crc"); > cmdline_parse_token_string_t > cmd_config_per_port_rx_offload_result_on_off = > TOKEN_STRING_INITIALIZER > (struct cmd_config_per_port_rx_offload_result, > @@ -16744,7 +16744,7 @@ struct cmd_config_per_port_rx_offload_result > { > .help_str = "port config <port_id> rx_offload vlan_strip|ipv4_cksum|" > > "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" > "macsec_strip|header_split|vlan_filter|vlan_extend|" > - "jumbo_frame|crc_strip|scatter|timestamp|security " > + > "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " > "on|off", > .tokens = { > (void *)&cmd_config_per_port_rx_offload_result_port, > @@ -16794,7 +16794,7 @@ struct > cmd_config_per_queue_rx_offload_result { > offload, > "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" > "qinq_strip#outer_ipv4_cksum#macsec_strip#" > "header_split#vlan_filter#vlan_extend#jumbo_frame#" > - "crc_strip#scatter#timestamp#security"); > + "crc_strip#scatter#timestamp#security#keep_crc"); > cmdline_parse_token_string_t > cmd_config_per_queue_rx_offload_result_on_off = > TOKEN_STRING_INITIALIZER > (struct cmd_config_per_queue_rx_offload_result, > @@ -16846,7 +16846,7 @@ struct > cmd_config_per_queue_rx_offload_result { > "vlan_strip|ipv4_cksum|" > > "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" > "macsec_strip|header_split|vlan_filter|vlan_extend|" > - "jumbo_frame|crc_strip|scatter|timestamp|security " > + > "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " > "on|off", > .tokens = { > (void *)&cmd_config_per_queue_rx_offload_result_port, > @@ -17063,7 +17063,7 @@ struct cmd_config_per_port_tx_offload_result > { > "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" > "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" > "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" > - "mt_lockfree#multi_segs#fast_free#security"); > + "mt_lockfree#multi_segs#mbuf_fast_free#security"); > cmdline_parse_token_string_t > cmd_config_per_port_tx_offload_result_on_off = > TOKEN_STRING_INITIALIZER > (struct cmd_config_per_port_tx_offload_result, > @@ -17144,7 +17144,7 @@ struct cmd_config_per_port_tx_offload_result > { > "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" > "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" > "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" > - "mt_lockfree|multi_segs|fast_free|security " > + "mt_lockfree|multi_segs|mbuf_fast_free|security " > "on|off", > .tokens = { > (void *)&cmd_config_per_port_tx_offload_result_port, > @@ -17195,7 +17195,7 @@ struct > cmd_config_per_queue_tx_offload_result { > "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" > "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" > "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" > - "mt_lockfree#multi_segs#fast_free#security"); > + "mt_lockfree#multi_segs#mbuf_fast_free#security"); > cmdline_parse_token_string_t > cmd_config_per_queue_tx_offload_result_on_off = > TOKEN_STRING_INITIALIZER > (struct cmd_config_per_queue_tx_offload_result, > @@ -17248,7 +17248,7 @@ struct > cmd_config_per_queue_tx_offload_result { > "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" > "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" > "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" > - "mt_lockfree|multi_segs|fast_free|security " > + "mt_lockfree|multi_segs|mbuf_fast_free|security " > "on|off", > .tokens = { > (void *)&cmd_config_per_queue_tx_offload_result_port, > -- > 1.8.3.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-08-05 10:41 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-24 3:45 [PATCH] app/testpmd: fix commands to config some offload Wei Dai
2018-07-24 14:22 ` Iremonger, Bernard
2018-08-02 1:41 ` Dai, Wei
2018-07-25 3:29 ` Peng, Yuan
2018-08-02 1:32 ` Wei Dai
2018-08-02 9:11 ` Iremonger, Bernard
2018-08-03 12:53 ` Dai, Wei
2018-08-03 12:55 ` [PATCH v3] " Wei Dai
2018-08-05 10:41 ` Thomas Monjalon
[not found] <1532054553-21844-1-git-send-email-wei.dai@intel.com>
2018-07-20 3:20 ` [PATCH] " Peng, Yuan
[not found] <1532002875-29504-1-git-send-email-wei.dai@intel.com>
2018-07-20 2:34 ` Dai, Wei
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.