All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ricardo Maraschini <xrmarsx@gmail.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-media@vger.kernel.org, doug <dougsland@gmail.com>,
	mchehab@redhat.com
Subject: Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb
Date: Tue, 23 Mar 2010 19:47:05 -0300	[thread overview]
Message-ID: <499b283a1003231547k1e7f8060x53a4ea5ec43236d4@mail.gmail.com> (raw)
In-Reply-To: <4BA91A44.4090709@oracle.com>

Hi Randy,

On Tue, Mar 23, 2010 at 4:45 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> Did you test this patch (by building this driver)?
> I think not.

I tried to compile with the patch, but in a wrong way. Sorry.
I'm going to adjust the patch and send again.

> Also, the Signed-off-by: line should be before the patch, not after it.

Thanks, I will remember this.

-rm

  reply	other threads:[~2010-03-23 22:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-23 20:42 [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb Ricardo Maraschini
2010-03-23 19:45 ` Randy Dunlap
2010-03-23 22:47   ` Ricardo Maraschini [this message]
2010-03-24 13:27     ` Ricardo Maraschini
2010-03-24 13:45       ` Douglas Schilling Landgraf
2010-04-06 19:12         ` Hans Verkuil
2010-03-23 20:48 ` Devin Heitmueller
2010-03-23 22:48   ` Ricardo Maraschini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=499b283a1003231547k1e7f8060x53a4ea5ec43236d4@mail.gmail.com \
    --to=xrmarsx@gmail.com \
    --cc=dougsland@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.