All of lore.kernel.org
 help / color / mirror / Atom feed
From: Devin Heitmueller <dheitmueller@kernellabs.com>
To: Ricardo Maraschini <xrmarsx@gmail.com>
Cc: linux-media@vger.kernel.org, doug <dougsland@gmail.com>,
	mchehab@redhat.com
Subject: Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb
Date: Tue, 23 Mar 2010 16:48:22 -0400	[thread overview]
Message-ID: <829197381003231348h5c09c76av1adfbf7f13df10a1@mail.gmail.com> (raw)
In-Reply-To: <499b283a1003231342h6fcbe74di2aa67eb91b18cf0c@mail.gmail.com>

On Tue, Mar 23, 2010 at 4:42 PM, Ricardo Maraschini <xrmarsx@gmail.com> wrote:
> --- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 16:17:11 2010 -0300
> +++ b/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:29:29 2010 -0300
> @@ -1401,7 +1401,8 @@
>       case CX88_BOARD_SAMSUNG_SMT_7020:
>               dev->ts_gen_cntrl = 0x08;
>
> -               struct cx88_core *core = dev->core;
> +               struct cx88_core *core;
> +               core = dev->core;
>
>               cx_set(MO_GP0_IO, 0x0101);
>
>
>
> Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>

How do you think this actually addresses the warning in question?  You
still have the declaration of the variable in the middle of the switch
statement.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com

  parent reply	other threads:[~2010-03-23 20:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-23 20:42 [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb Ricardo Maraschini
2010-03-23 19:45 ` Randy Dunlap
2010-03-23 22:47   ` Ricardo Maraschini
2010-03-24 13:27     ` Ricardo Maraschini
2010-03-24 13:45       ` Douglas Schilling Landgraf
2010-04-06 19:12         ` Hans Verkuil
2010-03-23 20:48 ` Devin Heitmueller [this message]
2010-03-23 22:48   ` Ricardo Maraschini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=829197381003231348h5c09c76av1adfbf7f13df10a1@mail.gmail.com \
    --to=dheitmueller@kernellabs.com \
    --cc=dougsland@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=xrmarsx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.