From: phcoder <phcoder@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] make partition active
Date: Sun, 01 Mar 2009 22:20:23 +0100 [thread overview]
Message-ID: <49AAFC17.7040608@gmail.com> (raw)
In-Reply-To: <ca0f59980903011058o8258cc4hface04827dd9fdc6@mail.gmail.com>
Hello
>> It's also possible to write a wrapper
>> parttool hd0,1 boot+
>>
>> Which chooses the correct tool and launches it (a tool can be easily
>> registered as a pair of partition style name and a function). In this case
>> we wouldn't even need separate command for different partition style. We
>> have however to find a way to list all available flags in
>>
>> help parttool
>
> Hi,
>
> The patch looks fine to me, except for perhaps the name. activate
> doesn't seems to suggest its function. Frankly, makeactive doesn't
> make much sense as well, but at least it's already widely used in grub
> legacy, old user could easily guess its function by name.
>
Then we could use parttool syntax. Then parttype can be implemented like
grub> parttool hd0,1 type=7
makeactive like:
grub> parttool hd0,1 boot+
And it can even be done by one command
grub> parttool hd0,1 boot+ type=7
Thank you for your attention to my patches
--
Regards
Vladimir 'phcoder' Serbinenko
next prev parent reply other threads:[~2009-03-01 21:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 13:43 [PATCH] make partition active phcoder
2009-02-11 16:26 ` Pavel Roskin
2009-02-11 18:28 ` phcoder
2009-03-01 18:58 ` Bean
2009-03-01 21:20 ` phcoder [this message]
2009-03-02 3:52 ` Bean
2009-03-04 20:54 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AAFC17.7040608@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.