Re: [PATCH] MX1 fix include

Re: [PATCH] MX1 fix include

[Paulius Zaleckas]

Darius wrote:
> Sascha Hauer wrote:
>> On Mon, Jan 12, 2009 at 04:22:57PM +0200, Darius wrote:
>>> From: Darius Augulis <augulis.darius@gmail.com>
>>>
>>> Includes missed irqs.h in devices.c and mx1ads.c.
>> Looks good, thanks.
> 
> Hi Sascha,
> 
> probably you forgot to merge this in next rc (2), please do this ASAP in next rc, if possible.

Hi Sasha,

Will you submit this patch upstream?
It is definitely 2.6.29 material since it is not possible to compile MX1 without it!

Paulius Zaleckas

> BR,
> Darius
> 
>> BTW do you plan to integrate the missing pieces from arch-imx into
>> arch-mx1, like SDHC and framebuffer? I think we should add these before
>> removing arch-imx.
>>
>> Sascha
>>
>>> Signed-off-by: Darius Augulis <augulis.darius@gmail.com>
>>>
>>> Index: linux-2.6.29-rc1/arch/arm/mach-mx1/devices.c
>>> ===================================================================
>>> --- linux-2.6.29-rc1.orig/arch/arm/mach-mx1/devices.c
>>> +++ linux-2.6.29-rc1/arch/arm/mach-mx1/devices.c
>>> @@ -23,6 +23,8 @@
>>>  #include <linux/init.h>
>>>  #include <linux/platform_device.h>
>>>  #include <linux/gpio.h>
>>> +
>>> +#include <mach/irqs.h>
>>>  #include <mach/hardware.h>
>>>  
>>>  static struct resource imx_csi_resources[] = {
>>> Index: linux-2.6.29-rc1/arch/arm/mach-mx1/mx1ads.c
>>> ===================================================================
>>> --- linux-2.6.29-rc1.orig/arch/arm/mach-mx1/mx1ads.c
>>> +++ linux-2.6.29-rc1/arch/arm/mach-mx1/mx1ads.c
>>> @@ -21,6 +21,7 @@
>>>  #include <asm/mach/arch.h>
>>>  #include <asm/mach/time.h>
>>>  
>>> +#include <mach/irqs.h>
>>>  #include <mach/hardware.h>
>>>  #include <mach/common.h>
>>>  #include <mach/imx-uart.h>
>>> -------------------------------------------------------------------
>>> List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
>>> FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
>>> Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php
>>>
> 
> 
> -------------------------------------------------------------------
> List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
> FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
> Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php
>