Re: [linuxtv-commits] [hg:v4l-dvb] Fix I2C bridge error in zl10353

Re: [linuxtv-commits] [hg:v4l-dvb] Fix I2C bridge error in zl10353

[Antti Palosaari]

Hello,
This patch breaks devices using tuner behind zl10353 i2c-gate.
au6610:
Sigmatek DVB-110 DVB-T USB2.0

gl861:
MSI Mega Sky 55801 DVB-T USB2.0
A-LINK DTU DVB-T USB2.0

Probably some other too.

I think it is better to disable i2c-gate setting callback to NULL after 
demod attach like dtv5100 does this.

Also .no_tuner is bad name what it does currently. My opinion is that 
current .no_tuner = 1 should be set as default, because most 
configuration does not this kind of slave tuner setup where tuner is 
programmed by demod.
Change no_tuner to slave_tuner and set slave_tuner = 1 only when needed 
(not many drivers using that).

Here is small scheme to clear tuner cotrolling issues.
http://www.otit.fi/~crope/v4l-dvb/controlling_tuner.txt

regards
Antti

Patch from Dmitri Belimov wrote:
> The patch number 10151 was added via Mauro Carvalho Chehab <mchehab@redhat.com>
> to http://linuxtv.org/hg/v4l-dvb master development tree.
> 
> Kernel patches in this development tree may be modified to be backward
> compatible with older kernels. Compatibility modifications will be
> removed before inclusion into the mainstream Kernel
> 
> If anyone has any objections, please let us know by sending a message to:
> 	v4l-dvb-maintainer@linuxtv.org
> 
> ------
> 
> From: Dmitri Belimov  <d.belimov@gmail.com>
> Fix I2C bridge error in zl10353
> 
> 
> Fix I2C bridge error in zl10353 if no tunner attached to internal I2C
> bus of zl10353 chip.
> 
> When set enable bridge from internal I2C bus to the main I2C bus
> (saa7134) the main I2C bus stopped very hardly. No any communication. In
> our next board we solder additional resistors to internal I2C bus.
> 
> Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov <d.belimov@gmail.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> 
> 
> ---
> 
>  linux/drivers/media/dvb/frontends/zl10353.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff -r 166b13cf6fcd -r 24e51eac4234 linux/drivers/media/dvb/frontends/zl10353.c
> --- a/linux/drivers/media/dvb/frontends/zl10353.c	Wed Nov 12 15:04:28 2008 +0000
> +++ b/linux/drivers/media/dvb/frontends/zl10353.c	Tue Dec 23 06:50:09 2008 +0000
> @@ -598,7 +598,14 @@ static int zl10353_init(struct dvb_front
>  
>  static int zl10353_i2c_gate_ctrl(struct dvb_frontend* fe, int enable)
>  {
> +	struct zl10353_state *state = fe->demodulator_priv;
>  	u8 val = 0x0a;
> +
> +	if (state->config.no_tuner) {
> +		/* No tuner attached to the internal I2C bus */
> +		/* If set enable I2C bridge, the main I2C bus stopped hardly */
> +		return 0;
> +	}
>  
>  	if (enable)
>  		val |= 0x10;
> 
> 
> ---
> 
> Patch is available at: http://linuxtv.org/hg/v4l-dvb/rev/24e51eac4234f118d51b386c6e3168e8d8f461ae
> 
> _______________________________________________
> linuxtv-commits mailing list
> linuxtv-commits@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits


-- 
http://palosaari.fi/

Re: [linuxtv-commits] [hg:v4l-dvb] Fix I2C bridge error in zl10353

[Antti Palosaari]

Mauro,
Could you remove this bad patch patch soon? It must not go to the final 
2.6.29 as it breaks so many old devices. One of those is MSI Megasky 580 
which is rather popular.

regards
Antti

Antti Palosaari wrote:
> Hello,
> This patch breaks devices using tuner behind zl10353 i2c-gate.
> au6610:
> Sigmatek DVB-110 DVB-T USB2.0
> 
> gl861:
> MSI Mega Sky 55801 DVB-T USB2.0
> A-LINK DTU DVB-T USB2.0
> 
> Probably some other too.
> 
> I think it is better to disable i2c-gate setting callback to NULL after 
> demod attach like dtv5100 does this.
> 
> Also .no_tuner is bad name what it does currently. My opinion is that 
> current .no_tuner = 1 should be set as default, because most 
> configuration does not this kind of slave tuner setup where tuner is 
> programmed by demod.
> Change no_tuner to slave_tuner and set slave_tuner = 1 only when needed 
> (not many drivers using that).
> 
> Here is small scheme to clear tuner cotrolling issues.
> http://www.otit.fi/~crope/v4l-dvb/controlling_tuner.txt
> 
> regards
> Antti
> 
> Patch from Dmitri Belimov wrote:
>> The patch number 10151 was added via Mauro Carvalho Chehab 
>> <mchehab@redhat.com>
>> to http://linuxtv.org/hg/v4l-dvb master development tree.
>>
>> Kernel patches in this development tree may be modified to be backward
>> compatible with older kernels. Compatibility modifications will be
>> removed before inclusion into the mainstream Kernel
>>
>> If anyone has any objections, please let us know by sending a message to:
>>     v4l-dvb-maintainer@linuxtv.org
>>
>> ------
>>
>> From: Dmitri Belimov  <d.belimov@gmail.com>
>> Fix I2C bridge error in zl10353
>>
>>
>> Fix I2C bridge error in zl10353 if no tunner attached to internal I2C
>> bus of zl10353 chip.
>>
>> When set enable bridge from internal I2C bus to the main I2C bus
>> (saa7134) the main I2C bus stopped very hardly. No any communication. In
>> our next board we solder additional resistors to internal I2C bus.
>>
>> Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov <d.belimov@gmail.com>
>> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>>
>>
>> ---
>>
>>  linux/drivers/media/dvb/frontends/zl10353.c |    7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff -r 166b13cf6fcd -r 24e51eac4234 
>> linux/drivers/media/dvb/frontends/zl10353.c
>> --- a/linux/drivers/media/dvb/frontends/zl10353.c    Wed Nov 12 
>> 15:04:28 2008 +0000
>> +++ b/linux/drivers/media/dvb/frontends/zl10353.c    Tue Dec 23 
>> 06:50:09 2008 +0000
>> @@ -598,7 +598,14 @@ static int zl10353_init(struct dvb_front
>>  
>>  static int zl10353_i2c_gate_ctrl(struct dvb_frontend* fe, int enable)
>>  {
>> +    struct zl10353_state *state = fe->demodulator_priv;
>>      u8 val = 0x0a;
>> +
>> +    if (state->config.no_tuner) {
>> +        /* No tuner attached to the internal I2C bus */
>> +        /* If set enable I2C bridge, the main I2C bus stopped hardly */
>> +        return 0;
>> +    }
>>  
>>      if (enable)
>>          val |= 0x10;
>>
>>
>> ---
>>
>> Patch is available at: 
>> http://linuxtv.org/hg/v4l-dvb/rev/24e51eac4234f118d51b386c6e3168e8d8f461ae 
>>
>>
>> _______________________________________________
>> linuxtv-commits mailing list
>> linuxtv-commits@linuxtv.org
>> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits
> 
> 


-- 
http://palosaari.fi/

Re: [linuxtv-commits] [hg:v4l-dvb] Fix I2C bridge error in zl10353

[Mauro Carvalho Chehab]

On Tue, 10 Mar 2009 12:09:48 +0200
Antti Palosaari <crope@iki.fi> wrote:

> Mauro,
> Could you remove this bad patch patch soon? It must not go to the final 
> 2.6.29 as it breaks so many old devices. One of those is MSI Megasky 580 
> which is rather popular.

> 
> regards
> Antti
> 
> Antti Palosaari wrote:
> > Hello,
> > This patch breaks devices using tuner behind zl10353 i2c-gate.
> > au6610:
> > Sigmatek DVB-110 DVB-T USB2.0
> > 
> > gl861:
> > MSI Mega Sky 55801 DVB-T USB2.0
> > A-LINK DTU DVB-T USB2.0
> > 
> > Probably some other too.
> > 
> > I think it is better to disable i2c-gate setting callback to NULL after 
> > demod attach like dtv5100 does this.
> > 
> > Also .no_tuner is bad name what it does currently. My opinion is that 
> > current .no_tuner = 1 should be set as default, because most 
> > configuration does not this kind of slave tuner setup where tuner is 
> > programmed by demod.
> > Change no_tuner to slave_tuner and set slave_tuner = 1 only when needed 
> > (not many drivers using that).

Hi Antti/Dmitri,

I agree that no_tuner is a bad name. The best is to rename it to something like
"tuner_is_behind_bridge". If equal to 1, then it will use the new behaviour,
otherwise the old one, and fix the boards where this trouble were found.

Could one of you please do such patchset?

Thanks,
Mauro.

Re: [linuxtv-commits] [hg:v4l-dvb] Fix I2C bridge error in zl10353

[Dmitri Belimov]

Hi Mauro

> On Tue, 10 Mar 2009 12:09:48 +0200
> Antti Palosaari <crope@iki.fi> wrote:
> 
> > Mauro,
> > Could you remove this bad patch patch soon? It must not go to the
> > final 2.6.29 as it breaks so many old devices. One of those is MSI
> > Megasky 580 which is rather popular.
> 
> > 
> > regards
> > Antti
> > 
> > Antti Palosaari wrote:
> > > Hello,
> > > This patch breaks devices using tuner behind zl10353 i2c-gate.
> > > au6610:
> > > Sigmatek DVB-110 DVB-T USB2.0
> > > 
> > > gl861:
> > > MSI Mega Sky 55801 DVB-T USB2.0
> > > A-LINK DTU DVB-T USB2.0
> > > 
> > > Probably some other too.
> > > 
> > > I think it is better to disable i2c-gate setting callback to NULL
> > > after demod attach like dtv5100 does this.
> > > 
> > > Also .no_tuner is bad name what it does currently. My opinion is
> > > that current .no_tuner = 1 should be set as default, because most 
> > > configuration does not this kind of slave tuner setup where tuner
> > > is programmed by demod.
> > > Change no_tuner to slave_tuner and set slave_tuner = 1 only when
> > > needed (not many drivers using that).
> 
> Hi Antti/Dmitri,
> 
> I agree that no_tuner is a bad name. The best is to rename it to
> something like "tuner_is_behind_bridge". If equal to 1, then it will
> use the new behaviour, otherwise the old one, and fix the boards
> where this trouble were found.
> 
> Could one of you please do such patchset?

I haven't a lot expirience with kernel programming. If Antti can it is good. I'll check it
on our board.

With my best regards, Dmitry.

Re: [linuxtv-commits] [hg:v4l-dvb] Fix I2C bridge error in zl10353

[Antti Palosaari]

Dmitri Belimov wrote:
>> Could one of you please do such patchset?
> 
> I haven't a lot expirience with kernel programming. If Antti can it is good. I'll check it
> on our board.

OK, I will do. For the first phase and as a bug fix I will do that 
(disable i2c-gate) like dtv5100 driver does. After that I will add new 
configuration switch for i2c-gate disable and also change .no_tuner name 
to better one.

regards
Antti

Re: [linuxtv-commits] [hg:v4l-dvb] Fix I2C bridge error in zl10353

[Antti Palosaari]

Antti Palosaari wrote:
> Dmitri Belimov wrote:
>>> Could one of you please do such patchset?
>>
>> I haven't a lot expirience with kernel programming. If Antti can it is 
>> good. I'll check it
>> on our board.
> 
> OK, I will do. For the first phase and as a bug fix I will do that 
> (disable i2c-gate) like dtv5100 driver does. After that I will add new 
> configuration switch for i2c-gate disable and also change .no_tuner name 
> to better one.

Here it is, please review and test. I kept changes as small as possible 
to prevent errors. Lets fix more later.

http://linuxtv.org/hg/~anttip/zl10353/

regards
Antti
-- 
http://palosaari.fi/

Re: [linuxtv-commits] [hg:v4l-dvb] Fix I2C bridge error in zl10353

[Dmitri Belimov]

Hi Antti

> Antti Palosaari wrote:
> > Dmitri Belimov wrote:
> >>> Could one of you please do such patchset?
> >>
> >> I haven't a lot expirience with kernel programming. If Antti can
> >> it is good. I'll check it
> >> on our board.
> > 
> > OK, I will do. For the first phase and as a bug fix I will do that 
> > (disable i2c-gate) like dtv5100 driver does. After that I will add
> > new configuration switch for i2c-gate disable and also
> > change .no_tuner name to better one.
> 
> Here it is, please review and test. I kept changes as small as
> possible to prevent errors. Lets fix more later.
> 
> http://linuxtv.org/hg/~anttip/zl10353/

Looks good.

Tomorrow I make some tests and write my results.

With my best regards, Dmitry.

> 
> regards
> Antti
> -- 
> http://palosaari.fi/

Re: [linuxtv-commits] [hg:v4l-dvb] Fix I2C bridge error in zl10353

[Dmitri Belimov]

Hi Antti

> Antti Palosaari wrote:
> > Dmitri Belimov wrote:
> >>> Could one of you please do such patchset?
> >>
> >> I haven't a lot expirience with kernel programming. If Antti can
> >> it is good. I'll check it
> >> on our board.
> > 
> > OK, I will do. For the first phase and as a bug fix I will do that 
> > (disable i2c-gate) like dtv5100 driver does. After that I will add
> > new configuration switch for i2c-gate disable and also
> > change .no_tuner name to better one.
> 
> Here it is, please review and test. I kept changes as small as
> possible to prevent errors. Lets fix more later.
> 
> http://linuxtv.org/hg/~anttip/zl10353/

This patch is good. All work is ok.

With my best regards, Dmitry.

> 
> regards
> Antti
> -- 
> http://palosaari.fi/

Re: [linuxtv-commits] [hg:v4l-dvb] Fix I2C bridge error in zl10353

[Mauro Carvalho Chehab]

On Thu, 12 Mar 2009 12:35:40 +0900
Dmitri Belimov <d.belimov@gmail.com> wrote:

> Hi Antti
> 
> > Antti Palosaari wrote:
> > > Dmitri Belimov wrote:
> > >>> Could one of you please do such patchset?
> > >>
> > >> I haven't a lot expirience with kernel programming. If Antti can
> > >> it is good. I'll check it
> > >> on our board.
> > > 
> > > OK, I will do. For the first phase and as a bug fix I will do that 
> > > (disable i2c-gate) like dtv5100 driver does. After that I will add
> > > new configuration switch for i2c-gate disable and also
> > > change .no_tuner name to better one.
> > 
> > Here it is, please review and test. I kept changes as small as
> > possible to prevent errors. Lets fix more later.
> > 
> > http://linuxtv.org/hg/~anttip/zl10353/
> 
> This patch is good. All work is ok.

Antti,

since you said that this patch should go to 2.6.29, I've already merged from
your tree, after having Dmitry ack.
> 
> With my best regards, Dmitry.
> 
> > 
> > regards
> > Antti
> > -- 
> > http://palosaari.fi/




Cheers,
Mauro

Re: [linuxtv-commits] [hg:v4l-dvb] Fix I2C bridge error in zl10353

[Antti Palosaari]

Mauro Carvalho Chehab wrote:
> On Thu, 12 Mar 2009 12:35:40 +0900
> Dmitri Belimov <d.belimov@gmail.com> wrote:
> 
>> Hi Antti
>>
>>> Antti Palosaari wrote:
>>>> Dmitri Belimov wrote:
>>>>>> Could one of you please do such patchset?
>>>>> I haven't a lot expirience with kernel programming. If Antti can
>>>>> it is good. I'll check it
>>>>> on our board.
>>>> OK, I will do. For the first phase and as a bug fix I will do that 
>>>> (disable i2c-gate) like dtv5100 driver does. After that I will add
>>>> new configuration switch for i2c-gate disable and also
>>>> change .no_tuner name to better one.
>>> Here it is, please review and test. I kept changes as small as
>>> possible to prevent errors. Lets fix more later.
>>>
>>> http://linuxtv.org/hg/~anttip/zl10353/
>> This patch is good. All work is ok.
> 
> Antti,
> 
> since you said that this patch should go to 2.6.29, I've already merged from
> your tree, after having Dmitry ack.

Thanks.

Antti