All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kvm-userspace: Fix twisted kvm_arch_get/put_registers
@ 2009-03-16 18:36 Jan Kiszka
  2009-03-17  8:27 ` Avi Kivity
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2009-03-16 18:36 UTC (permalink / raw)
  To: Avi Kivity; +Cc: kvm-devel

[ Get, save, synchronize, put... hell. Reminds me: what's the schedule
for finally dropping libkvm? ]

Fix this fallout from recent qemu-trunk merge, it broke guest debugging.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

 qemu/qemu-kvm.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/qemu/qemu-kvm.h b/qemu/qemu-kvm.h
index 4a3ba53..c0549df 100644
--- a/qemu/qemu-kvm.h
+++ b/qemu/qemu-kvm.h
@@ -212,12 +212,12 @@ static inline int kvm_sync_vcpus(void) { return 0; }
 
 static inline void kvm_arch_get_registers(CPUState *env)
 {
-    kvm_load_registers(env);
+    kvm_save_registers(env);
 }
 
 static inline void kvm_arch_put_registers(CPUState *env)
 {
-    kvm_save_registers(env);
+    kvm_load_registers(env);
 }
 
 static inline void cpu_synchronize_state(CPUState *env, int modified)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] kvm-userspace: Fix twisted kvm_arch_get/put_registers
  2009-03-16 18:36 [PATCH] kvm-userspace: Fix twisted kvm_arch_get/put_registers Jan Kiszka
@ 2009-03-17  8:27 ` Avi Kivity
  0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2009-03-17  8:27 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: kvm-devel

Jan Kiszka wrote:
> [ Get, save, synchronize, put... hell. Reminds me: what's the schedule
> for finally dropping libkvm? ]
>
>   

Patches welcome.

I expect this will become much easier once qemu merges iothread and smp 
support.  Then we can feed qemu-kvm.c into kvm.c and then into upstream.

> Fix this fallout from recent qemu-trunk merge, it broke guest debugging.
>   

Applied, thanks.

-- 
error compiling committee.c: too many arguments to function


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-03-17  8:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-16 18:36 [PATCH] kvm-userspace: Fix twisted kvm_arch_get/put_registers Jan Kiszka
2009-03-17  8:27 ` Avi Kivity

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.