All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] UBIFS: Missing offset relocation for compressor 'none'
@ 2009-03-19  8:10 Michael Lawnick
  2009-03-19  8:43 ` Michael Lawnick
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Lawnick @ 2009-03-19  8:10 UTC (permalink / raw)
  To: u-boot

On systems where U-Boot is linked to another address than it really lays
(e.g. backup image), calls via function pointers must be fixed with a
'+= gd->reloc_off'.
This was not done for none_compr in ubifs_compressors_init() what leads
to system crash on ubifsmount command.

Signed-off-by: Michael Lawnick <ml.lawnick@gmx.de>
---
 fs/ubifs.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff -Naur a/fs/ubifs/ubifs.c b/fs/ubifs/ubifs.c
--- a/fs/ubifs/ubifs.c 2009-02-20 16:02:44.434443000 +0100
+++ b/fs/ubifs/ubifs.c 2009-03-18 16:06:09.000000000 +0100

@@ -147,7 +147,7 @@ int __init ubifs_compressors_init(void)
        if (err)
                return err;

-       ubifs_compressors[UBIFS_COMPR_NONE] = &none_compr;
+       ubifs_compressors[UBIFS_COMPR_NONE] = compr_init(&none_compr);
        return 0;
 }
 --
Kind regards,
Michael

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] UBIFS: Missing offset relocation for compressor 'none'
  2009-03-19  8:10 [U-Boot] [PATCH] UBIFS: Missing offset relocation for compressor 'none' Michael Lawnick
@ 2009-03-19  8:43 ` Michael Lawnick
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Lawnick @ 2009-03-19  8:43 UTC (permalink / raw)
  To: u-boot

Michael Lawnick said the following:
> On systems where U-Boot is linked to another address than it really lays
> (e.g. backup image), calls via function pointers must be fixed with a
> '+= gd->reloc_off'.
> This was not done for none_compr in ubifs_compressors_init() what leads
> to system crash on ubifsmount command.
> 
> Signed-off-by: Michael Lawnick <ml.lawnick@gmx.de>
> ---
What now followed is rubbish and works by chance. Please ignore, correct
patch in a few hours.

Sorry :-(

-- 
Regards,
Michael

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-03-19  8:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-19  8:10 [U-Boot] [PATCH] UBIFS: Missing offset relocation for compressor 'none' Michael Lawnick
2009-03-19  8:43 ` Michael Lawnick

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.