* [PATCH resend] bsg: Remove bogus check against request_queue->max_sectors
@ 2009-03-19 9:05 Boaz Harrosh
2009-03-24 11:37 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Boaz Harrosh @ 2009-03-19 9:05 UTC (permalink / raw)
To: Jens Axboe, FUJITA Tomonori, linux-scsi, open-osd mailing-list
bsg submits REQ_TYPE_BLOCK_PC so the right check is max_hw_sectors.
But I've removed this check because right after, bsg proceeds with
calling blk_rq_map_user() which does all the right checks.
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
block/bsg.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/block/bsg.c b/block/bsg.c
index 0ce8806..44a2a0f 100644
--- a/block/bsg.c
+++ b/block/bsg.c
@@ -218,9 +218,6 @@ bsg_validate_sgv4_hdr(struct request_queue *q, struct sg_io_v4 *hdr, int *rw)
if (hdr->guard != 'Q')
return -EINVAL;
- if (hdr->dout_xfer_len > (q->max_sectors << 9) ||
- hdr->din_xfer_len > (q->max_sectors << 9))
- return -EIO;
switch (hdr->protocol) {
case BSG_PROTOCOL_SCSI:
--
1.6.2.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH resend] bsg: Remove bogus check against request_queue->max_sectors
2009-03-19 9:05 [PATCH resend] bsg: Remove bogus check against request_queue->max_sectors Boaz Harrosh
@ 2009-03-24 11:37 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2009-03-24 11:37 UTC (permalink / raw)
To: Boaz Harrosh; +Cc: FUJITA Tomonori, linux-scsi, open-osd mailing-list
On Thu, Mar 19 2009, Boaz Harrosh wrote:
>
> bsg submits REQ_TYPE_BLOCK_PC so the right check is max_hw_sectors.
> But I've removed this check because right after, bsg proceeds with
> calling blk_rq_map_user() which does all the right checks.
>
> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
> ---
> block/bsg.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/block/bsg.c b/block/bsg.c
> index 0ce8806..44a2a0f 100644
> --- a/block/bsg.c
> +++ b/block/bsg.c
> @@ -218,9 +218,6 @@ bsg_validate_sgv4_hdr(struct request_queue *q, struct sg_io_v4 *hdr, int *rw)
>
> if (hdr->guard != 'Q')
> return -EINVAL;
> - if (hdr->dout_xfer_len > (q->max_sectors << 9) ||
> - hdr->din_xfer_len > (q->max_sectors << 9))
> - return -EIO;
>
> switch (hdr->protocol) {
> case BSG_PROTOCOL_SCSI:
Applied
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-24 11:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-19 9:05 [PATCH resend] bsg: Remove bogus check against request_queue->max_sectors Boaz Harrosh
2009-03-24 11:37 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.