* [PATCH] nfs-utils: reverse order of librpcsecgss and libgssglue checks
@ 2009-04-06 15:58 Chuck Lever
[not found] ` <20090406155735.6991.31157.stgit-07a7zB5ZJzbwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Chuck Lever @ 2009-04-06 15:58 UTC (permalink / raw)
To: steved; +Cc: linux-nfs
The check that validates the version of librpcsecgss also needs to
have libgssglue installed. Without libgssglue, ./configure complains
that it can't find rpcsecgss, even though it's installed.
It also turns out that the error message generated by pkg-config is
more complete than the one we have in aclocal/rpcsec_vers.m4, so just
let those PKG_CHECK_MODULES m4 macros use the default error message.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
Hi Steve-
One more minor bugfix for configure.ac....
aclocal/rpcsec_vers.m4 | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/aclocal/rpcsec_vers.m4 b/aclocal/rpcsec_vers.m4
index e59c0aa..25902ca 100644
--- a/aclocal/rpcsec_vers.m4
+++ b/aclocal/rpcsec_vers.m4
@@ -1,12 +1,11 @@
dnl Checks librpcsec version
AC_DEFUN([AC_RPCSEC_VERSION], [
- dnl TI-RPC replaces librpcsecgss, but we still need libgssglue
+ PKG_CHECK_MODULES([GSSGLUE], [libgssglue >= 0.1])
+
+ dnl TI-RPC replaces librpcsecgss
if test "$enable_tirpc" = no; then
- PKG_CHECK_MODULES([RPCSECGSS], [librpcsecgss >= 0.16], ,
- [AC_MSG_ERROR([Unable to locate information required to use librpcsecgss. If you have pkgconfig installed, you might try setting environment variable PKG_CONFIG_PATH to /usr/local/lib/pkgconfig])])
- else
- PKG_CHECK_MODULES([GSSGLUE], [libgssglue >= 0.1])
+ PKG_CHECK_MODULES([RPCSECGSS], [librpcsecgss >= 0.16])
fi
])dnl
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nfs-utils: reverse order of librpcsecgss and libgssglue checks
[not found] ` <20090406155735.6991.31157.stgit-07a7zB5ZJzbwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org>
@ 2009-04-15 17:59 ` Steve Dickson
0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2009-04-15 17:59 UTC (permalink / raw)
To: Chuck Lever; +Cc: linux-nfs
Chuck Lever wrote:
> The check that validates the version of librpcsecgss also needs to
> have libgssglue installed. Without libgssglue, ./configure complains
> that it can't find rpcsecgss, even though it's installed.
>
> It also turns out that the error message generated by pkg-config is
> more complete than the one we have in aclocal/rpcsec_vers.m4, so just
> let those PKG_CHECK_MODULES m4 macros use the default error message.
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>
> Hi Steve-
>
> One more minor bugfix for configure.ac....
>
> aclocal/rpcsec_vers.m4 | 9 ++++-----
> 1 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/aclocal/rpcsec_vers.m4 b/aclocal/rpcsec_vers.m4
> index e59c0aa..25902ca 100644
> --- a/aclocal/rpcsec_vers.m4
> +++ b/aclocal/rpcsec_vers.m4
> @@ -1,12 +1,11 @@
> dnl Checks librpcsec version
> AC_DEFUN([AC_RPCSEC_VERSION], [
>
> - dnl TI-RPC replaces librpcsecgss, but we still need libgssglue
> + PKG_CHECK_MODULES([GSSGLUE], [libgssglue >= 0.1])
> +
> + dnl TI-RPC replaces librpcsecgss
> if test "$enable_tirpc" = no; then
> - PKG_CHECK_MODULES([RPCSECGSS], [librpcsecgss >= 0.16], ,
> - [AC_MSG_ERROR([Unable to locate information required to use librpcsecgss. If you have pkgconfig installed, you might try setting environment variable PKG_CONFIG_PATH to /usr/local/lib/pkgconfig])])
> - else
> - PKG_CHECK_MODULES([GSSGLUE], [libgssglue >= 0.1])
> + PKG_CHECK_MODULES([RPCSECGSS], [librpcsecgss >= 0.16])
> fi
>
> ])dnl
>
Committed...
steved.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-15 18:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-06 15:58 [PATCH] nfs-utils: reverse order of librpcsecgss and libgssglue checks Chuck Lever
[not found] ` <20090406155735.6991.31157.stgit-07a7zB5ZJzbwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org>
2009-04-15 17:59 ` Steve Dickson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.