* [Qemu-devel] [PATCH][RESEND] qemu-io: Fix handling of bdrv_is_allocated() return value
@ 2009-04-14 9:16 Kevin Wolf
2009-04-14 10:52 ` Christoph Hellwig
2009-04-18 15:40 ` [Qemu-devel] " Anthony Liguori
0 siblings, 2 replies; 3+ messages in thread
From: Kevin Wolf @ 2009-04-14 9:16 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, hch
bdrv_is_allocated() returns a boolean which indicates if the offset is
allocated, not 0 on success and everything else is an error.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
qemu-io.c | 12 +++++-------
1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/qemu-io.c b/qemu-io.c
index 466d22c..3e5c444 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -794,6 +794,7 @@ alloc_f(int argc, char **argv)
char s1[64];
int num;
int ret;
+ const char *retstr;
offset = cvtnum(argv[1]);
if (offset & 0x1ff) {
@@ -808,18 +809,15 @@ alloc_f(int argc, char **argv)
nb_sectors = 1;
ret = bdrv_is_allocated(bs, offset >> 9, nb_sectors, &num);
- if (ret) {
- printf("is_allocated: %s", strerror(ret));
- return 0;
- }
cvtstr(offset, s1, sizeof(s1));
+ retstr = ret ? "allocated" : "not allocated";
if (nb_sectors == 1)
- printf("sector allocated at offset %s\n", s1);
+ printf("sector %s at offset %s\n", retstr, s1);
else
- printf("%d/%d sectors allocated at offset %s\n",
- num, nb_sectors, s1);
+ printf("%d/%d sectors %s at offset %s\n",
+ num, nb_sectors, retstr, s1);
return 0;
}
--
1.6.0.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH][RESEND] qemu-io: Fix handling of bdrv_is_allocated() return value
2009-04-14 9:16 [Qemu-devel] [PATCH][RESEND] qemu-io: Fix handling of bdrv_is_allocated() return value Kevin Wolf
@ 2009-04-14 10:52 ` Christoph Hellwig
2009-04-18 15:40 ` [Qemu-devel] " Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2009-04-14 10:52 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, hch
On Tue, Apr 14, 2009 at 11:16:22AM +0200, Kevin Wolf wrote:
> bdrv_is_allocated() returns a boolean which indicates if the offset is
> allocated, not 0 on success and everything else is an error.
Looks good to me.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] Re: [PATCH][RESEND] qemu-io: Fix handling of bdrv_is_allocated() return value
2009-04-14 9:16 [Qemu-devel] [PATCH][RESEND] qemu-io: Fix handling of bdrv_is_allocated() return value Kevin Wolf
2009-04-14 10:52 ` Christoph Hellwig
@ 2009-04-18 15:40 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2009-04-18 15:40 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel, hch
Kevin Wolf wrote:
> bdrv_is_allocated() returns a boolean which indicates if the offset is
> allocated, not 0 on success and everything else is an error.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>
Applied. Thanks.
--
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-18 15:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-14 9:16 [Qemu-devel] [PATCH][RESEND] qemu-io: Fix handling of bdrv_is_allocated() return value Kevin Wolf
2009-04-14 10:52 ` Christoph Hellwig
2009-04-18 15:40 ` [Qemu-devel] " Anthony Liguori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.