[PATCH 5/7] mips cavium-octeon: add parameter to octeon_cvmcount_read()

[PATCH 5/7] mips cavium-octeon: add parameter to octeon_cvmcount_read()

[Coly Li]

This patch modifies parameter of octeon_cvmcount_read() from 'void' to 'struct
clocksource *cs', which fixes compile warning for incompatible parameter type.

Signed-off-by: Coly Li <coly.li@suse.de>
Cc: David Daney <ddaney@caviumnetworks.com>
Cc: Ingo Molnar <mingo@elte.hu>
---
 arch/mips/cavium-octeon/csrc-octeon.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/cavium-octeon/csrc-octeon.c
b/arch/mips/cavium-octeon/csrc-octeon.c
index 70fd92c..96110f2 100644
--- a/arch/mips/cavium-octeon/csrc-octeon.c
+++ b/arch/mips/cavium-octeon/csrc-octeon.c
@@ -38,7 +38,7 @@ void octeon_init_cvmcount(void)
 	local_irq_restore(flags);
 }

-static cycle_t octeon_cvmcount_read(void)
+static cycle_t octeon_cvmcount_read(struct clocksource *cs)
 {
 	return read_c0_cvmcount();
 }

-- 
Coly Li
SuSE Labs

Re: [PATCH 5/7] mips cavium-octeon: add parameter to octeon_cvmcount_read()

[David Daney]

Coly Li wrote:
> This patch modifies parameter of octeon_cvmcount_read() from 'void' to 'struct
> clocksource *cs', which fixes compile warning for incompatible parameter type.
> 
> Signed-off-by: Coly Li <coly.li@suse.de>
> Cc: David Daney <ddaney@caviumnetworks.com>
> Cc: Ingo Molnar <mingo@elte.hu>

It looks good to me:

Reviewed-by: David Daney <ddaney@caviumnetworks.com>


> ---
>  arch/mips/cavium-octeon/csrc-octeon.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/mips/cavium-octeon/csrc-octeon.c
> b/arch/mips/cavium-octeon/csrc-octeon.c
> index 70fd92c..96110f2 100644
> --- a/arch/mips/cavium-octeon/csrc-octeon.c
> +++ b/arch/mips/cavium-octeon/csrc-octeon.c
> @@ -38,7 +38,7 @@ void octeon_init_cvmcount(void)
>  	local_irq_restore(flags);
>  }
> 
> -static cycle_t octeon_cvmcount_read(void)
> +static cycle_t octeon_cvmcount_read(struct clocksource *cs)
>  {
>  	return read_c0_cvmcount();
>  }
> 

Re: [PATCH 5/7] mips cavium-octeon: add parameter to octeon_cvmcount_read()

[Ralf Baechle]

On Wed, Apr 22, 2009 at 01:33:56PM -0700, David Daney wrote:

> Coly Li wrote:
>> This patch modifies parameter of octeon_cvmcount_read() from 'void' to 'struct
>> clocksource *cs', which fixes compile warning for incompatible parameter type.
>>
>> Signed-off-by: Coly Li <coly.li@suse.de>
>> Cc: David Daney <ddaney@caviumnetworks.com>
>> Cc: Ingo Molnar <mingo@elte.hu>
>
> It looks good to me:
>
> Reviewed-by: David Daney <ddaney@caviumnetworks.com>

Applied, thanks.

Coly, if you modify MIPS code, please cc the linux-mips mailing list and
myself or generally consult the MAINTAINERS file for who to cc on patches.

Thanks!

  Ralf

Re: [PATCH 5/7] mips cavium-octeon: add parameter to octeon_cvmcount_read()

[Coly Li]

Ralf Baechle Wrote:
> On Wed, Apr 22, 2009 at 01:33:56PM -0700, David Daney wrote:
> 
>> Coly Li wrote:
>>> This patch modifies parameter of octeon_cvmcount_read() from 'void' to 'struct
>>> clocksource *cs', which fixes compile warning for incompatible parameter type.
>>>
>>> Signed-off-by: Coly Li <coly.li@suse.de>
>>> Cc: David Daney <ddaney@caviumnetworks.com>
>>> Cc: Ingo Molnar <mingo@elte.hu>
>> It looks good to me:
>>
>> Reviewed-by: David Daney <ddaney@caviumnetworks.com>
> 
> Applied, thanks.
> 
> Coly, if you modify MIPS code, please cc the linux-mips mailing list and
> myself or generally consult the MAINTAINERS file for who to cc on patches.
> 
Ralf, I keep you advice in mind. Thanks.

-- 
Coly Li
SuSE Labs