From: Anthony Liguori <anthony@codemonkey.ws>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org, Rusty Russell <rusty@rustcorp.com.au>,
Hannes Reinecke <hare@suse.de>,
Christian Borntraeger <borntraeger@de.ibm.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH] virtio-blk: add SGI_IO passthru support
Date: Mon, 27 Apr 2009 09:36:51 -0500 [thread overview]
Message-ID: <49F5C303.3060003@codemonkey.ws> (raw)
In-Reply-To: <20090427082914.GA383@lst.de>
Christoph Hellwig wrote:
> [had the qemu list address wrong the first time, reply to this message,
> not the previous if you were on Cc]
>
>
> Add support for SG_IO passthru (packet commands) to the virtio-blk
> backend. Conceptually based on an older patch from Hannes Reinecke
> but largely rewritten to match the code structure and layering in
> virtio-blk.
>
> Note that currently we issue the hose SG_IO synchronously. We could
> easily switch to async I/O, but that would required either bloating
> the VirtIOBlockReq by the size of struct sg_io_hdr or an additional
> memory allocation for each SG_IO request.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
So practically speaking, what can you do with this? Should we be
handling some SCSI cmds internally to QEMU (like eject operations) and
supporting media=cdrom in -drive for if=virtio?
On a related topic, should we switch /dev/vdX to be /dev/sdX?
Regards,
Anthony Liguori
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: Christoph Hellwig <hch@lst.de>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
Hannes Reinecke <hare@suse.de>
Subject: [Qemu-devel] Re: [PATCH] virtio-blk: add SGI_IO passthru support
Date: Mon, 27 Apr 2009 09:36:51 -0500 [thread overview]
Message-ID: <49F5C303.3060003@codemonkey.ws> (raw)
In-Reply-To: <20090427082914.GA383@lst.de>
Christoph Hellwig wrote:
> [had the qemu list address wrong the first time, reply to this message,
> not the previous if you were on Cc]
>
>
> Add support for SG_IO passthru (packet commands) to the virtio-blk
> backend. Conceptually based on an older patch from Hannes Reinecke
> but largely rewritten to match the code structure and layering in
> virtio-blk.
>
> Note that currently we issue the hose SG_IO synchronously. We could
> easily switch to async I/O, but that would required either bloating
> the VirtIOBlockReq by the size of struct sg_io_hdr or an additional
> memory allocation for each SG_IO request.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
So practically speaking, what can you do with this? Should we be
handling some SCSI cmds internally to QEMU (like eject operations) and
supporting media=cdrom in -drive for if=virtio?
On a related topic, should we switch /dev/vdX to be /dev/sdX?
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-04-27 14:36 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 8:26 [PATCH] virtio-blk: add SGI_IO passthru support Christoph Hellwig
2009-04-27 8:29 ` Christoph Hellwig
2009-04-27 8:29 ` [Qemu-devel] " Christoph Hellwig
2009-04-27 9:15 ` Avi Kivity
2009-04-27 9:15 ` [Qemu-devel] " Avi Kivity
2009-04-28 9:47 ` Christoph Hellwig
2009-04-28 9:47 ` Christoph Hellwig
2009-04-27 14:36 ` Anthony Liguori [this message]
2009-04-27 14:36 ` [Qemu-devel] " Anthony Liguori
2009-04-28 9:51 ` Christoph Hellwig
2009-04-28 9:51 ` Christoph Hellwig
2009-04-28 16:37 ` Anthony Liguori
2009-04-28 16:52 ` Christian Borntraeger
2009-04-28 16:52 ` Christian Borntraeger
2009-04-29 10:48 ` Christoph Hellwig
2009-04-29 10:48 ` Christoph Hellwig
2009-04-29 11:11 ` Paul Brook
2009-04-29 11:11 ` Paul Brook
2009-04-29 11:19 ` Christian Borntraeger
2009-04-29 11:19 ` Christian Borntraeger
2009-04-29 11:29 ` Paul Brook
2009-04-29 11:29 ` Paul Brook
2009-04-29 11:21 ` Christoph Hellwig
2009-04-29 11:21 ` Christoph Hellwig
2009-04-29 11:37 ` Paul Brook
2009-04-29 11:37 ` Paul Brook
2009-04-30 20:13 ` Christoph Hellwig
2009-04-30 20:13 ` Christoph Hellwig
2009-04-30 20:55 ` Nicholas A. Bellinger
2009-04-30 20:55 ` Nicholas A. Bellinger
2009-04-30 21:49 ` Paul Brook
2009-04-30 21:49 ` Paul Brook
2009-04-30 21:56 ` Javier Guerra
2009-04-30 21:56 ` Javier Guerra
2009-05-01 7:24 ` Christoph Hellwig
2009-05-01 7:24 ` Christoph Hellwig
2009-05-01 11:08 ` Jamie Lokier
2009-05-01 11:08 ` Jamie Lokier
2009-05-01 14:28 ` Christoph Hellwig
2009-05-01 14:28 ` Christoph Hellwig
2009-05-05 5:21 ` Rusty Russell
2009-05-05 5:21 ` Rusty Russell
2009-04-28 19:09 ` Christian Borntraeger
2009-04-28 19:09 ` Christian Borntraeger
2009-04-29 10:50 ` Christoph Hellwig
2009-04-29 10:50 ` Christoph Hellwig
2009-04-29 11:07 ` Christian Borntraeger
2009-04-29 11:07 ` Christian Borntraeger
2009-04-28 9:57 ` [PATCH 2/2] virtio-blk: add SG_IO " Christoph Hellwig
2009-04-28 9:57 ` [Qemu-devel] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F5C303.3060003@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=borntraeger@de.ibm.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.