* [PATCH] powerpc/ps3: Move static keyword to the front of declaration
@ 2020-04-29 10:00 Xiongfeng Wang
2020-04-29 10:13 ` Geert Uytterhoeven
2020-05-06 2:51 ` Michael Ellerman
0 siblings, 2 replies; 4+ messages in thread
From: Xiongfeng Wang @ 2020-04-29 10:00 UTC (permalink / raw)
To: geoff, benh, paulus, linuxppc-dev, linux-kernel, wangxiongfeng2
Move the static keyword to the front of declaration of 'vuart_bus_priv',
and resolve the following compiler warning that can be seen when
building with warnings enabled (W=1):
drivers/ps3/ps3-vuart.c:867:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
} static vuart_bus_priv;
^
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
---
drivers/ps3/ps3-vuart.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ps3/ps3-vuart.c b/drivers/ps3/ps3-vuart.c
index ddaa5ea..8e80e09 100644
--- a/drivers/ps3/ps3-vuart.c
+++ b/drivers/ps3/ps3-vuart.c
@@ -858,13 +858,13 @@ static int ps3_vuart_handle_port_interrupt(struct ps3_system_bus_device *dev)
return 0;
}
-struct vuart_bus_priv {
+static struct vuart_bus_priv {
struct ports_bmp *bmp;
unsigned int virq;
struct mutex probe_mutex;
int use_count;
struct ps3_system_bus_device *devices[PORT_COUNT];
-} static vuart_bus_priv;
+} vuart_bus_priv;
/**
* ps3_vuart_irq_handler - first stage interrupt handler
--
1.7.12.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/ps3: Move static keyword to the front of declaration
2020-04-29 10:00 [PATCH] powerpc/ps3: Move static keyword to the front of declaration Xiongfeng Wang
@ 2020-04-29 10:13 ` Geert Uytterhoeven
2020-05-06 2:51 ` Michael Ellerman
1 sibling, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2020-04-29 10:13 UTC (permalink / raw)
To: Xiongfeng Wang
Cc: Geoff Levand, Benjamin Herrenschmidt, Paul Mackerras,
linuxppc-dev, Linux Kernel Mailing List
On Wed, Apr 29, 2020 at 12:07 PM Xiongfeng Wang
<wangxiongfeng2@huawei.com> wrote:
> Move the static keyword to the front of declaration of 'vuart_bus_priv',
> and resolve the following compiler warning that can be seen when
> building with warnings enabled (W=1):
>
> drivers/ps3/ps3-vuart.c:867:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
> } static vuart_bus_priv;
> ^
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/ps3: Move static keyword to the front of declaration
@ 2020-04-29 10:13 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2020-04-29 10:13 UTC (permalink / raw)
To: Xiongfeng Wang
Cc: Geoff Levand, Paul Mackerras, linuxppc-dev, Linux Kernel Mailing List
On Wed, Apr 29, 2020 at 12:07 PM Xiongfeng Wang
<wangxiongfeng2@huawei.com> wrote:
> Move the static keyword to the front of declaration of 'vuart_bus_priv',
> and resolve the following compiler warning that can be seen when
> building with warnings enabled (W=1):
>
> drivers/ps3/ps3-vuart.c:867:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
> } static vuart_bus_priv;
> ^
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/ps3: Move static keyword to the front of declaration
2020-04-29 10:00 [PATCH] powerpc/ps3: Move static keyword to the front of declaration Xiongfeng Wang
2020-04-29 10:13 ` Geert Uytterhoeven
@ 2020-05-06 2:51 ` Michael Ellerman
1 sibling, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2020-05-06 2:51 UTC (permalink / raw)
To: Xiongfeng Wang, geoff, benh, paulus, linuxppc-dev, linux-kernel,
wangxiongfeng2
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 618 bytes --]
On Wed, 2020-04-29 at 10:00:48 UTC, Xiongfeng Wang wrote:
> Move the static keyword to the front of declaration of 'vuart_bus_priv',
> and resolve the following compiler warning that can be seen when
> building with warnings enabled (W=1):
>
> drivers/ps3/ps3-vuart.c:867:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
> } static vuart_bus_priv;
> ^
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/43c8a496fa37187b54f7df71fb8262acc6bf6200
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-06 2:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-29 10:00 [PATCH] powerpc/ps3: Move static keyword to the front of declaration Xiongfeng Wang
2020-04-29 10:13 ` Geert Uytterhoeven
2020-04-29 10:13 ` Geert Uytterhoeven
2020-05-06 2:51 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.