* [PATCH] sanity.bbclass: grammar/typo fixes re: Python install
@ 2022-05-12 8:45 Robert P. J. Day
2022-05-16 7:32 ` [OE-core] " Luca Ceresoli
0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2022-05-12 8:45 UTC (permalink / raw)
To: OE Core mailing list
Clean up various spelling/grammar oopsies in a small section of
sanity.bbclass.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index b416918013..491a3bac6f 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -631,11 +631,14 @@ def check_sanity_sstate_dir_change(sstate_dir, data):
def check_sanity_version_change(status, d):
# Sanity checks to be done when SANITY_VERSION or NATIVELSBSTRING changes
# In other words, these tests run once in a given build directory and then
- # never again until the sanity version or host distrubution id/version changes.
+ # never again until the sanity version or host distribution id/version changes.
+
+ # Verify that the python install is complete. Examples that are often removed in
+ # minimal installations:
+ #
+ # glib-2.0-native requires xml.parsers.expat
+ # icu requires distutils.sysconfig
- # Check the python install is complete. Examples that are often removed in
- # minimal installations: glib-2.0-natives requries # xml.parsers.expat and icu
- # requires distutils.sysconfig.
try:
import xml.parsers.expat
import distutils.sysconfig
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [OE-core] [PATCH] sanity.bbclass: grammar/typo fixes re: Python install
2022-05-12 8:45 [PATCH] sanity.bbclass: grammar/typo fixes re: Python install Robert P. J. Day
@ 2022-05-16 7:32 ` Luca Ceresoli
0 siblings, 0 replies; 2+ messages in thread
From: Luca Ceresoli @ 2022-05-16 7:32 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: OE Core mailing list
Hi Robert,
Il giorno Thu, 12 May 2022 04:45:57 -0400 (EDT)
"Robert P. J. Day" <rpjday@crashcourse.ca> ha scritto:
> Clean up various spelling/grammar oopsies in a small section of
> sanity.bbclass.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index b416918013..491a3bac6f 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -631,11 +631,14 @@ def check_sanity_sstate_dir_change(sstate_dir,
> data): def check_sanity_version_change(status, d):
> # Sanity checks to be done when SANITY_VERSION or
> NATIVELSBSTRING changes # In other words, these tests run once in a
> given build directory and then
> - # never again until the sanity version or host distrubution
> id/version changes.
> + # never again until the sanity version or host distribution
> id/version changes. +
> + # Verify that the python install is complete. Examples that are
> often removed in
> + # minimal installations:
> + #
> + # glib-2.0-native requires xml.parsers.expat
> + # icu requires distutils.sysconfig
>
> - # Check the python install is complete. Examples that are often
> removed in
> - # minimal installations: glib-2.0-natives requries #
> xml.parsers.expat and icu
> - # requires distutils.sysconfig.
> try:
> import xml.parsers.expat
> import distutils.sysconfig
>
Your patch looks visually good, but it does not apply:
error: patch failed: meta/classes/sanity.bbclass:631
error: meta/classes/sanity.bbclass: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
Patch failed at 0002 sanity.bbclass: grammar/typo fixes re: Python
install
Can you please rebase and resend?
Weird enough, the patch you had sent a few minutes earlier applied
without problems.
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-16 7:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-12 8:45 [PATCH] sanity.bbclass: grammar/typo fixes re: Python install Robert P. J. Day
2022-05-16 7:32 ` [OE-core] " Luca Ceresoli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.