All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Kerello <christophe.kerello@st.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: <richard@nod.at>, <vigneshr@ti.com>, <robh+dt@kernel.org>,
	<mark.rutland@arm.com>, <gregkh@linuxfoundation.org>,
	<boris.brezillon@collabora.com>, <linux-mtd@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<devicetree@vger.kernel.org>, <marex@denx.de>
Subject: Re: [PATCH v4 04/10] mtd: rawnand: stm32_fmc2: cleanup
Date: Tue, 12 May 2020 08:49:54 +0200	[thread overview]
Message-ID: <49c51a13-96a1-0241-f4d1-c5ff7d52921d@st.com> (raw)
In-Reply-To: <20200511223900.030fe5f4@xps13>

Hi Miquel,

On 5/11/20 10:39 PM, Miquel Raynal wrote:
> 
> Christophe Kerello <christophe.kerello@st.com> wrote on Wed, 6 May 2020
> 11:11:13 +0200:
> 
>> This patch renames functions and local variables.
>> This cleanup is done to get all functions starting by stm32_fmc2_nfc
>> in the FMC2 raw NAND driver when all functions will start by
>> stm32_fmc2_ebi in the FMC2 EBI driver.
>>
>> Signed-off-by: Christophe Kerello <christophe.kerello@st.com>
>> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> 
> Applied to nand/next as well but for an unknown reason I had to do it
> by hand because the patch would not apply.
> 
> Thanks,
> Miquèl
> 
This is strange, I can apply this patch on my tree without any conflicts.
There is a compilation issue line 1301.

@@ -1302,44 +1298,45 @@ static void stm32_fmc2_write_data(struct 
nand_chip *chip, const void *buf,

  	if (force_8bit && chip->options & NAND_BUSWIDTH_16)
  		/* Reconfigure bus width to 16-bit */
-		stm32_fmc2_set_buswidth_16(fmc2, true);
+		stm32_fmc2_nfc_set_buswidth_16(nfc, true);
  }

I will rebase on top of nand/next today to check that there is no issues 
with the driver.

Regards,
Christophe Kerello.

WARNING: multiple messages have this Message-ID (diff)
From: Christophe Kerello <christophe.kerello@st.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, marex@denx.de,
	vigneshr@ti.com, gregkh@linuxfoundation.org, richard@nod.at,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	linux-mtd@lists.infradead.org, boris.brezillon@collabora.com,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v4 04/10] mtd: rawnand: stm32_fmc2: cleanup
Date: Tue, 12 May 2020 08:49:54 +0200	[thread overview]
Message-ID: <49c51a13-96a1-0241-f4d1-c5ff7d52921d@st.com> (raw)
In-Reply-To: <20200511223900.030fe5f4@xps13>

Hi Miquel,

On 5/11/20 10:39 PM, Miquel Raynal wrote:
> 
> Christophe Kerello <christophe.kerello@st.com> wrote on Wed, 6 May 2020
> 11:11:13 +0200:
> 
>> This patch renames functions and local variables.
>> This cleanup is done to get all functions starting by stm32_fmc2_nfc
>> in the FMC2 raw NAND driver when all functions will start by
>> stm32_fmc2_ebi in the FMC2 EBI driver.
>>
>> Signed-off-by: Christophe Kerello <christophe.kerello@st.com>
>> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> 
> Applied to nand/next as well but for an unknown reason I had to do it
> by hand because the patch would not apply.
> 
> Thanks,
> Miquèl
> 
This is strange, I can apply this patch on my tree without any conflicts.
There is a compilation issue line 1301.

@@ -1302,44 +1298,45 @@ static void stm32_fmc2_write_data(struct 
nand_chip *chip, const void *buf,

  	if (force_8bit && chip->options & NAND_BUSWIDTH_16)
  		/* Reconfigure bus width to 16-bit */
-		stm32_fmc2_set_buswidth_16(fmc2, true);
+		stm32_fmc2_nfc_set_buswidth_16(nfc, true);
  }

I will rebase on top of nand/next today to check that there is no issues 
with the driver.

Regards,
Christophe Kerello.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2020-05-12  6:50 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06  9:11 [PATCH v4 00/10] add STM32 FMC2 EBI controller driver Christophe Kerello
2020-05-06  9:11 ` Christophe Kerello
2020-05-06  9:11 ` [PATCH v4 01/10] mtd: rawnand: stm32_fmc2: manage all errors cases at probe time Christophe Kerello
2020-05-06  9:11   ` Christophe Kerello
2020-05-11 20:29   ` Miquel Raynal
2020-05-11 20:29     ` Miquel Raynal
2020-05-06  9:11 ` [PATCH v4 02/10] mtd: rawnand: stm32_fmc2: remove useless inline comments Christophe Kerello
2020-05-06  9:11   ` Christophe Kerello
2020-05-11 20:29   ` Miquel Raynal
2020-05-11 20:29     ` Miquel Raynal
2020-05-06  9:11 ` [PATCH v4 03/10] mtd: rawnand: stm32_fmc2: use FMC2_TIMEOUT_MS for timeouts Christophe Kerello
2020-05-06  9:11   ` Christophe Kerello
2020-05-11 20:29   ` Miquel Raynal
2020-05-11 20:29     ` Miquel Raynal
2020-05-06  9:11 ` [PATCH v4 04/10] mtd: rawnand: stm32_fmc2: cleanup Christophe Kerello
2020-05-06  9:11   ` Christophe Kerello
2020-05-11 20:39   ` Miquel Raynal
2020-05-11 20:39     ` Miquel Raynal
2020-05-12  6:49     ` Christophe Kerello [this message]
2020-05-12  6:49       ` Christophe Kerello
2020-05-12  6:59       ` Miquel Raynal
2020-05-12  6:59         ` Miquel Raynal
2020-05-06  9:11 ` [PATCH v4 05/10] mtd: rawnand: stm32_fmc2: use FIELD_PREP/FIELD_GET macros Christophe Kerello
2020-05-06  9:11   ` Christophe Kerello
2020-05-11 20:29   ` Miquel Raynal
2020-05-11 20:29     ` Miquel Raynal
2020-05-06  9:11 ` [PATCH v4 06/10] dt-bindings: mtd: update STM32 FMC2 NAND controller documentation Christophe Kerello
2020-05-06  9:11   ` Christophe Kerello
2020-05-14 15:00   ` Rob Herring
2020-05-14 15:00     ` Rob Herring
2020-05-14 16:34     ` Christophe Kerello
2020-05-14 16:34       ` Christophe Kerello
2020-05-14 17:55       ` Rob Herring
2020-05-14 17:55         ` Rob Herring
2020-05-15  9:02         ` Christophe Kerello
2020-05-15  9:02           ` Christophe Kerello
2020-05-06  9:11 ` [PATCH v4 07/10] dt-bindings: memory-controller: add STM32 FMC2 EBI " Christophe Kerello
2020-05-06  9:11   ` Christophe Kerello
2020-05-14 15:07   ` Rob Herring
2020-05-14 15:07     ` Rob Herring
2020-05-14 16:37     ` Christophe Kerello
2020-05-14 16:37       ` Christophe Kerello
2020-05-06  9:11 ` [PATCH v4 08/10] memory: stm32-fmc2-ebi: add STM32 FMC2 EBI controller driver Christophe Kerello
2020-05-06  9:11   ` Christophe Kerello
2020-05-06  9:11 ` [PATCH v4 09/10] mtd: rawnand: stm32_fmc2: use regmap APIs Christophe Kerello
2020-05-06  9:11   ` Christophe Kerello
2020-05-06  9:11 ` [PATCH v4 10/10] mtd: rawnand: stm32_fmc2: get resources from parent node Christophe Kerello
2020-05-06  9:11   ` Christophe Kerello
2020-05-11  9:18   ` Miquel Raynal
2020-05-11  9:18     ` Miquel Raynal
2020-05-11 10:21     ` Christophe Kerello
2020-05-11 10:21       ` Christophe Kerello
2020-05-11 11:59       ` Miquel Raynal
2020-05-11 11:59         ` Miquel Raynal
2020-05-11 12:47         ` Christophe Kerello
2020-05-11 12:47           ` Christophe Kerello
2020-05-11 12:58           ` Miquel Raynal
2020-05-11 12:58             ` Miquel Raynal
2020-05-11 14:19             ` Christophe Kerello
2020-05-11 14:19               ` Christophe Kerello
2020-05-11 14:45               ` Miquel Raynal
2020-05-11 14:45                 ` Miquel Raynal
2020-05-11 17:02                 ` Christophe Kerello
2020-05-11 17:02                   ` Christophe Kerello
2020-05-11 20:28                   ` Miquel Raynal
2020-05-11 20:28                     ` Miquel Raynal
2020-05-11  9:22 ` [PATCH v4 00/10] add STM32 FMC2 EBI controller driver Miquel Raynal
2020-05-11  9:22   ` Miquel Raynal
2020-05-11 10:26   ` Christophe Kerello
2020-05-11 10:26     ` Christophe Kerello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49c51a13-96a1-0241-f4d1-c5ff7d52921d@st.com \
    --to=christophe.kerello@st.com \
    --cc=boris.brezillon@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=marex@denx.de \
    --cc=mark.rutland@arm.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.