From: Lubomir Rintel <lkundrak@v3.sk>
To: Pavel Machek <pavel@ucw.cz>
Cc: Mark Brown <broonie@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
James Cameron <quozl@laptop.org>,
Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Eric Miao <eric.y.miao@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Daniel Mack <daniel@zonque.org>,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
platform-driver-x86@vger.kernel.org, devel@driverdev.osuosl.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 02/15] Revert "platform/olpc: Make ec explicitly non-modular"
Date: Thu, 15 Nov 2018 19:57:44 +0100 [thread overview]
Message-ID: <49eee45692f16dcbcf8aceaf3a999bb7f33178ba.camel@v3.sk> (raw)
In-Reply-To: <20181102221626.GC5322@amd>
On Fri, 2018-11-02 at 23:16 +0100, Pavel Machek wrote:
> On Wed 2018-10-10 19:22:47, Lubomir Rintel wrote:
> > It doesn't make sense to always have this built-in, e.g. on ARM
> > multiplatform kernels. A better way to address the problem the
> > original
> > commit aimed to solve is to fix Kconfig.
> >
> > This reverts commit f48d1496b8537d75776478c6942dd87f34d7f270.
>
> This looks ok, but I don't see the Kconfig fix in the series. Is it
> needed?
It's flipped to a tristate in "Platform: OLPC: Move OLPC config symbol
out of x86 tree" and mentioned in the commit message.
Perhaps I could made that clear by separating the change into a
separate patch. I'm keeping it as it is in next version of the patch
set, but I'm going to improve this one's commit message and sort the
patches closer together.
> Pavel
Lubo
WARNING: multiple messages have this Message-ID (diff)
From: lkundrak@v3.sk (Lubomir Rintel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/15] Revert "platform/olpc: Make ec explicitly non-modular"
Date: Thu, 15 Nov 2018 19:57:44 +0100 [thread overview]
Message-ID: <49eee45692f16dcbcf8aceaf3a999bb7f33178ba.camel@v3.sk> (raw)
In-Reply-To: <20181102221626.GC5322@amd>
On Fri, 2018-11-02 at 23:16 +0100, Pavel Machek wrote:
> On Wed 2018-10-10 19:22:47, Lubomir Rintel wrote:
> > It doesn't make sense to always have this built-in, e.g. on ARM
> > multiplatform kernels. A better way to address the problem the
> > original
> > commit aimed to solve is to fix Kconfig.
> >
> > This reverts commit f48d1496b8537d75776478c6942dd87f34d7f270.
>
> This looks ok, but I don't see the Kconfig fix in the series. Is it
> needed?
It's flipped to a tristate in "Platform: OLPC: Move OLPC config symbol
out of x86 tree" and mentioned in the commit message.
Perhaps I could made that clear by separating the change into a
separate patch. I'm keeping it as it is in next version of the patch
set, but I'm going to improve this one's commit message and sort the
patches closer together.
> Pavel
Lubo
next prev parent reply other threads:[~2018-11-15 18:57 UTC|newest]
Thread overview: 164+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 17:22 [PATCH 0/15] Add support for OLPC XO 1.75 Embedded Controller Lubomir Rintel
2018-10-10 17:22 ` Lubomir Rintel
2018-10-10 17:22 ` [PATCH 01/15] power: supply: olpc_battery: correct the temperature units Lubomir Rintel
2018-10-10 17:22 ` Lubomir Rintel
2018-10-19 13:00 ` Andy Shevchenko
2018-10-19 13:00 ` Andy Shevchenko
2018-10-19 13:00 ` Andy Shevchenko
2018-10-21 21:27 ` Sebastian Reichel
2018-10-21 21:27 ` Sebastian Reichel
2018-10-21 21:27 ` Sebastian Reichel
2018-10-21 21:27 ` Sebastian Reichel
2018-11-02 22:16 ` Pavel Machek
2018-11-02 22:16 ` Pavel Machek
2018-10-10 17:22 ` [PATCH 02/15] Revert "platform/olpc: Make ec explicitly non-modular" Lubomir Rintel
2018-10-10 17:22 ` Lubomir Rintel
2018-10-19 13:04 ` Andy Shevchenko
2018-10-19 13:04 ` Andy Shevchenko
2018-10-19 13:04 ` Andy Shevchenko
2018-11-02 22:16 ` Pavel Machek
2018-11-02 22:16 ` Pavel Machek
2018-11-15 18:57 ` Lubomir Rintel [this message]
2018-11-15 18:57 ` Lubomir Rintel
2018-10-10 17:22 ` [PATCH 03/15] dt-bindings: olpc,xo1.75-ec: Add OLPC XO-1.75 EC bindings Lubomir Rintel
2018-10-10 17:22 ` [PATCH 03/15] dt-bindings: olpc, xo1.75-ec: " Lubomir Rintel
2018-10-17 19:38 ` [PATCH 03/15] dt-bindings: olpc,xo1.75-ec: " Rob Herring
2018-10-17 19:38 ` Rob Herring
2018-11-04 12:26 ` Pavel Machek
2018-11-04 12:26 ` Pavel Machek
2018-11-04 12:26 ` Pavel Machek
2018-10-10 17:22 ` [PATCH 04/15] Platform: OLPC: Remove an unused include Lubomir Rintel
2018-10-10 17:22 ` Lubomir Rintel
2018-10-19 13:05 ` Andy Shevchenko
2018-10-19 13:05 ` Andy Shevchenko
2018-10-19 13:05 ` Andy Shevchenko
2018-11-13 13:59 ` Lubomir Rintel
2018-11-13 13:59 ` Lubomir Rintel
2018-11-13 13:59 ` Lubomir Rintel
2018-11-04 12:26 ` Pavel Machek
2018-11-04 12:26 ` Pavel Machek
2018-10-10 17:22 ` [PATCH 05/15] Platform: OLPC: Move OLPC config symbol out of x86 tree Lubomir Rintel
2018-10-10 17:22 ` Lubomir Rintel
2018-10-19 13:09 ` Andy Shevchenko
2018-10-19 13:09 ` Andy Shevchenko
2018-10-19 13:09 ` Andy Shevchenko
2018-11-04 12:27 ` Pavel Machek
2018-11-04 12:27 ` Pavel Machek
2018-10-10 17:22 ` [PATCH 06/15] Platform: OLPC: Add XO-1.75 EC driver Lubomir Rintel
2018-10-10 17:22 ` Lubomir Rintel
2018-10-19 16:06 ` Andy Shevchenko
2018-10-19 16:06 ` Andy Shevchenko
2018-10-19 16:06 ` Andy Shevchenko
2018-11-13 17:26 ` Lubomir Rintel
2018-11-13 17:26 ` Lubomir Rintel
2018-11-13 17:26 ` Lubomir Rintel
2018-11-13 22:06 ` James Cameron
2018-11-13 22:06 ` James Cameron
2018-11-13 22:06 ` James Cameron
2018-11-19 10:40 ` Pavel Machek
2018-11-19 10:40 ` Pavel Machek
2018-11-19 10:40 ` Pavel Machek
2018-11-19 10:40 ` Pavel Machek
2018-11-19 13:25 ` Lubomir Rintel
2018-11-19 13:25 ` Lubomir Rintel
2018-11-19 13:25 ` Lubomir Rintel
2018-11-19 13:25 ` Lubomir Rintel
2018-10-10 17:22 ` [PATCH 07/15] Platform: OLPC: Avoid a warning if the EC didn't register yet Lubomir Rintel
2018-10-10 17:22 ` Lubomir Rintel
2018-10-19 13:11 ` Andy Shevchenko
2018-10-19 13:11 ` Andy Shevchenko
2018-10-19 13:11 ` Andy Shevchenko
2018-11-04 12:30 ` Pavel Machek
2018-11-04 12:30 ` Pavel Machek
2018-11-04 12:30 ` Pavel Machek
2018-10-10 17:22 ` [PATCH 08/15] Platform: OLPC: Move EC-specific functionality out from x86 Lubomir Rintel
2018-10-10 17:22 ` Lubomir Rintel
2018-10-19 13:36 ` Andy Shevchenko
2018-10-19 13:36 ` Andy Shevchenko
2018-10-19 13:36 ` Andy Shevchenko
2018-11-14 16:20 ` Lubomir Rintel
2018-11-14 16:20 ` Lubomir Rintel
2018-11-14 16:20 ` Lubomir Rintel
2018-11-04 12:31 ` Pavel Machek
2018-11-04 12:31 ` Pavel Machek
2018-10-10 17:22 ` [PATCH 09/15] Platform: OLPC: add a regulator for the DCON Lubomir Rintel
2018-10-10 17:22 ` Lubomir Rintel
2018-10-10 17:22 ` Lubomir Rintel
2018-10-19 13:39 ` Andy Shevchenko
2018-10-19 13:39 ` Andy Shevchenko
2018-10-19 13:39 ` Andy Shevchenko
2018-10-10 17:22 ` [PATCH 10/15] dt-bindings: olpc_battery: Add XO-1.5 battery Lubomir Rintel
2018-10-10 17:22 ` Lubomir Rintel
2018-10-17 19:38 ` Rob Herring
2018-10-17 19:38 ` Rob Herring
2018-10-17 19:38 ` Rob Herring
2018-10-17 19:38 ` Rob Herring
2018-11-04 12:32 ` Pavel Machek
2018-11-04 12:32 ` Pavel Machek
2018-10-10 17:22 ` [PATCH 11/15] x86, olpc: Use a correct version when making up a battery node Lubomir Rintel
2018-10-10 17:22 ` Lubomir Rintel
2018-10-19 13:43 ` Andy Shevchenko
2018-10-19 13:43 ` Andy Shevchenko
2018-10-19 13:43 ` Andy Shevchenko
2018-11-14 16:49 ` Lubomir Rintel
2018-11-14 16:49 ` Lubomir Rintel
2018-11-14 16:49 ` Lubomir Rintel
2018-11-04 12:34 ` Pavel Machek
2018-11-04 12:34 ` Pavel Machek
2018-11-04 12:34 ` Pavel Machek
2018-10-10 17:22 ` [PATCH 12/15] power: supply: olpc_battery: Use DT to get battery version Lubomir Rintel
2018-10-10 17:22 ` Lubomir Rintel
2018-10-19 13:45 ` Andy Shevchenko
2018-10-19 13:45 ` Andy Shevchenko
2018-10-19 13:45 ` Andy Shevchenko
2018-11-15 18:33 ` Lubomir Rintel
2018-11-15 18:33 ` Lubomir Rintel
2018-11-15 18:33 ` Lubomir Rintel
2018-11-04 12:37 ` Pavel Machek
2018-11-04 12:37 ` Pavel Machek
2018-11-15 18:36 ` Lubomir Rintel
2018-11-15 18:36 ` Lubomir Rintel
2018-10-10 17:22 ` [PATCH 13/15] power: supply: olpc_battery: Move priv data to a struct Lubomir Rintel
2018-10-10 17:22 ` Lubomir Rintel
2018-10-10 17:22 ` Lubomir Rintel
2018-10-19 13:48 ` Andy Shevchenko
2018-10-19 13:48 ` Andy Shevchenko
2018-10-19 13:48 ` Andy Shevchenko
2018-11-04 14:37 ` Pavel Machek
2018-11-04 14:37 ` Pavel Machek
2018-11-14 17:10 ` Lubomir Rintel
2018-11-14 17:10 ` Lubomir Rintel
2018-10-10 17:22 ` [PATCH 14/15] power: supply: olpc_battery: Avoid using platform_info Lubomir Rintel
2018-10-10 17:22 ` Lubomir Rintel
2018-10-19 13:50 ` Andy Shevchenko
2018-10-19 13:50 ` Andy Shevchenko
2018-10-19 13:50 ` Andy Shevchenko
2018-11-14 17:19 ` Lubomir Rintel
2018-11-14 17:19 ` Lubomir Rintel
2018-11-14 17:19 ` Lubomir Rintel
2018-11-04 14:39 ` Pavel Machek
2018-11-04 14:39 ` Pavel Machek
2018-10-10 17:23 ` [PATCH 15/15] power: supply: olpc_battery: Add OLPC XO 1.75 support Lubomir Rintel
2018-10-10 17:23 ` Lubomir Rintel
2018-10-19 13:55 ` Andy Shevchenko
2018-10-19 13:55 ` Andy Shevchenko
2018-10-19 13:55 ` Andy Shevchenko
2018-11-04 14:39 ` Pavel Machek
2018-11-04 14:39 ` Pavel Machek
2018-11-04 14:39 ` Pavel Machek
2018-10-10 19:26 ` [PATCH 0/15] Add support for OLPC XO 1.75 Embedded Controller Rob Herring
2018-10-10 19:26 ` Rob Herring
2018-10-10 19:26 ` Rob Herring
2018-10-10 19:26 ` Rob Herring
2018-10-11 10:42 ` Lubomir Rintel
2018-10-11 10:42 ` Lubomir Rintel
2018-10-11 10:42 ` Lubomir Rintel
2018-10-19 13:57 ` Andy Shevchenko
2018-10-19 13:57 ` Andy Shevchenko
2018-10-19 13:57 ` Andy Shevchenko
2018-10-23 17:03 ` Lubomir Rintel
2018-10-23 17:03 ` Lubomir Rintel
2018-10-23 17:03 ` Lubomir Rintel
2018-10-21 21:45 ` Sebastian Reichel
2018-10-21 21:45 ` Sebastian Reichel
2018-10-21 21:45 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49eee45692f16dcbcf8aceaf3a999bb7f33178ba.camel@v3.sk \
--to=lkundrak@v3.sk \
--cc=andy@infradead.org \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=dvhart@infradead.org \
--cc=eric.y.miao@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=quozl@laptop.org \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.