* [PATCH] Invalid request_limit unnoticed?
@ 2009-05-02 20:14 Roel Kluin
2009-05-06 21:24 ` Brian King
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-05-02 20:14 UTC (permalink / raw)
To: James Bottomley, linux-scsi, Andrew Morton
Remove redundant test on unsigned.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Maybe a different test is required?
To see that it is unsigned:
git grep -E -n "(req_lim_delta|__be32;$)"
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index c9aa761..8d3925f 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -910,9 +910,6 @@ static void login_rsp(struct srp_event_struct *evt_struct)
dev_info(hostdata->dev, "SRP_LOGIN succeeded\n");
- if (evt_struct->xfer_iu->srp.login_rsp.req_lim_delta < 0)
- dev_err(hostdata->dev, "Invalid request_limit.\n");
-
/* Now we know what the real request-limit is.
* This value is set rather than added to request_limit because
* request_limit could have been set to -1 by this client.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Invalid request_limit unnoticed?
2009-05-02 20:14 [PATCH] Invalid request_limit unnoticed? Roel Kluin
@ 2009-05-06 21:24 ` Brian King
0 siblings, 0 replies; 2+ messages in thread
From: Brian King @ 2009-05-06 21:24 UTC (permalink / raw)
To: Roel Kluin
Cc: James Bottomley, linux-scsi, Andrew Morton, Robert C Jennings,
Santiago Leon
Acked by: Brian King <brking@linux.vnet.ibm.com>
Roel Kluin wrote:
> Remove redundant test on unsigned.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Maybe a different test is required?
>
> To see that it is unsigned:
>
> git grep -E -n "(req_lim_delta|__be32;$)"
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index c9aa761..8d3925f 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -910,9 +910,6 @@ static void login_rsp(struct srp_event_struct *evt_struct)
>
> dev_info(hostdata->dev, "SRP_LOGIN succeeded\n");
>
> - if (evt_struct->xfer_iu->srp.login_rsp.req_lim_delta < 0)
> - dev_err(hostdata->dev, "Invalid request_limit.\n");
> -
> /* Now we know what the real request-limit is.
> * This value is set rather than added to request_limit because
> * request_limit could have been set to -1 by this client.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-06 21:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-02 20:14 [PATCH] Invalid request_limit unnoticed? Roel Kluin
2009-05-06 21:24 ` Brian King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.