* [Qemu-devel] Re: [Qemu-commits] [COMMIT 883ecbf] Remove noisy printf when KVM masks CPU features
[not found] <200905082053.n48Kr0rf008206@d03av04.boulder.ibm.com>
@ 2009-05-09 8:54 ` Avi Kivity
2009-05-09 13:27 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT 883ecbf] Remove noisy printf when KVMmasks " Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Avi Kivity @ 2009-05-09 8:54 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
Anthony Liguori wrote:
> From: Anthony Liguori <aliguori@us.ibm.com>
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>
> diff --git a/target-i386/helper.c b/target-i386/helper.c
> index bdf242b..5c03e3a 100644
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -102,7 +102,6 @@ static void kvm_trim_features(uint32_t *features, uint32_t supported,
> for (i = 0; i < 32; ++i) {
> mask = 1U << i;
> if ((*features & mask) && !(supported & mask)) {
> - printf("Processor feature %s not supported by kvm\n", names[i]);
> *features &= ~mask;
> }
> }
>
That was intentional, I didn't want to silently drop features the user
requested as those may impact live migration or load/save (or
application performance).
Maybe it's better to only do that if -cpu was specified on the command
line; and exit() as well. The user can easily pick up the missing bits
and remove them from the requested cpu features.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Qemu-devel] Re: [Qemu-commits] [COMMIT 883ecbf] Remove noisy printf when KVMmasks CPU features
2009-05-09 8:54 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT 883ecbf] Remove noisy printf when KVM masks CPU features Avi Kivity
@ 2009-05-09 13:27 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2009-05-09 13:27 UTC (permalink / raw)
To: Avi Kivity; +Cc: qemu-devel
Avi Kivity wrote:
> Anthony Liguori wrote:
>> From: Anthony Liguori <aliguori@us.ibm.com>
>>
>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>>
>> diff --git a/target-i386/helper.c b/target-i386/helper.c
>> index bdf242b..5c03e3a 100644
>> --- a/target-i386/helper.c
>> +++ b/target-i386/helper.c
>> @@ -102,7 +102,6 @@ static void kvm_trim_features(uint32_t *features,
>> uint32_t supported,
>> for (i = 0; i < 32; ++i) {
>> mask = 1U << i;
>> if ((*features & mask) && !(supported & mask)) {
>> - printf("Processor feature %s not supported by kvm\n",
>> names[i]);
>> *features &= ~mask;
>> }
>> }
>>
>
> That was intentional, I didn't want to silently drop features the user
> requested as those may impact live migration or load/save (or
> application performance).
Why not provide a monitor option to view the list of CPUID features that
are enabled?
printing to stdio is a bad idea. We print the names of pty devices to
stdio and tools have to parse that today. I hope they're sufficiently
robust but this isn't something we want to introduce if we don't have to.
> Maybe it's better to only do that if -cpu was specified on the command
> line; and exit() as well. The user can easily pick up the missing
> bits and remove them from the requested cpu features.
Yes, that's also a good idea.
Regards,
Anthony Liguori
--
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-09 13:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200905082053.n48Kr0rf008206@d03av04.boulder.ibm.com>
2009-05-09 8:54 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT 883ecbf] Remove noisy printf when KVM masks CPU features Avi Kivity
2009-05-09 13:27 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT 883ecbf] Remove noisy printf when KVMmasks " Anthony Liguori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.