All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: jeff@garzik.org, linux-scsi@vger.kernel.org,
	jens.axboe@oracle.com, linux-kernel@vger.kernel.org,
	linux-ide@vger.kernel.org, dm-devel@redhat.com,
	Mauelshagen@redhat.com
Subject: Re: [PATCH 2/3] scsi: add scsi_device->alt_capacity
Date: Sun, 10 May 2009 01:09:08 +0900	[thread overview]
Message-ID: <4A05AAA4.9010806@kernel.org> (raw)
In-Reply-To: <1241842999.6357.2.camel@mulgrave>

James Bottomley wrote:
> This is done at slightly the wrong level.  Capacity is actually a
> property of struct scsi_disk not struct scsi_device ... shouldn't
> alt_capacity be at the same level?

Hmmm... I think that was my first try and then I moved it to sdev for
some reason I can't rememer now.  I'll look into it again and try to
move it into sdev.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: jeff@garzik.org, linux-ide@vger.kernel.org,
	jens.axboe@oracle.com, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org, Mauelshagen@RedHat.com,
	dm-devel@RedHat.com, dan.j.williams@gmail.com
Subject: Re: [PATCH 2/3] scsi: add scsi_device->alt_capacity
Date: Sun, 10 May 2009 01:09:08 +0900	[thread overview]
Message-ID: <4A05AAA4.9010806@kernel.org> (raw)
In-Reply-To: <1241842999.6357.2.camel@mulgrave>

James Bottomley wrote:
> This is done at slightly the wrong level.  Capacity is actually a
> property of struct scsi_disk not struct scsi_device ... shouldn't
> alt_capacity be at the same level?

Hmmm... I think that was my first try and then I moved it to sdev for
some reason I can't rememer now.  I'll look into it again and try to
move it into sdev.

Thanks.

-- 
tejun

  reply	other threads:[~2009-05-09 16:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-09  0:13 [GIT PATCH] block,scsi,libata: implement alt_size, take#2 Tejun Heo
2009-05-09  0:13 ` Tejun Heo
2009-05-09  0:13 ` [PATCH 1/3] block: add alt_size Tejun Heo
2009-05-09  0:13   ` Tejun Heo
2009-05-09 13:45   ` Kay Sievers
2009-05-09 13:45     ` Kay Sievers
2009-05-09 14:04     ` Tejun Heo
2009-05-09 14:04       ` Tejun Heo
2009-05-09 16:26       ` Kay Sievers
2009-05-11 13:45       ` [dm-devel] " Konrad Rzeszutek
2009-05-12  0:53         ` Tejun Heo
2009-05-12  0:53           ` [dm-devel] " Tejun Heo
2009-05-09  0:13 ` [PATCH 2/3] scsi: add scsi_device->alt_capacity Tejun Heo
2009-05-09  0:13   ` Tejun Heo
2009-05-09  4:23   ` James Bottomley
2009-05-09 16:09     ` Tejun Heo [this message]
2009-05-09 16:09       ` Tejun Heo
2009-05-09 16:23       ` James Bottomley
2009-05-10  1:26         ` Tejun Heo
2009-05-15 19:44         ` ATA ULD (was Re: [PATCH 2/3] scsi: add scsi_device->alt_capacity) Jeff Garzik
2009-05-09  0:13 ` [PATCH 3/3] libata: export HPA size as alt_size Tejun Heo
2009-05-09  0:13   ` Tejun Heo
  -- strict thread matches above, loose matches on Subject: below --
2009-02-01  2:55 [PATCHSET] block,scsi,libata: implement alt_size Tejun Heo
2009-02-01  2:55 ` [PATCH 2/3] scsi: add scsi_device->alt_capacity Tejun Heo
2009-02-01  2:55   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A05AAA4.9010806@kernel.org \
    --to=tj@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=Mauelshagen@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=jeff@garzik.org \
    --cc=jens.axboe@oracle.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.