From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org, ehabkost@redhat.com
Subject: Re: [PATCH] Enable dirty logging for all regions during migration
Date: Wed, 13 May 2009 10:00:05 +0300 [thread overview]
Message-ID: <4A0A6FF5.8050708@redhat.com> (raw)
In-Reply-To: <1242170654-8685-1-git-send-email-glommer@redhat.com>
Glauber Costa wrote:
> From: Glauber de Oliveira Costa <glommer@redhat.com>
>
> In current calculations, we are not activating dirty logging
> for all regions, leading migration to fail. This problem was
> already raised by Yaniv Kamay a while ago. The proposed
> solution at the time (not merged), was a calculation to convert
> from target_phys_addr_t to ram_addr_t, which the dirty logging code
> expects.
>
> Avi noticed that enabling dirty logging for the region 0 -> -1ULL
> would do the trick. As I hit the problem, I can confirm it does.
>
> This patch, therefore, goes with this simpler approach. Before
> this patch, migration fails. With this patch, simple migration
> tests succeds.
>
>
Applied, thanks.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
prev parent reply other threads:[~2009-05-13 7:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 23:24 [PATCH] Enable dirty logging for all regions during migration Glauber Costa
2009-05-13 7:00 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0A6FF5.8050708@redhat.com \
--to=avi@redhat.com \
--cc=ehabkost@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.