Memory leak in libselinux/src/label_file.c

Memory leak in libselinux/src/label_file.c

[Hiroshi Shinji]

[-- Attachment #1: Type: text/plain, Size: 102 bytes --]

Hi,

I found memory leak in libselinux/src/label_file.c.
Please fix it.

Regards,

-- 
Hiroshi Shinji

[-- Attachment #2: label_file.patch --]
[-- Type: text/x-diff, Size: 462 bytes --]

diff --git a/libselinux/src/label_file.c b/libselinux/src/label_file.c
index 5043f09..b5e904f 100644
--- a/libselinux/src/label_file.c
+++ b/libselinux/src/label_file.c
@@ -299,6 +299,8 @@ static int process_line(struct selabel_handle *rec,
 		COMPAT_LOG(SELINUX_WARNING,
 			    "%s:  line %d is missing fields, skipping\n", path,
 			    lineno);
+		if (items == 1)
+			free(regex);
 		return 0;
 	} else if (items == 2) {
 		/* The type field is optional. */

Re: Memory leak in libselinux/src/label_file.c

[Chad Sellers]

On 4/3/09 12:58 AM, "Hiroshi Shinji" <hiroshi.shinji@gmail.com> wrote:

> Hi,
> 
> I found memory leak in libselinux/src/label_file.c.
> Please fix it.
> 
> Regards,

This looks good to me.

Acked-by: Chad Sellers <csellers@tresys.com>



--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: Memory leak in libselinux/src/label_file.c

[Joshua Brindle]

Chad Sellers wrote:
> On 4/3/09 12:58 AM, "Hiroshi Shinji" <hiroshi.shinji@gmail.com> wrote:
> 
>> Hi,
>>
>> I found memory leak in libselinux/src/label_file.c.
>> Please fix it.
>>
>> Regards,
> 
> This looks good to me.
> 
> Acked-by: Chad Sellers <csellers@tresys.com>
> 

Merged in libselinux-2.0.81


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.