* [PATCH] Don't use absolute path for ip, does not always work
@ 2009-06-05 14:36 Seewer Philippe
[not found] ` <4A292D53.9080603-omB+W0Dpw2o@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Seewer Philippe @ 2009-06-05 14:36 UTC (permalink / raw)
To: <initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
---
diff --git a/modules.d/40network/dhclient-script
b/modules.d/40network/dhclient-script
index 1ee78fe..d283762 100755
--- a/modules.d/40network/dhclient-script
+++ b/modules.d/40network/dhclient-script
@@ -69,7 +69,7 @@ setup_interface() {
case $reason in
PREINIT)
- run /sbin/ip link set $netif up
+ run ip link set $netif up
;;
BOUND)
setup_interface
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Don't use absolute path for ip, does not always work
[not found] ` <4A292D53.9080603-omB+W0Dpw2o@public.gmane.org>
@ 2009-06-05 15:59 ` Bill Nottingham
[not found] ` <20090605155900.GI5107-Zdt1ptygihhQcNjhGXsBABcY2uh10dtjAL8bYrjMMd8@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Bill Nottingham @ 2009-06-05 15:59 UTC (permalink / raw)
To: Seewer Philippe; +Cc: <initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Seewer Philippe (philippe.seewer-omB+W0Dpw2o@public.gmane.org) said:
> ---
> diff --git a/modules.d/40network/dhclient-script
> b/modules.d/40network/dhclient-script
> index 1ee78fe..d283762 100755
> --- a/modules.d/40network/dhclient-script
> +++ b/modules.d/40network/dhclient-script
> @@ -69,7 +69,7 @@ setup_interface() {
>
> case $reason in
> PREINIT)
> - run /sbin/ip link set $netif up
> + run ip link set $netif up
> ;;
> BOUND)
> setup_interface
Why does it not always work, unless you're breaking your initramfs?
Bill
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Don't use absolute path for ip, does not always work
[not found] ` <20090605155900.GI5107-Zdt1ptygihhQcNjhGXsBABcY2uh10dtjAL8bYrjMMd8@public.gmane.org>
@ 2009-06-05 17:13 ` Victor Lowther
[not found] ` <3EFC8CBF-4F49-4713-9F04-D17977415107-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Victor Lowther @ 2009-06-05 17:13 UTC (permalink / raw)
To: Bill Nottingham
Cc: Seewer Philippe,
<initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
On Jun 5, 2009, at 10:59 AM, Bill Nottingham <notting-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> Seewer Philippe (philippe.seewer-omB+W0Dpw2o@public.gmane.org) said:
>> ---
>> diff --git a/modules.d/40network/dhclient-script
>> b/modules.d/40network/dhclient-script
>> index 1ee78fe..d283762 100755
>> --- a/modules.d/40network/dhclient-script
>> +++ b/modules.d/40network/dhclient-script
>> @@ -69,7 +69,7 @@ setup_interface() {
>>
>> case $reason in
>> PREINIT)
>> - run /sbin/ip link set $netif up
>> + run ip link set $netif up
>> ;;
>> BOUND)
>> setup_interface
>
> Why does it not always work, unless you're breaking your initramfs?
What if your distro does not put ip in /sbin?
Besides, hardcoding executable locations when we know we have a sane
path is silly.
>
>
> Bill
> --
> To unsubscribe from this list: send the line "unsubscribe initramfs"
> in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Don't use absolute path for ip, does not always work
[not found] ` <3EFC8CBF-4F49-4713-9F04-D17977415107-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2009-06-05 17:27 ` Bill Nottingham
[not found] ` <20090605172727.GB7539-Zdt1ptygihhQcNjhGXsBABcY2uh10dtjAL8bYrjMMd8@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Bill Nottingham @ 2009-06-05 17:27 UTC (permalink / raw)
To: Victor Lowther
Cc: Seewer Philippe,
<initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Victor Lowther (victor.lowther-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org) said:
>> Why does it not always work, unless you're breaking your initramfs?
>
> What if your distro does not put ip in /sbin?
I was under the impression that the generation already put it in
a known place, in which case there's no reason to worry about it
being elsewhere. I checked again, and that's not the case.
Bill
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Don't use absolute path for ip, does not always work
[not found] ` <20090605172727.GB7539-Zdt1ptygihhQcNjhGXsBABcY2uh10dtjAL8bYrjMMd8@public.gmane.org>
@ 2009-06-05 17:47 ` Victor Lowther
[not found] ` <F96FDD9C-4009-4E3E-AD7D-C8640ECF003C-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Victor Lowther @ 2009-06-05 17:47 UTC (permalink / raw)
To: Bill Nottingham
Cc: Seewer Philippe,
<initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
On Jun 5, 2009, at 12:27 PM, Bill Nottingham <notting-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> Victor Lowther (victor.lowther-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org) said:
>>> Why does it not always work, unless you're breaking your initramfs?
>>
>> What if your distro does not put ip in /sbin?
>
> I was under the impression that the generation already put it in
> a known place, in which case there's no reason to worry about it
> being elsewhere. I checked again, and that's not the case.
I should hope so, otherwise writing the install code to be as distro
agnostic as feasible was all for naught. :)
>
> Bill
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Don't use absolute path for ip, does not always work
[not found] ` <F96FDD9C-4009-4E3E-AD7D-C8640ECF003C-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2009-06-05 18:19 ` Seewer Philippe
0 siblings, 0 replies; 6+ messages in thread
From: Seewer Philippe @ 2009-06-05 18:19 UTC (permalink / raw)
To: Victor Lowther
Cc: Bill Nottingham,
<initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Victor Lowther wrote:
> On Jun 5, 2009, at 12:27 PM, Bill Nottingham <notting-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>
>> Victor Lowther (victor.lowther-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org) said:
>>>> Why does it not always work, unless you're breaking your initramfs?
>>>
>>> What if your distro does not put ip in /sbin?
>>
>> I was under the impression that the generation already put it in
>> a known place, in which case there's no reason to worry about it
>> being elsewhere. I checked again, and that's not the case.
>
> I should hope so, otherwise writing the install code to be as distro
> agnostic as feasible was all for naught. :)
I guess I should have formulated my post better.
ip get's copied in, no worries. dracut_install ip works perfectly. Since
it looks everywhere sensible for the utility if no path is provided.
Problem is that debian puts ip in /bin not /sbin. So the code almost
always works, except for debian.
Regards,
Philippe
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-06-05 18:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-05 14:36 [PATCH] Don't use absolute path for ip, does not always work Seewer Philippe
[not found] ` <4A292D53.9080603-omB+W0Dpw2o@public.gmane.org>
2009-06-05 15:59 ` Bill Nottingham
[not found] ` <20090605155900.GI5107-Zdt1ptygihhQcNjhGXsBABcY2uh10dtjAL8bYrjMMd8@public.gmane.org>
2009-06-05 17:13 ` Victor Lowther
[not found] ` <3EFC8CBF-4F49-4713-9F04-D17977415107-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-06-05 17:27 ` Bill Nottingham
[not found] ` <20090605172727.GB7539-Zdt1ptygihhQcNjhGXsBABcY2uh10dtjAL8bYrjMMd8@public.gmane.org>
2009-06-05 17:47 ` Victor Lowther
[not found] ` <F96FDD9C-4009-4E3E-AD7D-C8640ECF003C-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-06-05 18:19 ` Seewer Philippe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.