* [PATCH] V4L/pwc - use usb_interface as parent, not usb_device
@ 2009-06-04 19:18 Lennart Poettering
2009-06-07 15:51 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Lennart Poettering @ 2009-06-04 19:18 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrew Morton, Mauro Carvalho Chehab, linux-media
The current code creates a sysfs device path where the video4linux
device is child of the usb device itself instead of the interface it
belongs to. That is evil and confuses udev.
This patch does basically the same thing as Kay's similar patch for the
ov511 driver:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ce96d0a44a4f8d1bb3dc12b5e98cb688c1bc730d
(Resent 2nd time, due to missing Signed-off-by)
Lennart
Signed-off-by: Lennart Poettering <mzxreary@0pointer.de>
---
drivers/media/video/pwc/pwc-if.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/pwc/pwc-if.c b/drivers/media/video/pwc/pwc-if.c
index 7c542ca..92d4177 100644
--- a/drivers/media/video/pwc/pwc-if.c
+++ b/drivers/media/video/pwc/pwc-if.c
@@ -1783,7 +1783,7 @@ static int usb_pwc_probe(struct usb_interface *intf, const struct usb_device_id
return -ENOMEM;
}
memcpy(pdev->vdev, &pwc_template, sizeof(pwc_template));
- pdev->vdev->parent = &(udev->dev);
+ pdev->vdev->parent = &intf->dev;
strcpy(pdev->vdev->name, name);
video_set_drvdata(pdev->vdev, pdev);
--
1.6.2.2
Lennart
--
Lennart Poettering Red Hat, Inc.
lennart [at] poettering [dot] net ICQ# 11060553
http://0pointer.net/lennart/ GnuPG 0x1A015CC4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] V4L/pwc - use usb_interface as parent, not usb_device
2009-06-04 19:18 [PATCH] V4L/pwc - use usb_interface as parent, not usb_device Lennart Poettering
@ 2009-06-07 15:51 ` Hans de Goede
0 siblings, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2009-06-07 15:51 UTC (permalink / raw)
To: Lennart Poettering
Cc: linux-kernel, Andrew Morton, Mauro Carvalho Chehab, linux-media
Looks good, we recently fixed the same issue in the gspca driver to,
Acked-by: Hans de Goede <hdegoede@redhat.com>
On 06/04/2009 09:18 PM, Lennart Poettering wrote:
> The current code creates a sysfs device path where the video4linux
> device is child of the usb device itself instead of the interface it
> belongs to. That is evil and confuses udev.
>
> This patch does basically the same thing as Kay's similar patch for the
> ov511 driver:
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ce96d0a44a4f8d1bb3dc12b5e98cb688c1bc730d
>
> (Resent 2nd time, due to missing Signed-off-by)
>
> Lennart
>
> Signed-off-by: Lennart Poettering<mzxreary@0pointer.de>
> ---
> drivers/media/video/pwc/pwc-if.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/pwc/pwc-if.c b/drivers/media/video/pwc/pwc-if.c
> index 7c542ca..92d4177 100644
> --- a/drivers/media/video/pwc/pwc-if.c
> +++ b/drivers/media/video/pwc/pwc-if.c
> @@ -1783,7 +1783,7 @@ static int usb_pwc_probe(struct usb_interface *intf, const struct usb_device_id
> return -ENOMEM;
> }
> memcpy(pdev->vdev,&pwc_template, sizeof(pwc_template));
> - pdev->vdev->parent =&(udev->dev);
> + pdev->vdev->parent =&intf->dev;
> strcpy(pdev->vdev->name, name);
> video_set_drvdata(pdev->vdev, pdev);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] V4L/pwc - use usb_interface as parent, not usb_device
@ 2009-05-28 14:14 Lennart Poettering
0 siblings, 0 replies; 3+ messages in thread
From: Lennart Poettering @ 2009-05-28 14:14 UTC (permalink / raw)
To: linux-kernel; +Cc: mchehab
The current code creates a sysfs device path where the video4linux
device is child of the usb device itself instead of the interface it
belongs to. That is evil and confuses udev.
This patch does basically the same thing as Kay's similar patch for the
ov511 driver:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ce96d0a44a4f8d1bb3dc12b5e98cb688c1bc730d
(A while back I sent this patch to Mauro, but it never appeared in any
tree, so I am reposting this on lkml, in the hope someone will pick it
up.)
Lennart
---
drivers/media/video/pwc/pwc-if.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/pwc/pwc-if.c b/drivers/media/video/pwc/pwc-if.c
index 7c542ca..92d4177 100644
--- a/drivers/media/video/pwc/pwc-if.c
+++ b/drivers/media/video/pwc/pwc-if.c
@@ -1783,7 +1783,7 @@ static int usb_pwc_probe(struct usb_interface *intf, const struct usb_device_id
return -ENOMEM;
}
memcpy(pdev->vdev, &pwc_template, sizeof(pwc_template));
- pdev->vdev->parent = &(udev->dev);
+ pdev->vdev->parent = &intf->dev;
strcpy(pdev->vdev->name, name);
video_set_drvdata(pdev->vdev, pdev);
--
1.6.2.2
Lennart
--
Lennart Poettering Red Hat, Inc.
lennart [at] poettering [dot] net ICQ# 11060553
http://0pointer.net/lennart/ GnuPG 0x1A015CC4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-07 13:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-04 19:18 [PATCH] V4L/pwc - use usb_interface as parent, not usb_device Lennart Poettering
2009-06-07 15:51 ` Hans de Goede
-- strict thread matches above, loose matches on Subject: below --
2009-05-28 14:14 Lennart Poettering
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.