[PATCH] cpu_user_regs * to __smp_call_function_interrupt

[PATCH] cpu_user_regs * to __smp_call_function_interrupt

[Mukesh Rathor]

[-- Attachment #1: Type: text/plain, Size: 130 bytes --]

Hi,

Following simple and tiny patch will help prevent many un-necessary ifdef's in 
kdb, if you'll please apply.

Thanks,
Mukesh

[-- Attachment #2: patch.out --]
[-- Type: text/plain, Size: 1114 bytes --]

diff -r 55ca7ef865b4 xen/arch/x86/smp.c
--- a/xen/arch/x86/smp.c	Tue Jun 16 11:01:17 2009 +0100
+++ b/xen/arch/x86/smp.c	Wed Jun 17 14:55:16 2009 -0700
@@ -223,7 +223,7 @@
  * Structure and data for smp_call_function()/on_selected_cpus().
  */
 
-static void __smp_call_function_interrupt(void);
+static void __smp_call_function_interrupt(struct cpu_user_regs *);
 static DEFINE_SPINLOCK(call_lock);
 static struct call_data_struct {
     void (*func) (void *info);
@@ -273,7 +273,7 @@
     if ( cpu_isset(smp_processor_id(), call_data.selected) )
     {
         local_irq_disable();
-        __smp_call_function_interrupt();
+        __smp_call_function_interrupt(NULL);
         local_irq_enable();
     }
 
@@ -341,7 +341,7 @@
     perfc_incr(ipis);
 }
 
-static void __smp_call_function_interrupt(void)
+static void __smp_call_function_interrupt(struct cpu_user_regs *regs)
 {
     void (*func)(void *info) = call_data.func;
     void *info = call_data.info;
@@ -371,5 +371,5 @@
 {
     ack_APIC_irq();
     perfc_incr(ipis);
-    __smp_call_function_interrupt();
+    __smp_call_function_interrupt(regs);
 }

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] cpu_user_regs * to __smp_call_function_interrupt

[Keir Fraser]

On 17/06/2009 22:58, "Mukesh Rathor" <mukesh.rathor@oracle.com> wrote:

> Following simple and tiny patch will help prevent many un-necessary ifdef's in
> kdb, if you'll please apply.

Passing a new paramter to a function which then ignores it is pointless.
I'll consider this as part of a patch that actually does something with it.

 -- Keir

Re: [PATCH] cpu_user_regs * to __smp_call_function_interrupt

[Mukesh Rathor]

Keir Fraser wrote:
> On 17/06/2009 22:58, "Mukesh Rathor" <mukesh.rathor@oracle.com> wrote:
> 
>> Following simple and tiny patch will help prevent many un-necessary ifdef's in
>> kdb, if you'll please apply.
> 
> Passing a new paramter to a function which then ignores it is pointless.
> I'll consider this as part of a patch that actually does something with it.
> 
>  -- Keir

It does, but in ext/debuggers.hg tree. Fine, I'll just nag you more now
to pull in the debuggers in mainline :).

thanks,
Mukesh

Re: [PATCH] cpu_user_regs * to __smp_call_function_interrupt

[Keir Fraser]

On 19/06/2009 02:30, "Mukesh Rathor" <mukesh.rathor@oracle.com> wrote:

>> Passing a new paramter to a function which then ignores it is pointless.
>> I'll consider this as part of a patch that actually does something with it.
>> 
>>  -- Keir
> 
> It does, but in ext/debuggers.hg tree. Fine, I'll just nag you more now
> to pull in the debuggers in mainline :).

It's like a 10-line patch. Just carry it!

 -- Keir