From: Santtu Lakkala <inz@inz.fi>
To: ofono@ofono.org
Subject: Re: [PATCH] [RFC] Do the PIN check in SIMManager
Date: Mon, 07 Sep 2009 12:53:16 +0300 [thread overview]
Message-ID: <4AA4D80C.1090104@inz.fi> (raw)
In-Reply-To: <1252135553-32722-1-git-send-email-andrew.zaborowski@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Andrzej Zaborowski wrote:
> This adds checking whether PIN is required during SIM initialisation and
> delaying the sim ready notifications until after correct PIN is given.
> According to 31.102 the IMSI should be retrieved after the PIN check
> however on the SIMs I've tried it can be retrieved before authentication
> and I think it would make sense to provide the imsi to the clients so
> they know which card they're authenticating to if they're swapping cards.
> + for (i = 0; i < len; i++)
> + if (!g_str_has_suffix(pin_required,
> + at_sim_name[i].name))
> + pin_type = at_sim_name[i].type;
Should this be:
> + for (i = 0; i < len; i++)
> + if (g_str_has_suffix(pin_required,
> + at_sim_name[i].name)) {
> + pin_type = at_sim_name[i].type;
> + break;
> + }
With the original code, I always get PH-CORP PUK (or PH-CORP PIN, should
the required code be PH-CORP PUK).
- --
Santtu Lakkala
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkqk2AwACgkQX9Rc0+po4p1YVQCgl//9VD6QQ+BmRBqtIn9/pRMH
ticAn0QT9CvLrtQp/6cVLT0dwg8xe5q4
=R/Q0
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2009-09-07 9:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-05 7:25 [PATCH] [RFC] Do the PIN check in SIMManager Andrzej Zaborowski
2009-09-07 9:53 ` Santtu Lakkala [this message]
2009-09-08 2:41 ` Andrzej Zaborowski
2009-09-17 18:57 ` Andrzej Zaborowski
2009-09-22 5:12 ` Denis Kenzior
2009-09-23 20:47 ` andrzej zaborowski
2009-09-23 20:02 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA4D80C.1090104@inz.fi \
--to=inz@inz.fi \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.